mbox series

[0/9] ARM: dts: dra7: add cal nodes

Message ID 20191018154849.3127-1-bparrot@ti.com
Headers show
Series ARM: dts: dra7: add cal nodes | expand

Message

Benoit Parrot Oct. 18, 2019, 3:48 p.m. UTC 
This patch series adds the needed clkctrl and ty-sysc nodes for CAL module.
It also adds support for the module in related dtsi and dts for DRA72,
DRA76 and AM654 SoC.

Benoit Parrot (9):
  ARM: dts: dra7: add cam clkctrl node
  ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only
  ARM: dts: dra7-l4: Add ti-sysc node for CAM
  ARM: dts: DRA72: Add CAL dtsi node
  arm: dts: dra72-evm-common: Add entries for the CSI2 cameras
  arm: dtsi: dra76x: Add CAL dtsi node
  arm: dts: dra76-evm: Add CAL and OV5640 nodes
  arm64: dts: k3-am65-main Add CAL node
  arm64: dts: k3-am654-base-board: Add CSI2 OV5640 camera

 arch/arm/boot/dts/dra7-l4.dtsi                | 43 ++++++++++++++++---
 arch/arm/boot/dts/dra72-evm-common.dtsi       | 35 +++++++++++++++
 arch/arm/boot/dts/dra72x.dtsi                 | 43 +++++++++++++++++++
 arch/arm/boot/dts/dra76-evm.dts               | 39 +++++++++++++++++
 arch/arm/boot/dts/dra76x.dtsi                 | 43 +++++++++++++++++++
 arch/arm/boot/dts/dra7xx-clocks.dtsi          | 14 ++++++
 arch/arm/mach-omap2/clockdomains7xx_data.c    |  2 +-
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      | 23 ++++++++++
 .../arm64/boot/dts/ti/k3-am654-base-board.dts | 36 ++++++++++++++++
 drivers/clk/ti/clk-7xx.c                      | 19 ++++++++
 include/dt-bindings/clock/dra7.h              | 10 +++++
 11 files changed, 300 insertions(+), 7 deletions(-)

Comments

Tony Lindgren Oct. 22, 2019, 3:44 p.m. UTC | #1 
* Benoit Parrot <bparrot@ti.com> [191018 15:46]:
> Add device nodes for CSI2 camera board OV5640.
> Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
>  arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> index 8641a3d7d8ad..e4c01a67f6de 100644
> --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> @@ -187,6 +187,12 @@
>  		gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
>  	};
> +
> +	clk_ov5640_fixed: clk_ov5640_fixed {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <24000000>;
> +	};
>  };

The clock node name should be generic and not use
undescores. If there is a hidden dependency to the
clock node name here, it should be mentioned in the
patch for the non-standard use.

Regards,

Tony
Benoit Parrot Oct. 22, 2019, 4:16 p.m. UTC | #2 
Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 08:44:46 -0700]:
> * Benoit Parrot <bparrot@ti.com> [191018 15:46]:
> > Add device nodes for CSI2 camera board OV5640.
> > Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> > 
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> >  arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > index 8641a3d7d8ad..e4c01a67f6de 100644
> > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > @@ -187,6 +187,12 @@
> >  		gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> >  		enable-active-high;
> >  	};
> > +
> > +	clk_ov5640_fixed: clk_ov5640_fixed {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +	};
> >  };
> 
> The clock node name should be generic and not use
> undescores. If there is a hidden dependency to the
> clock node name here, it should be mentioned in the
> patch for the non-standard use.

Not sure what you mean by generic, here.
This is just to provide a "clock" node which gives the "value" of the fixed
oscillator frequency so driver can get to it, the actual name does not
matter.

Benoit

> 
> Regards,
> 
> Tony
Tony Lindgren Oct. 22, 2019, 4:27 p.m. UTC | #3 
* Benoit Parrot <bparrot@ti.com> [191022 16:17]:
> Tony Lindgren <tony@atomide.com> wrote on Tue [2019-Oct-22 08:44:46 -0700]:
> > * Benoit Parrot <bparrot@ti.com> [191018 15:46]:
> > > Add device nodes for CSI2 camera board OV5640.
> > > Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> > > 
> > > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > > ---
> > >  arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > index 8641a3d7d8ad..e4c01a67f6de 100644
> > > --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> > > @@ -187,6 +187,12 @@
> > >  		gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> > >  		enable-active-high;
> > >  	};
> > > +
> > > +	clk_ov5640_fixed: clk_ov5640_fixed {
> > > +		compatible = "fixed-clock";
> > > +		#clock-cells = <0>;
> > > +		clock-frequency = <24000000>;
> > > +	};
> > >  };
> > 
> > The clock node name should be generic and not use
> > undescores. If there is a hidden dependency to the
> > clock node name here, it should be mentioned in the
> > patch for the non-standard use.
> 
> Not sure what you mean by generic, here.
> This is just to provide a "clock" node which gives the "value" of the fixed
> oscillator frequency so driver can get to it, the actual name does not
> matter.

Oh just something like:

	clk_ov5640_fixed: clock@foo {
		compatible = "fixed-clock";
		#clock-cells = <0>;
		clock-frequency = <24000000>;
	};

Or just clock if the only instance and no reg?

We currently get tons of warnings for TI clocks, that's
thousands of lines because of non-standard naming and
use of undescore instead of dash for the naming.. Let's
not add more.

Regards,

Tony