| Message ID | 20191015180717.4128-1-halves@canonical.com |
|---|---|
| Headers | show |
| Series | UBUNTU: d-i: Add iwlmvm to nic-modules | expand |
On Tue, Oct 15, 2019 at 03:07:16PM -0300, Heitor Alves de Siqueira wrote: > BugLink: https://bugs.launchpad.net/bugs/1848236 > > [Impact] > Some wireless Intel cards that use the iwlmvm driver are not available > during installation. > > [Test Case] > Boot up the Ubuntu installer on a system with an iwlmvm adapter, and try > using the wireless connection. > > [Fix] > Add the missing sub-module to debian.master/d-i/nic-modules > > [Regression Potential] > As we're including a new sub-module, this change makes the installer > susceptible to bugs present in the iwlmvm driver. Other than that, this > change should not introduce any new regressions as it doesn't change any > driver code. I'm surprised we haven't noticed this before. I'm not sure how this benefits disco though, or even xenial and bionic as afaik we aren't still generating desktop installer images using the GA kernel. Even for eoan, is there any benefit unless we respin to include the change (which seems unlikely at this point)? We do want to make sure this gets into the hwe-edge kernel though to ensure it's included in the next 20.04 point release. Applied to unstable/master. Holding my ack for the stable series kernels until I understand what benefit there is to having it there. Thanks, Seth
On Tue, Oct 15, 2019 at 3:45 PM Seth Forshee <seth.forshee@canonical.com> wrote: > > I'm surprised we haven't noticed this before. I'm not sure how this > benefits disco though, or even xenial and bionic as afaik we aren't > still generating desktop installer images using the GA kernel. Even for > eoan, is there any benefit unless we respin to include the change (which > seems unlikely at this point)? > > We do want to make sure this gets into the hwe-edge kernel though to > ensure it's included in the next 20.04 point release. > > Applied to unstable/master. Holding my ack for the stable series kernels > until I understand what benefit there is to having it there. > > Thanks, > Seth Hi Seth! Thanks for applying it to unstable. Apologies for not tagging the patch for that, but it would indeed be good to have that in the 20.04 release! :) As for the other stable series, wouldn't the netboot mini.iso benefit from having the driver included? I think that would get automatically rebuilt to include this change, so users working with the daily releases or the mini.iso would still benefit from this patch (even if we don't have any new point releases for the older Series). Would that be an appropriate use case? Thanks, Heitor
On Wed, Oct 16, 2019 at 03:10:36PM -0300, Heitor Alves de Siqueira wrote: > On Tue, Oct 15, 2019 at 3:45 PM Seth Forshee <seth.forshee@canonical.com> wrote: > > > > I'm surprised we haven't noticed this before. I'm not sure how this > > benefits disco though, or even xenial and bionic as afaik we aren't > > still generating desktop installer images using the GA kernel. Even for > > eoan, is there any benefit unless we respin to include the change (which > > seems unlikely at this point)? > > > > We do want to make sure this gets into the hwe-edge kernel though to > > ensure it's included in the next 20.04 point release. > > > > Applied to unstable/master. Holding my ack for the stable series kernels > > until I understand what benefit there is to having it there. > > > > Thanks, > > Seth > > Hi Seth! > Thanks for applying it to unstable. Apologies for not tagging the patch for > that, but it would indeed be good to have that in the 20.04 release! :) > > As for the other stable series, wouldn't the netboot mini.iso benefit from > having the driver included? I think that would get automatically rebuilt to > include this change, so users working with the daily releases or the mini.iso > would still benefit from this patch (even if we don't have any new point > releases for the older Series). Would that be an appropriate use case? I wasn't aware we did daily builds of the mini.iso for stable releases, and I wouldn't have guessed that the sorts of systems with wireless cards are generally netbooted. But if so the change is useful, and even if not it should be harmless, so: Acked-by: Seth Forshee <seth.forshee@canonical.com>
On 15.10.19 20:07, Heitor Alves de Siqueira wrote: > BugLink: https://bugs.launchpad.net/bugs/1848236 > > [Impact] > Some wireless Intel cards that use the iwlmvm driver are not available > during installation. > > [Test Case] > Boot up the Ubuntu installer on a system with an iwlmvm adapter, and try > using the wireless connection. > > [Fix] > Add the missing sub-module to debian.master/d-i/nic-modules > > [Regression Potential] > As we're including a new sub-module, this change makes the installer > susceptible to bugs present in the iwlmvm driver. Other than that, this > change should not introduce any new regressions as it doesn't change any > driver code. > > Heitor Alves de Siqueira (1): > UBUNTU: d-i: Add iwlmvm to nic-modules > > debian.master/d-i/modules/nic-modules | 1 + > 1 file changed, 1 insertion(+) > Applied to xenial, bionic, disco and eoan master-next branches. Thanks, Kleber