mbox series

[OpenWrt-Devel,urngd,0/4] sync with upstream, fixes and GitLab CI

Message ID 20191011084204.19790-1-ynezz@true.cz
Headers show
Series sync with upstream, fixes and GitLab CI | expand

Message

Petr Štetiar Oct. 11, 2019, 8:42 a.m. UTC
Hi,

this patch series sync jitterentropy-rngd with upstream release v1.1.0 (plus
one additional clang compile fix uncovered by CI) adds initial support for CI
testing and fixes the issues uncovered by this new CI tests. Those CI tests
are currently using my proof-of-concept openwrt-ci[1] in order to:

 * improve the quality of the codebase in various areas
 * decrease code review time and help merging contributions faster
 * get automagic feedback loop on various platforms and tools
   - out of tree build with OpenWrt SDK on following targets:
     * ath79-generic
     * imx6-generic
     * malta-be
     * mvebu-cortexa53
   - out of tree native build on x86/64 with GCC (versions 7, 8, 9) and Clang 9
   - out of tree native x86/64 static code analysis with cppcheck and
     scan-build from Clang 9

1. https://gitlab.com/ynezz/openwrt-ci/

Cheers,

Petr

Petr Štetiar (4):
  Add initial GitLab CI support
  Fix wrong types in format strings used in debug build
  jitterentropy-rngd: update to version v1.1.0 + clang compile fix
  Tag version 1.0.1

 .gitlab-ci.yml              | 7 +++++++
 3rdparty/jitterentropy-rngd | 2 +-
 CMakeLists.txt              | 2 +-
 urngd.c                     | 4 ++--
 4 files changed, 11 insertions(+), 4 deletions(-)
 create mode 100644 .gitlab-ci.yml

Comments

Rosen Penev Oct. 11, 2019, 8:49 a.m. UTC | #1
On Fri, Oct 11, 2019 at 1:42 AM Petr Štetiar <ynezz@true.cz> wrote:
>
> Hi,
>
> this patch series sync jitterentropy-rngd with upstream release v1.1.0 (plus
> one additional clang compile fix uncovered by CI) adds initial support for CI
> testing and fixes the issues uncovered by this new CI tests. Those CI tests
> are currently using my proof-of-concept openwrt-ci[1] in order to:
Is this related to
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20191011&id=3f2dc2798b81531fd93a3b9b7c39da47ec689e55
?
>
>  * improve the quality of the codebase in various areas
>  * decrease code review time and help merging contributions faster
>  * get automagic feedback loop on various platforms and tools
>    - out of tree build with OpenWrt SDK on following targets:
>      * ath79-generic
>      * imx6-generic
>      * malta-be
>      * mvebu-cortexa53
>    - out of tree native build on x86/64 with GCC (versions 7, 8, 9) and Clang 9
>    - out of tree native x86/64 static code analysis with cppcheck and
>      scan-build from Clang 9
>
> 1. https://gitlab.com/ynezz/openwrt-ci/
>
> Cheers,
>
> Petr
>
> Petr Štetiar (4):
>   Add initial GitLab CI support
>   Fix wrong types in format strings used in debug build
>   jitterentropy-rngd: update to version v1.1.0 + clang compile fix
>   Tag version 1.0.1
>
>  .gitlab-ci.yml              | 7 +++++++
>  3rdparty/jitterentropy-rngd | 2 +-
>  CMakeLists.txt              | 2 +-
>  urngd.c                     | 4 ++--
>  4 files changed, 11 insertions(+), 4 deletions(-)
>  create mode 100644 .gitlab-ci.yml
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Petr Štetiar Oct. 11, 2019, 9:13 a.m. UTC | #2
Rosen Penev <rosenp@gmail.com> [2019-10-11 01:49:56]:

Hi,

> Is this related to
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20191011&id=3f2dc2798b81531fd93a3b9b7c39da47ec689e55

no, I doubt that. In my case it was simply scan-build complaining[1] about
logic error in jitterentropy-base.c and I wanted to fix that, so as always
I've first tried to update to latest upstream version available where the
problem was luckily gone.

1. https://ynezz.gitlab.io/-/openwrt-urngd/-/jobs/318246115/artifacts/build/scan/2019-10-11-090723-297-1/index.html

Cheers,

Petr
Paul Oranje Oct. 11, 2019, 9:30 p.m. UTC | #3
> Op 11 okt. 2019, om 11:13 heeft Petr Štetiar <ynezz@true.cz> het volgende geschreven:
> 
> Rosen Penev <rosenp@gmail.com> [2019-10-11 01:49:56]:
> 
> Hi,
> 
>> Is this related to
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20191011&id=3f2dc2798b81531fd93a3b9b7c39da47ec689e55
> 
As usual, not really accidentally,  LWN has a very recent article on entropy pool at boot and initialisation of /dev/urandom, the getrandom() syscall and CRNG.

> no, I doubt that. In my case it was simply scan-build complaining[1] about
> logic error in jitterentropy-base.c and I wanted to fix that, so as always
> I've first tried to update to latest upstream version available where the
> problem was luckily gone.
> 
> 1. https://ynezz.gitlab.io/-/openwrt-urngd/-/jobs/318246115/artifacts/build/scan/2019-10-11-090723-297-1/index.html
> 
> Cheers,
> 
> Petr
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel