mbox series

[v2,0/7] add Tegra194 XUSB host and pad controller support

Message ID 20191004081941.4831-1-jckuo@nvidia.com
Headers show
Series add Tegra194 XUSB host and pad controller support | expand

Message

JC Kuo Oct. 4, 2019, 8:19 a.m. UTC 
Hi,

This series introduces support for Tegra194 XUSB host and pad
controller. Tegra194 XUSB host and pad controller are highly
similar to the controllers found on Tegra186. Therefore, it's
possible to resue xhci-tegra.c and xusb-tegra186.c for Tegra194.

JC Kuo (7):
  xhci: tegra: Parameterize mailbox register addresses
  usb: host: xhci-tegra: Add Tegra194 XHCI support
  phy: tegra: xusb: Protect Tegra186 soc with config
  phy: tegra: xusb: Add Tegra194 support
  dt-bindings: phy: tegra: Add Tegra194 support
  arm64: tegra: Add XUSB and pad controller on Tegra194
  arm64: tegra: Enable XUSB host in P2972-0000 board

 .../phy/nvidia,tegra124-xusb-padctl.txt       |  16 ++
 .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi |  36 ++++-
 .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  62 ++++++++
 arch/arm64/boot/dts/nvidia/tegra194.dtsi      | 139 +++++++++++++++++
 drivers/phy/tegra/Makefile                    |   1 +
 drivers/phy/tegra/xusb-tegra186.c             | 144 +++++++++++++-----
 drivers/phy/tegra/xusb.c                      |   7 +
 drivers/phy/tegra/xusb.h                      |   6 +
 drivers/usb/host/xhci-tegra.c                 |  88 +++++++++--
 9 files changed, 448 insertions(+), 51 deletions(-)

Comments

gregkh@linuxfoundation.org Oct. 4, 2019, 12:23 p.m. UTC | #1 
On Fri, Oct 04, 2019 at 04:19:34PM +0800, JC Kuo wrote:
> Hi,
> 
> This series introduces support for Tegra194 XUSB host and pad
> controller. Tegra194 XUSB host and pad controller are highly
> similar to the controllers found on Tegra186. Therefore, it's
> possible to resue xhci-tegra.c and xusb-tegra186.c for Tegra194.
> 
> JC Kuo (7):
>   xhci: tegra: Parameterize mailbox register addresses
>   usb: host: xhci-tegra: Add Tegra194 XHCI support
>   phy: tegra: xusb: Protect Tegra186 soc with config
>   phy: tegra: xusb: Add Tegra194 support
>   dt-bindings: phy: tegra: Add Tegra194 support
>   arm64: tegra: Add XUSB and pad controller on Tegra194
>   arm64: tegra: Enable XUSB host in P2972-0000 board

What changed from v1?  You need to put that somewhere, usually in the
patches themselves, below the --- line.

Or at the very least, in the cover letter.

Given that I can't find it anywhere here, I'll expect a v3 with that
information to be sent soon :(

thanks,

greg k-h
JC Kuo Oct. 4, 2019, 4:08 p.m. UTC | #2 
On 10/4/19 8:23 PM, Greg KH wrote:
> On Fri, Oct 04, 2019 at 04:19:34PM +0800, JC Kuo wrote:
>> Hi,
>>
>> This series introduces support for Tegra194 XUSB host and pad
>> controller. Tegra194 XUSB host and pad controller are highly
>> similar to the controllers found on Tegra186. Therefore, it's
>> possible to resue xhci-tegra.c and xusb-tegra186.c for Tegra194.
>>
>> JC Kuo (7):
>>   xhci: tegra: Parameterize mailbox register addresses
>>   usb: host: xhci-tegra: Add Tegra194 XHCI support
>>   phy: tegra: xusb: Protect Tegra186 soc with config
>>   phy: tegra: xusb: Add Tegra194 support
>>   dt-bindings: phy: tegra: Add Tegra194 support
>>   arm64: tegra: Add XUSB and pad controller on Tegra194
>>   arm64: tegra: Enable XUSB host in P2972-0000 board
> 
> What changed from v1?  You need to put that somewhere, usually in the
> patches themselves, below the --- line.
> 
> Or at the very least, in the cover letter.
> 
> Given that I can't find it anywhere here, I'll expect a v3 with that
> information to be sent soon :(
> 
For the first two patches, v2 is identical to v1, sorry that I didn't describe
in patches. For the patches 3 to 7, the individual patch has "Changes in v2:"
session to describe.
I will submit v3 with patch 1 and 2 updated.

Thanks for the guidance,
JC