[v6a,0/7] Fixes for Extended Key ID patch series V6
mbox series

Message ID 20190928181807.180530-1-alexander@wetzel-home.de
Headers show
Series
  • Fixes for Extended Key ID patch series V6
Related show

Message

Alexander Wetzel Sept. 28, 2019, 6:18 p.m. UTC
This is basically V7 of the series:
 Support seamless PTK rekeys with Extended Key ID

As discussed by mail I'm not sending the full patches but only the
differences compared to V6 of the series for better integration in your
own test tree.

Each patch is simply a fixup for the referenced V6 patch and only the
first has some already discussed corrections to the commit message.
But the patches assume you have the complete V6 patch series applied and
are on top of if. Merging them in the correct position will cause merge
conflicts. The full V7 patch series with the fixups moved to the correct
position can be found here:
https://www.awhome.eu/index.php/s/o5m9Q29n37zbEga in the folder V7.
(I think I got the rebase right but did just confirm we have the same
code in the end.)

To make clear that this is not a independent patch set I'm calling it
v6a. (The files from the link above with all "Fixes for" patches merged
as fixups would be V7.)

From a user point of view V6 and V6a will behave nearly identical, only
some log messages should be better. From a programmers perspective it
hopefully unifies the logic, streamlines the code a bit and adds a new
test case with a TKIP only AP.

I did a full test run again which indicates that nothing broke.
You can again download it here:
https://www.awhome.eu/index.php/s/jDQfpZmDGwsLPXA

The new test run is be907f722-patched.tgz

Changes compared to V6:
 - Improved TKIP detection (nicer logs and better logic)
 - Also use config checks for Extended Key ID activation, not only
   runtime
 - Simplify runtime checks due to the now existing config checks
 - Fixes some key_type for both hostap and wpa_supplicant
 - nl80211 now denies to install a pairwise key with the
   KEY_TYPE_DEFAULT set and has other minor cleanups
 - Fixes the bitmask for pairwise keys for consistency (no real effect)
 - Rewords some log messages 

Alexander Wetzel (7):
  Fixes for hostapd: Set the correct key_type for key installs
  Fixes for wpa_supplicant: Set the correct key_type for key installs
  Fixes for nl80211: Switch to the new key_type API & cleanup
  Fixes for hostapd: Add support for Extended Key ID
  Fixes for wpa_supplicant: AP Extended Key ID support
  Fixes for tests: Extended Key ID tests
  Fixes for wpa_supplicant: FILS Extended Key ID support

 src/ap/ap_config.c              |  2 +-
 src/ap/ieee802_1x.c             |  2 +-
 src/ap/wpa_auth.c               |  2 +-
 src/ap/wpa_auth_ft.c            |  6 +-----
 src/ap/wpa_auth_glue.c          | 15 +++------------
 src/ap/wpa_auth_ie.c            | 33 ++++++++++++++++++++-------------
 src/drivers/driver_nl80211.c    | 18 ++++++++++--------
 tests/hwsim/hostapd.py          | 13 ++++++-------
 tests/hwsim/test_ap_psk.py      | 10 ++++++++++
 wpa_supplicant/wpa_supplicant.c |  7 +++++--
 wpa_supplicant/wpas_glue.c      |  5 +++--
 11 files changed, 61 insertions(+), 52 deletions(-)