From patchwork Tue Sep 24 07:59:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1166421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46ctsP00VQz9sP3; Tue, 24 Sep 2019 18:00:24 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iCfkB-0007Od-1m; Tue, 24 Sep 2019 08:00:19 +0000 Received: from mail-pf1-f195.google.com ([209.85.210.195]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iCfk2-0007Hf-M6 for kernel-team@lists.ubuntu.com; Tue, 24 Sep 2019 08:00:10 +0000 Received: by mail-pf1-f195.google.com with SMTP id x127so815293pfb.7 for ; Tue, 24 Sep 2019 01:00:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=bK+2Vk9zxctG4f3avx16ELFs6IBqpAYMHQQbLPBlQzs=; b=CLVC7Bavza5JbDOx1Qw4+XOY18GRJyPj6pgJJjV5D6sBCGs4e697wPBwYKEGTGPU4j CZkki0oe9tu5qJ4qZ8zlHC9v3WkeNslNxU/xJ7vB4WpG82sxqMYrI6JS6oK9CjGNK4uu kBg7uI0di0YtDFi2G2HwrXTA8XJeDiR5arNUEjXMyNx6lnubn0aBbyesgoqtq3KZRNdD olMGiYWotrZ+YuPqgmDG1KQ4xJlSLpM9LAcX07BxiSMNgEOKOhzcy0M6AW+EZJfDC9rQ S5UTlCxIo31mHZKmlPYPvTcEoWXrDB9xAoZl80FOlDkzWLGA1ZN9E6bwPyk6ssWflVpv DcnQ== X-Gm-Message-State: APjAAAUH50GI9mdM/NFa9sGhQVBrsnbRand92XYHlocm1lQREv6Ni/3u UN7KeTDa7vI/ACn4aWATEbjvw0Jy X-Google-Smtp-Source: APXvYqw8KEslGBveOsv4SYmP40caBhE9w/cvhc+O8rAQrn+YPi3oaNDi7uSVr7/WDT8KrnZK02otGw== X-Received: by 2002:a63:df10:: with SMTP id u16mr1833160pgg.373.1569312008325; Tue, 24 Sep 2019 01:00:08 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id g202sm1359780pfb.155.2019.09.24.01.00.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Sep 2019 01:00:07 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 00/21][SRU][OEM-OSP1-B] iwlwifi: mvm: support HE context cmd API change Date: Tue, 24 Sep 2019 15:59:26 +0800 Message-Id: <20190924075947.33954-1-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1845138 [Impact] When trying to associate with an 802.11ax Wi-Fi AP on platforms with Intel AX1650s/AX1650i, iwlwifi gives a firmware error about command in SYN CMD STA_HE_CTXT_CMD and hardware resets. [Fix] AX1650s/AX1650i firmware expects passed command struct to include multiple bssid support when associating with 802.11ax APs, and the implementation has been landed to v5.2 as: commit d14ae796f849: iwlwifi: mvm: support HE context cmd API change This commit, along with its prerequisites in kernel mac80211/cfg80211 framework are neccesary to complete 802.11ax AP associations. [Test Case] Tested on AX1650s/AX1650i, as well as 9462/9560, to associate with AX/N/AC/BG open/wpa AP. [Regression Risk] Medium. These patches introduces new features to mac80211/cfg80211 framework but are only enabled when IEEE80211_HW_SUPPORTS_MULTI_BSSID and/or IEEE80211_HW_SUPPORTS_ONLY_HE_MULTI_BSSID are set. There is also refactoring to information element access for cfg80211. For the firmware part, this should only be enabled when firmware blobs has explicitly declared IWL_UCODE_TLV_API_MBSSID_HE capability. And when this capability is set, like fw for AX1650s/AX1650i, changes here are necessary to make an association to 802.11ax Wi-Fi AP successfully. Johannes Berg (6): cfg80211: add and use strongly typed element iteration macros mac80211: use element iteration macro in parsing cfg80211: add various struct element finding helpers nl80211: use for_each_element() in validate_ie_attr() cfg80211: use for_each_element() for multi-bssid parsing cfg80211: add missing kernel-doc for multi-BSSID fields Jouni Malinen (1): mac80211_hwsim: Declare support for Multi-BSSID Peng Xu (1): cfg80211: Parsing of Multiple BSSID information in scanning Sara Sharon (13): mac80211: pass bssids to elements parsing function mac80211: move the bss update from elements to an helper cfg80211: Properly track transmitting and non-transmitting BSS cfg80211: Move Multiple BSS info to struct cfg80211_bss to be visible cfg80211: parse multi-bssid only if HW supports it cfg80211: make BSSID generation function inline cfg80211: save multi-bssid properties mac80211: support multi-bssid mac80211: indicate support for multiple BSSID cfg80211: fix the IE inheritance of extension IEs cfg80211: fix memory leak of new_ie iwlwifi: mvm: support multiple BSSID iwlwifi: mvm: support HE context cmd API change .../net/wireless/intel/iwlwifi/fw/api/mac.h | 77 ++- drivers/net/wireless/intel/iwlwifi/fw/file.h | 3 + .../net/wireless/intel/iwlwifi/mvm/mac80211.c | 22 +- drivers/net/wireless/mac80211_hwsim.c | 1 + include/linux/ieee80211.h | 92 ++- include/net/cfg80211.h | 179 +++++- include/net/mac80211.h | 22 + net/mac80211/debugfs.c | 4 +- net/mac80211/ibss.c | 8 +- net/mac80211/ieee80211_i.h | 20 +- net/mac80211/main.c | 13 +- net/mac80211/mesh.c | 10 +- net/mac80211/mesh_hwmp.c | 3 +- net/mac80211/mesh_plink.c | 4 +- net/mac80211/mlme.c | 185 ++++-- net/mac80211/scan.c | 160 +++-- net/mac80211/tdls.c | 6 +- net/mac80211/util.c | 133 +++- net/wireless/core.h | 13 +- net/wireless/nl80211.c | 28 +- net/wireless/scan.c | 595 ++++++++++++++++-- net/wireless/util.c | 6 +- 22 files changed, 1314 insertions(+), 270 deletions(-) Acked-by: Sultan Alsawaf