| Message ID | 20190920130218.32690-1-s.nawrocki@samsung.com |
|---|---|
| Headers | show |
| Series | Basic sound support for Arndale board / wm8994 updates | expand |
On Fri, Sep 20, 2019 at 03:02:13PM +0200, Sylwester Nawrocki wrote: > As an intermediate step before covering the clocking subsystem > of the CODEC entirely by the clk API add handling of external CODEC's > master clocks in DAPM events when the AIFn clocks are sourced directly > from MCLKn; when FLLn are used we enable/disable respective MCLKn > before/after FLLn is enabled/disabled. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- Looks good to me: Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Fri, Sep 20, 2019 at 03:02:11PM +0200, Sylwester Nawrocki wrote: > Ensure there is no OF node references kept when the driver > is removed/unbound. > > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - rebased to beginning of the series > --- > sound/soc/samsung/arndale_rt5631.c | 34 ++++++++++++++++++++++++++---- > 1 file changed, 30 insertions(+), 4 deletions(-) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Sep 20, 2019 at 03:02:13PM +0200, Sylwester Nawrocki wrote: > As an intermediate step before covering the clocking subsystem > of the CODEC entirely by the clk API add handling of external CODEC's > master clocks in DAPM events when the AIFn clocks are sourced directly > from MCLKn; when FLLn are used we enable/disable respective MCLKn > before/after FLLn is enabled/disabled. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - addressed review comments from Charles > --- > sound/soc/codecs/wm8994.c | 108 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 104 insertions(+), 4 deletions(-) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On 9/20/19 15:02, Sylwester Nawrocki wrote: > Extend the set_sysclk() handler so we also set frequency of the MCLK1, > MCLK2 clocks through clk API when those clocks are specified in DT. > > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Sorry, I squashed other patch to this one but forgot to remove above tags, not sure if those still stand as there was rather significant change in the patch. > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - getting of clocks moved from MFD to the CODEC's driver probe() > ---
On 9/23/19 10:51, Charles Keepax wrote: > On Fri, Sep 20, 2019 at 03:02:13PM +0200, Sylwester Nawrocki wrote: >> As an intermediate step before covering the clocking subsystem >> of the CODEC entirely by the clk API add handling of external CODEC's >> master clocks in DAPM events when the AIFn clocks are sourced directly >> from MCLKn; when FLLn are used we enable/disable respective MCLKn >> before/after FLLn is enabled/disabled. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > Looks good to me: > > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks a lot for reviewing!
On Fri, Sep 20, 2019 at 03:02:16PM +0200, Sylwester Nawrocki wrote: > The Arndale boards come with different types of the audio daughter > board. In order to support the WM1811 one we add new definition of > an ASoC card which will be registered when the driver matches on > "samsung,arndale-wm1811" compatible. There is no runtime detection of > the audio daughter board type at the moment, compatible string of the > audio card needs to be adjusted in DT, e.g. by the bootloader, > depending on actual audio board (CODEC) used. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - removed unneeded __maybe_used attribute > --- > sound/soc/samsung/Kconfig | 2 + > sound/soc/samsung/arndale_rt5631.c | 85 +++++++++++++++++++++++++----- > 2 files changed, 74 insertions(+), 13 deletions(-) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Sep 20, 2019 at 03:02:17PM +0200, Sylwester Nawrocki wrote: > Rename arndale_rt5631.c to just arnddale.c as we support other CODECs > than RT5631. While at it replace spaces in Kconfig with tabs. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - new patch. > --- > sound/soc/samsung/Kconfig | 10 +++++----- > sound/soc/samsung/Makefile | 4 ++-- > sound/soc/samsung/{arndale_rt5631.c => arndale.c} | 0 > 3 files changed, 7 insertions(+), 7 deletions(-) > rename sound/soc/samsung/{arndale_rt5631.c => arndale.c} (100%) Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Mon, Sep 23, 2019 at 11:10:48AM +0200, Sylwester Nawrocki wrote: > On 9/20/19 15:02, Sylwester Nawrocki wrote: > > Extend the set_sysclk() handler so we also set frequency of the MCLK1, > > MCLK2 clocks through clk API when those clocks are specified in DT. > > > > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > Sorry, I squashed other patch to this one but forgot to remove above tags, > not sure if those still stand as there was rather significant change in > the patch. > I am happy with my tag being there. Thanks, Charles
On Mon, Sep 23, 2019 at 11:10:48AM +0200, Sylwester Nawrocki wrote: > On 9/20/19 15:02, Sylwester Nawrocki wrote: > > Extend the set_sysclk() handler so we also set frequency of the MCLK1, > > MCLK2 clocks through clk API when those clocks are specified in DT. > > > > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > > Sorry, I squashed other patch to this one but forgot to remove above tags, > not sure if those still stand as there was rather significant change in > the patch. It's good. For the record: Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Fri, Sep 20, 2019 at 03:02:14PM +0200, Sylwester Nawrocki wrote: > There is only one DAI link so we can drop an unnecessary loop statement. > Use card->dai_link in place of direct static arndale_rt5631_dai[] array > dereference as a prerequisite for adding support for other CODECs. > Unnecessary assignment of dai_link->codecs->name to NULL is removed. This doesn't apply against current code, please check and resend.
On Fri, Sep 20, 2019 at 03:02:16PM +0200, Sylwester Nawrocki wrote: > The Arndale boards come with different types of the audio daughter > board. In order to support the WM1811 one we add new definition of > an ASoC card which will be registered when the driver matches on > "samsung,arndale-wm1811" compatible. There is no runtime detection of > the audio daughter board type at the moment, compatible string of the > audio card needs to be adjusted in DT, e.g. by the bootloader, > depending on actual audio board (CODEC) used. This doesn't apply against current code, please check and resend.
On Fri, Sep 20, 2019 at 03:02:17PM +0200, Sylwester Nawrocki wrote: > Rename arndale_rt5631.c to just arnddale.c as we support other CODECs > than RT5631. While at it replace spaces in Kconfig with tabs. This doesn't apply against current code, please check and resend.
On Fri, Sep 20, 2019 at 03:02:18PM +0200, Sylwester Nawrocki wrote: > Add sound node and the clock configurations for the I2S controller > for audio support on the Exynos5250 SoC Arndale boards with > WM1811 based audio daughter board. > > We need to increase drive strength of the I2S bus, otherwise > the audio CODEC doesn't work. Likely the CODEC's master clock > is the main issue here. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v1: > - moved &clock, &clock_audss parts to preserve alphabetical order > --- > arch/arm/boot/dts/exynos5250-arndale.dts | 27 +++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) This does not apply. Please rebase and resend. Best regards, Krzysztof
This patch series adds basic audio support for Exynos5250 SoC based Arndale board, the Bluetooth receiver source and HDMI output are not covered yet. There is also one fix for wm8994 driver related to WM1811 CODEC and wm8994 updates to handle MCLK clocks, similar to patches: ae1ea48c5c59 ("ASoC: arizona: Add gating for source clocks of the FLLs") 7a4413d0dc96 ("ASoC: arizona: Add gating for clock when used for direct MCLK") The main changes since v1: - Fixed bug in "ASoC: wm8994: Add support for MCLKn clock gating" patch (thanks to Charles), - dropped the MFD part patch and moved getting of clocks to the CODEC driver, - Added missing Kconfig entries to patch "ASoC: samsung: arndale: Add support for WM1811 CODEC", - Added a patch renaming the driver and a patch for exynos_defconfig. Sylwester Nawrocki (10): ASoC: wm8994: Do not register inapplicable controls for WM1811 ASoC: samsung: arndale: Add missing OF node dereferencing ASoC: wm8994: Add support for setting MCLK clock rate ASoC: wm8994: Add support for MCLKn clock gating ASoC: samsung: arndale: Simplify DAI link initialization ASoC: dt-bindings: Document "samsung,arndale-wm1811" compatible ASoC: samsung: arndale: Add support for WM1811 CODEC ASoC: samsung: Rename Arndale card driver ARM: dts: arndale: Add audio support (WM1811 CODEC boards) ARM: exynos_defconfig: Enable Arndale audio driver .../devicetree/bindings/sound/arndale.txt | 5 +- arch/arm/boot/dts/exynos5250-arndale.dts | 27 ++- arch/arm/configs/exynos_defconfig | 1 + sound/soc/codecs/wm8994.c | 199 +++++++++++++--- sound/soc/codecs/wm8994.h | 10 +- sound/soc/samsung/Kconfig | 12 +- sound/soc/samsung/Makefile | 4 +- sound/soc/samsung/arndale.c | 217 ++++++++++++++++++ sound/soc/samsung/arndale_rt5631.c | 138 ----------- 9 files changed, 438 insertions(+), 175 deletions(-) create mode 100644 sound/soc/samsung/arndale.c delete mode 100644 sound/soc/samsung/arndale_rt5631.c