mbox series

[0/1,SRU,B,D,E,Unstable] BT advertising packet wakes up the system from S3 and suspend-to-idle

Message ID 20190917082151.13829-1-acelan.kao@canonical.com
Headers show
Series BT advertising packet wakes up the system from S3 and suspend-to-idle | expand

Message

AceLan Kao Sept. 17, 2019, 8:21 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1844247

[Impact]
The new feature added by below commit let BT device to wake up the system
from S3 or s2idle.
   a0085f2510e8 ("Bluetooth: btusb: driver to enable the usb-wakeup feature")
But this feature also wakes up the system randomly from an unpaired BLE
device by its advertising packets.

[Fix]
There is no easy way to fix this and requires firmware update, so current
solution for this is to revert it.
   1ffdb51f28e8 ("Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"")

[Test]
Verified on machines which has paired BLE devices, and can't be waken up by
BT devices after entered suspended.

[Regression]
Yes, it reverts the feature by waking up system from s2idle by paired BT
devices, but this feature introduces regression, so I'd suggest to revert it.

Mario Limonciello (1):
  Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"

 drivers/bluetooth/btusb.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Kleber Sacilotto de Souza Sept. 27, 2019, 1:25 p.m. UTC | #1 
On 17.09.19 10:21, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1844247
> 
> [Impact]
> The new feature added by below commit let BT device to wake up the system
> from S3 or s2idle.
>    a0085f2510e8 ("Bluetooth: btusb: driver to enable the usb-wakeup feature")
> But this feature also wakes up the system randomly from an unpaired BLE
> device by its advertising packets.
> 
> [Fix]
> There is no easy way to fix this and requires firmware update, so current
> solution for this is to revert it.
>    1ffdb51f28e8 ("Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"")
> 
> [Test]
> Verified on machines which has paired BLE devices, and can't be waken up by
> BT devices after entered suspended.
> 
> [Regression]
> Yes, it reverts the feature by waking up system from s2idle by paired BT
> devices, but this feature introduces regression, so I'd suggest to revert it.
> 
> Mario Limonciello (1):
>   Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
> 
>  drivers/bluetooth/btusb.c | 5 -----
>  1 file changed, 5 deletions(-)
> 

This fix has already been applied to Disco as part of bug #1845390 (Disco update:
upstream stable patchset 2019-09-25) and to Bionic as part of bug #1845266 (Bionic
update: upstream stable patchset 2019-09-24).


Thanks,
Kleber