mbox series

[v2,0/2] block/nvme: add support for write zeros and discard

Message ID 20190913133627.28450-1-mlevitsk@redhat.com
Headers show
Series block/nvme: add support for write zeros and discard | expand

Message

Maxim Levitsky Sept. 13, 2019, 1:36 p.m. UTC 
This is the second part of the patches I prepared
for this driver back when I worked on mdev-nvme.

V2: addressed review feedback, no major changes

Best regards,
	Maxim Levitsky

Maxim Levitsky (2):
  block/nvme: add support for write zeros
  block/nvme: add support for discard

 block/nvme.c         | 155 ++++++++++++++++++++++++++++++++++++++++++-
 block/trace-events   |   3 +
 include/block/nvme.h |  19 +++++-
 3 files changed, 175 insertions(+), 2 deletions(-)

Comments

Max Reitz Oct. 28, 2019, 10:35 a.m. UTC | #1 
On 13.09.19 15:36, Maxim Levitsky wrote:
> This is the second part of the patches I prepared
> for this driver back when I worked on mdev-nvme.
> 
> V2: addressed review feedback, no major changes
> 
> Best regards,
> 	Maxim Levitsky
> 
> Maxim Levitsky (2):
>   block/nvme: add support for write zeros
>   block/nvme: add support for discard
> 
>  block/nvme.c         | 155 ++++++++++++++++++++++++++++++++++++++++++-
>  block/trace-events   |   3 +
>  include/block/nvme.h |  19 +++++-
>  3 files changed, 175 insertions(+), 2 deletions(-)
Thanks, fixed the indentation in nvme.h in patch 1, and applied to my
block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

For the record, I don’t think !!x has benefits over x != 0 and I
personally prefer bool y = x over any of it. O:-)

Max
John Snow Oct. 29, 2019, 1:33 p.m. UTC | #2 
On 10/28/19 6:35 AM, Max Reitz wrote:
> On 13.09.19 15:36, Maxim Levitsky wrote:
>> This is the second part of the patches I prepared
>> for this driver back when I worked on mdev-nvme.
>>
>> V2: addressed review feedback, no major changes
>>
>> Best regards,
>> 	Maxim Levitsky
>>
>> Maxim Levitsky (2):
>>   block/nvme: add support for write zeros
>>   block/nvme: add support for discard
>>
>>  block/nvme.c         | 155 ++++++++++++++++++++++++++++++++++++++++++-
>>  block/trace-events   |   3 +
>>  include/block/nvme.h |  19 +++++-
>>  3 files changed, 175 insertions(+), 2 deletions(-)
> Thanks, fixed the indentation in nvme.h in patch 1, and applied to my
> block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 
> For the record, I don’t think !!x has benefits over x != 0 and I
> personally prefer bool y = x over any of it. O:-)
> 

Well, that's even better :) For me, it's about making booleans obvious
as booleans and that's all.

--js
Maxim Levitsky Nov. 4, 2019, 5:54 p.m. UTC | #3 
On Tue, 2019-10-29 at 09:33 -0400, John Snow wrote:
> 
> On 10/28/19 6:35 AM, Max Reitz wrote:
> > On 13.09.19 15:36, Maxim Levitsky wrote:
> > > This is the second part of the patches I prepared
> > > for this driver back when I worked on mdev-nvme.
> > > 
> > > V2: addressed review feedback, no major changes
> > > 
> > > Best regards,
> > > 	Maxim Levitsky
> > > 
> > > Maxim Levitsky (2):
> > >   block/nvme: add support for write zeros
> > >   block/nvme: add support for discard
> > > 
> > >  block/nvme.c         | 155 ++++++++++++++++++++++++++++++++++++++++++-
> > >  block/trace-events   |   3 +
> > >  include/block/nvme.h |  19 +++++-
> > >  3 files changed, 175 insertions(+), 2 deletions(-)
> > 
> > Thanks, fixed the indentation in nvme.h in patch 1, and applied to my
> > block branch:
> > 
> > https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> > 
> > For the record, I don’t think !!x has benefits over x != 0 and I
> > personally prefer bool y = x over any of it. O:-)
> > 
> 
> Well, that's even better :) For me, it's about making booleans obvious
> as booleans and that's all.
> 
> --js
Thanks to all of you!!
Best regards,
	Maxim Levitsky