| Message ID | cover.1568274587.git.rahul.tanwar@linux.intel.com |
|---|---|
| Headers | show |
| Series | pinctrl: Add new pinctrl/GPIO driver | expand |
Hi Rahul, thanks for your patches! On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar <rahul.tanwar@linux.intel.com> wrote: > This series is to add pinctrl & GPIO controller driver for a new SoC. > Patch 1 adds pinmux & GPIO controller driver. > Patch 2 adds the dt bindings document & include file. > > Patches are against Linux 5.3-rc5 at below Git tree: > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git OK nice, I think you need to include Mika Westerberg on this review as well, because I think he likes to stay on top of all things intel in pin control. (Also included two other Intel folks in Finland who usually take an interest in these things.) Yours, Linus Walleij
On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > Hi Rahul, > > thanks for your patches! > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > <rahul.tanwar@linux.intel.com> wrote: > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > Patch 1 adds pinmux & GPIO controller driver. > > Patch 2 adds the dt bindings document & include file. > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > OK nice, I think you need to include Mika Westerberg on this review > as well, because I think he likes to stay on top of all things intel > in pin control. (Also included two other Intel folks in Finland who usually > take an interest in these things.) Linus, nevertheless I guess you may give your comments WRT device tree use (bindings, helpers, etc) along with some basics, (like devm_*() [ab]use I just noticed).
On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko <andriy.shevchenko@intel.com> wrote: > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > > Hi Rahul, > > > > thanks for your patches! > > > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > > <rahul.tanwar@linux.intel.com> wrote: > > > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > > Patch 1 adds pinmux & GPIO controller driver. > > > Patch 2 adds the dt bindings document & include file. > > > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > > > OK nice, I think you need to include Mika Westerberg on this review > > as well, because I think he likes to stay on top of all things intel > > in pin control. (Also included two other Intel folks in Finland who usually > > take an interest in these things.) > > Linus, > nevertheless I guess you may give your comments WRT device tree use > (bindings, helpers, etc) along with some basics, (like devm_*() > [ab]use I just noticed). I plan to look at the patches per se but right now I don't have much time because soon there is merge window and kernel summit, the patches just need to age a little bit like a good wine ;) Yours, Linus Walleij
On Thu, Sep 12, 2019 at 03:30:52PM +0100, Linus Walleij wrote: > On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > > > Hi Rahul, > > > > > > thanks for your patches! > > > > > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > > > <rahul.tanwar@linux.intel.com> wrote: > > > > > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > > > Patch 1 adds pinmux & GPIO controller driver. > > > > Patch 2 adds the dt bindings document & include file. > > > > > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > > > > > OK nice, I think you need to include Mika Westerberg on this review > > > as well, because I think he likes to stay on top of all things intel > > > in pin control. (Also included two other Intel folks in Finland who usually > > > take an interest in these things.) > > > > Linus, > > nevertheless I guess you may give your comments WRT device tree use > > (bindings, helpers, etc) along with some basics, (like devm_*() > > [ab]use I just noticed). > > I plan to look at the patches per se but right now I don't have much > time because soon there is merge window and kernel summit, > the patches just need to age a little bit like a good wine ;) I meant in general, I know about merge window, so, I guess this is not material for v5.4. I reviewed it a bit, hope this helps.
On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > Hi Rahul, > > thanks for your patches! > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > <rahul.tanwar@linux.intel.com> wrote: > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > Patch 1 adds pinmux & GPIO controller driver. > > Patch 2 adds the dt bindings document & include file. > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > OK nice, I think you need to include Mika Westerberg on this review > as well, because I think he likes to stay on top of all things intel > in pin control. (Also included two other Intel folks in Finland who usually > take an interest in these things.) Thanks Linus for looping me in. Even if this is not directly based on the stuff we have under drivers/pinctrl/intel/*, I have a couple of comments. I don't have this patch series in my inbox so I'm commenting here. Since the driver name is equilibrium I suggest you to name intel_pinctrl_driver and the like (probe, remove) to follow that convention to avoid confusing this with the Intel pinctrl drivers under drivers/pinctrl/intel/*. Maybe use eqbr prefix so then intel_pinctrl_driver becomes eqbr_pinctrl_driver and so on. Also all the structures like intel_pinctrl_drv_data should be changed accordingly. Ditto for: MODULE_DESCRIPTION("Intel Pinctrl Driver for LGM SoC"); I think better would be: MODULE_DESCRIPTION("Pinctrl Driver for LGM SoC (Equilibrium)"); Anyway you get the idea :)
Hi Mika, On 13/9/2019 4:18 PM, Mika Westerberg wrote: > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: >> Hi Rahul, >> >> thanks for your patches! >> >> On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar >> <rahul.tanwar@linux.intel.com> wrote: >> >>> This series is to add pinctrl & GPIO controller driver for a new SoC. >>> Patch 1 adds pinmux & GPIO controller driver. >>> Patch 2 adds the dt bindings document & include file. >>> >>> Patches are against Linux 5.3-rc5 at below Git tree: >>> git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git >> OK nice, I think you need to include Mika Westerberg on this review >> as well, because I think he likes to stay on top of all things intel >> in pin control. (Also included two other Intel folks in Finland who usually >> take an interest in these things.) > Thanks Linus for looping me in. > > Even if this is not directly based on the stuff we have under > drivers/pinctrl/intel/*, I have a couple of comments. I don't have this > patch series in my inbox so I'm commenting here. > > Since the driver name is equilibrium I suggest you to name > intel_pinctrl_driver and the like (probe, remove) to follow that > convention to avoid confusing this with the Intel pinctrl drivers under > drivers/pinctrl/intel/*. > > Maybe use eqbr prefix so then intel_pinctrl_driver becomes > eqbr_pinctrl_driver and so on. Also all the structures like > intel_pinctrl_drv_data should be changed accordingly. > > Ditto for: > > MODULE_DESCRIPTION("Intel Pinctrl Driver for LGM SoC"); > > I think better would be: > > MODULE_DESCRIPTION("Pinctrl Driver for LGM SoC (Equilibrium)"); > > Anyway you get the idea :) Yes, i understand your point. Will update in v2. Thanks. Regards, Rahul