| Message ID | 20190906084539.21838-1-geert+renesas@glider.be |
|---|---|
| Headers | show |
| Series | gpio: API boundary cleanups | expand |
pt., 6 wrz 2019 o 10:45 Geert Uytterhoeven <geert+renesas@glider.be> napisał(a): > > Hi Linus, Bartosz, > > This patch series contains various API boundary cleanups for gpiolib: > - The first two patches make two functions private, > - The last two patches switch the remaining gpiolib exported functions > from EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL(). > > After this there is only a single GPIO driver function exported with > EXPORT_SYMBOL(); > > drivers/gpio/gpio-htc-egpio.c:EXPORT_SYMBOL(htc_egpio_get_wakeup_irq); > > I believe this symbol was never used upstream, and may be a relic of the > original out-of-tree code the htc-egpio was based on. I don't know if > there (still) exist out-of-tree users of the symbol. > > Thanks for your comments! All looks good to me. Are you fine with this being picked up after the v5.4 merge window? Bart > > Geert Uytterhoeven (4): > gpio: of: Make of_get_named_gpiod_flags() private > gpio: of: Make of_gpio_simple_xlate() private > gpio: of: Switch to EXPORT_SYMBOL_GPL() > gpio: devres: Switch to EXPORT_SYMBOL_GPL() > > drivers/gpio/gpiolib-devres.c | 28 ++++++++++++++-------------- > drivers/gpio/gpiolib-of.c | 16 ++++++++-------- > drivers/gpio/gpiolib-of.h | 7 ------- > include/linux/of_gpio.h | 11 ----------- > 4 files changed, 22 insertions(+), 40 deletions(-) > > -- > 2.17.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Bartosz, On Tue, Sep 10, 2019 at 10:51 AM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > pt., 6 wrz 2019 o 10:45 Geert Uytterhoeven <geert+renesas@glider.be> napisał(a): > > This patch series contains various API boundary cleanups for gpiolib: > > - The first two patches make two functions private, > > - The last two patches switch the remaining gpiolib exported functions > > from EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL(). > > > > After this there is only a single GPIO driver function exported with > > EXPORT_SYMBOL(); > > > > drivers/gpio/gpio-htc-egpio.c:EXPORT_SYMBOL(htc_egpio_get_wakeup_irq); > > > > I believe this symbol was never used upstream, and may be a relic of the > > original out-of-tree code the htc-egpio was based on. I don't know if > > there (still) exist out-of-tree users of the symbol. > > > > Thanks for your comments! > > All looks good to me. Are you fine with this being picked up after the > v5.4 merge window? Sure, whatever suits you best. Thanks! > > Geert Uytterhoeven (4): > > gpio: of: Make of_get_named_gpiod_flags() private > > gpio: of: Make of_gpio_simple_xlate() private > > gpio: of: Switch to EXPORT_SYMBOL_GPL() > > gpio: devres: Switch to EXPORT_SYMBOL_GPL() Gr{oetje,eeting}s, Geert
On Fri, Sep 6, 2019 at 9:45 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > This patch series contains various API boundary cleanups for gpiolib: > - The first two patches make two functions private, > - The last two patches switch the remaining gpiolib exported functions > from EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL(). Good stuff, let's merge for early v5.4 (possibly rebasing if necessary). > After this there is only a single GPIO driver function exported with > EXPORT_SYMBOL(); > > drivers/gpio/gpio-htc-egpio.c:EXPORT_SYMBOL(htc_egpio_get_wakeup_irq); Kill it. People using this platform should step up if they need it. The outoftree code was at handhelds.org and that web site is even down. There is a copy of their git tree on github somewhere but it is definately not maintained. Yours, Linus Walleij
Hi Linus, Bartosz, This patch series contains various API boundary cleanups for gpiolib: - The first two patches make two functions private, - The last two patches switch the remaining gpiolib exported functions from EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL(). After this there is only a single GPIO driver function exported with EXPORT_SYMBOL(); drivers/gpio/gpio-htc-egpio.c:EXPORT_SYMBOL(htc_egpio_get_wakeup_irq); I believe this symbol was never used upstream, and may be a relic of the original out-of-tree code the htc-egpio was based on. I don't know if there (still) exist out-of-tree users of the symbol. Thanks for your comments! Geert Uytterhoeven (4): gpio: of: Make of_get_named_gpiod_flags() private gpio: of: Make of_gpio_simple_xlate() private gpio: of: Switch to EXPORT_SYMBOL_GPL() gpio: devres: Switch to EXPORT_SYMBOL_GPL() drivers/gpio/gpiolib-devres.c | 28 ++++++++++++++-------------- drivers/gpio/gpiolib-of.c | 16 ++++++++-------- drivers/gpio/gpiolib-of.h | 7 ------- include/linux/of_gpio.h | 11 ----------- 4 files changed, 22 insertions(+), 40 deletions(-)