From patchwork Tue Aug 20 11:47:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 1150051 Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46CTYy0X4Tz9s3Z for ; Tue, 20 Aug 2019 21:47:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729736AbfHTLrt (ORCPT ); Tue, 20 Aug 2019 07:47:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729684AbfHTLrt (ORCPT ); Tue, 20 Aug 2019 07:47:49 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC45711A11 for ; Tue, 20 Aug 2019 11:47:48 +0000 (UTC) Received: by mail-ed1-f71.google.com with SMTP id i10so3979242edv.14 for ; Tue, 20 Aug 2019 04:47:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tmhQ+PPG27Zm5vMSN1m6PIsu4l0aG9ZHhqIHeZ54iD0=; b=igLWvNkUqHCNjliQbB1P+9e+qDRZ/MJL8W2+tX9+cFmw+VTIMa6c7zMpj1Gt47FG03 muxYk+qawOakQl91sdjXeTbtwPhcdVRged694aQgVktQ5yrpnhrJBgLE8FAb1rHUTub4 OPHhNNHdG6/r3+5963RerNRBZsBwzy1bUR/Gta7W4WRlmZR3B8Tv5ju5U9yujhdBvU/u y/kIWECHmh/8K8hGRZwxaX5xGfRoiQMOnZz57l/FmYaVtfj2Q1zTkCJ6cf85sSphJvBl 87hCbJS0gJbZcwykg0v48vn3D9Tgvd3KQd/FTO0URIxIdd4/R6tsIoUTpcemysCHsc0I O3nw== X-Gm-Message-State: APjAAAWHcSM4qyZE/EUz/9b6R1dygdV+QtAzLSdxvl4JygW3xyfpVNgN IBywXnHDJVSncf7+Ww2WFYwvmFo4r/ucaLZsEKadsrJaKFtuE3l5V3WV8o3QEjomu5mu9DWde3V vEgqTsO7v7ZDO X-Received: by 2002:a17:906:5789:: with SMTP id k9mr8179670ejq.56.1566301667476; Tue, 20 Aug 2019 04:47:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdm372vNavz02gj6Zcl/KfjpJUZKVgG6O9Ssv+/oI5u+vkkmTueDJ4uipbt5fiPZWK2dlezw== X-Received: by 2002:a17:906:5789:: with SMTP id k9mr8179649ejq.56.1566301667227; Tue, 20 Aug 2019 04:47:47 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id um15sm2569004ejb.27.2019.08.20.04.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Aug 2019 04:47:46 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E8D81181CE4; Tue, 20 Aug 2019 13:47:45 +0200 (CEST) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Stephen Hemminger , Daniel Borkmann , Alexei Starovoitov Cc: Martin KaFai Lau , Song Liu , Yonghong Song , David Miller , Jesper Dangaard Brouer , netdev@vger.kernel.org, bpf@vger.kernel.org, =?utf-8?q?Toke_H=C3=B8il?= =?utf-8?q?and-J=C3=B8rgensen?= Subject: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP) Date: Tue, 20 Aug 2019 13:47:01 +0200 Message-Id: <20190820114706.18546-1-toke@redhat.com> X-Mailer: git-send-email 2.22.1 MIME-Version: 1.0 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org iproute2 uses its own bpf loader to load eBPF programs, which has evolved separately from libbpf. Since we are now standardising on libbpf, this becomes a problem as iproute2 is slowly accumulating feature incompatibilities with libbpf-based loaders. In particular, iproute2 has its own (expanded) version of the map definition struct, which makes it difficult to write programs that can be loaded with both custom loaders and iproute2. This series seeks to address this by converting iproute2 to using libbpf for all its bpf needs. This version is an early proof-of-concept RFC, to get some feedback on whether people think this is the right direction. What this series does is the following: - Updates the libbpf map definition struct to match that of iproute2 (patch 1). - Adds functionality to libbpf to support automatic pinning of maps when loading an eBPF program, while re-using pinned maps if they already exist (patches 2-3). - Modifies iproute2 to make it possible to compile it against libbpf without affecting any existing functionality (patch 4). - Changes the iproute2 eBPF loader to use libbpf for loading XDP programs (patch 5). As this is an early PoC, there are still a few missing pieces before this can be merged. Including (but probably not limited to): - Consolidate the map definition struct in the bpf_helpers.h file in the kernel tree. This contains a different, and incompatible, update to the struct. Since the iproute2 version has actually been released for use outside the kernel tree (and thus is subject to API stability constraints), I think it makes the most sense to keep that, and port the selftests to use it. - The iproute2 loader supports automatically populating map-in-map definitions on load. This needs to be added to libbpf as well. There is an implementation of this in the selftests in the kernel tree, which will have to be ported (related to the previous point). - The iproute2 port needs to be completed; this means at least supporting TC eBPF programs as well, figuring out how to deal with cBPF programs, and getting the verbose output back to the same state as before the port. Also, I guess the iproute2 maintainers need to ACK that they are good with adding a dependency on libbpf. - Some of the code added to libbpf in patch 2 in this series include code derived from iproute2, which is GPLv2+. So it will need to be re-licensed to be usable in libbpf. Since `git blame` indicated that the original code was written by Daniel, I figure he can ACK that relicensing before applying the patches :) Please take a look at this series and let me know if you agree that this is the right direction to go. Assuming there's consensus that it is, I'll focus on getting the rest of the libbpf patches ready for merging. I'll send those as a separate series, and hold off on the iproute2 patches until they are merged; but for this version I'm including both in one series so it's easier to see the context. -Toke libbpf: Toke Høiland-Jørgensen (3): libbpf: Add map definition struct fields from iproute2 libbpf: Add support for auto-pinning of maps with reuse on program load libbpf: Add support for specifying map pinning path via callback tools/lib/bpf/libbpf.c | 205 +++++++++++++++++++++++++++++++++++++++-- tools/lib/bpf/libbpf.h | 18 ++++ 2 files changed, 214 insertions(+), 9 deletions(-) iproute2: Toke Høiland-Jørgensen (2): iproute2: Allow compiling against libbpf iproute2: Support loading XDP programs with libbpf configure | 16 +++++ include/bpf_util.h | 6 +- ip/ipvrf.c | 4 +- lib/bpf.c | 148 ++++++++++++++++++++++++++++++++++++--------- 4 files changed, 142 insertions(+), 32 deletions(-)