[0/3,SRU,Bionic] hns3: avoid corruption due to ring buffer race
mbox series

Message ID 20190819221111.18733-1-dann.frazier@canonical.com
Headers show
Series
  • hns3: avoid corruption due to ring buffer race
Related show

Message

dann frazier Aug. 19, 2019, 10:11 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1840717

All clean cherry picks. Patch #1 is a small cleanup that allows Patch #2
to apply cleanly. Patch #3 improves the performance of Patch #2. All 3
patches were introduced in v5.2, so they've had plenty of "bake time"
together.


Yunsheng Lin (3):
  net: hns3: minor optimization for ring_space
  net: hns3: fix data race between ring->next_to_clean
  net: hns3: optimize the barrier using when cleaning TX BD

 .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 35 ++++++++++++-------
 .../net/ethernet/hisilicon/hns3/hns3_enet.h   | 18 +++++-----
 2 files changed, 30 insertions(+), 23 deletions(-)

Comments

Stefan Bader Aug. 26, 2019, 2:39 p.m. UTC | #1
On 20.08.19 00:11, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840717
> 
> All clean cherry picks. Patch #1 is a small cleanup that allows Patch #2
> to apply cleanly. Patch #3 improves the performance of Patch #2. All 3
> patches were introduced in v5.2, so they've had plenty of "bake time"
> together.
> 
> 
> Yunsheng Lin (3):
>   net: hns3: minor optimization for ring_space
>   net: hns3: fix data race between ring->next_to_clean
>   net: hns3: optimize the barrier using when cleaning TX BD
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 35 ++++++++++++-------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   | 18 +++++-----
>  2 files changed, 30 insertions(+), 23 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Connor Kuehl Aug. 26, 2019, 11:22 p.m. UTC | #2
On 8/19/19 3:11 PM, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840717
> 
> All clean cherry picks. Patch #1 is a small cleanup that allows Patch #2
> to apply cleanly. Patch #3 improves the performance of Patch #2. All 3
> patches were introduced in v5.2, so they've had plenty of "bake time"
> together.
> 
> 
> Yunsheng Lin (3):
>    net: hns3: minor optimization for ring_space
>    net: hns3: fix data race between ring->next_to_clean
>    net: hns3: optimize the barrier using when cleaning TX BD
> 
>   .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 35 ++++++++++++-------
>   .../net/ethernet/hisilicon/hns3/hns3_enet.h   | 18 +++++-----
>   2 files changed, 30 insertions(+), 23 deletions(-)
> 

Acked-by: Connor Kuehl <connor.kuehl@canonical.com>
Kleber Souza Sept. 3, 2019, 2:24 p.m. UTC | #3
On 8/20/19 12:11 AM, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1840717
> 
> All clean cherry picks. Patch #1 is a small cleanup that allows Patch #2
> to apply cleanly. Patch #3 improves the performance of Patch #2. All 3
> patches were introduced in v5.2, so they've had plenty of "bake time"
> together.
> 
> 
> Yunsheng Lin (3):
>   net: hns3: minor optimization for ring_space
>   net: hns3: fix data race between ring->next_to_clean
>   net: hns3: optimize the barrier using when cleaning TX BD
> 
>  .../net/ethernet/hisilicon/hns3/hns3_enet.c   | 35 ++++++++++++-------
>  .../net/ethernet/hisilicon/hns3/hns3_enet.h   | 18 +++++-----
>  2 files changed, 30 insertions(+), 23 deletions(-)
> 

Applied to bionic/master-next branch.

Thanks,
Kleber