[U-Boot,0/4] Make some changes to SDP
mbox series

Message ID 1563414056-20331-1-git-send-email-sherry.sun@nxp.com
Headers show
Series
  • Make some changes to SDP
Related show

Message

Sherry Sun July 18, 2019, 1:40 a.m. UTC
From: Sherry Sun <sherry.sun@nxp.com>

This patchset adds:
1. Add usb_gadget_initialize() and usb_gadget_release() to initialize and
release UDC during sdp download.
2. Add high speed endpoint descriptor for sdp. 
3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
address while SDP_WRITE and SDP_JUMP command addr is zero.

Sherry Sun (4):
  imx: spl: Change USB boot device type
  SDP: use CONFIG_SDP_LOADADDR as default load address
  SDP: fix wrong usb request size and add high speed endpoint descriptor
  SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

 arch/arm/mach-imx/spl.c    |  2 +-
 common/spl/spl_sdp.c       |  4 ++++
 drivers/usb/gadget/Kconfig |  4 ++++
 drivers/usb/gadget/f_sdp.c | 39 +++++++++++++++++++++++++++++++++-----
 4 files changed, 43 insertions(+), 6 deletions(-)

Comments

Angus Ainslie July 28, 2019, 2:06 p.m. UTC | #1
Hi Sherry,

On 2019-07-17 18:40, sherry sun wrote:
> From: Sherry Sun <sherry.sun@nxp.com>
> 
> This patchset adds:
> 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize 
> and
> release UDC during sdp download.
> 2. Add high speed endpoint descriptor for sdp.
> 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
> address while SDP_WRITE and SDP_JUMP command addr is zero.
> 
> Sherry Sun (4):
>   imx: spl: Change USB boot device type
>   SDP: use CONFIG_SDP_LOADADDR as default load address
>   SDP: fix wrong usb request size and add high speed endpoint 
> descriptor
>   SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

These changes look like like they target SDP on imx8. For imx8mq is this 
all that is required to get SDP working with uuu or are there additional 
changes required ?

Thanks
Angus

> 
>  arch/arm/mach-imx/spl.c    |  2 +-
>  common/spl/spl_sdp.c       |  4 ++++
>  drivers/usb/gadget/Kconfig |  4 ++++
>  drivers/usb/gadget/f_sdp.c | 39 +++++++++++++++++++++++++++++++++-----
>  4 files changed, 43 insertions(+), 6 deletions(-)
Sherry Sun Aug. 1, 2019, 2:56 a.m. UTC | #2
Hi Angus

> 
> Hi Sherry,
> 
> On 2019-07-17 18:40, sherry sun wrote:
> > From: Sherry Sun <sherry.sun@nxp.com>
> >
> > This patchset adds:
> > 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize
> > and release UDC during sdp download.
> > 2. Add high speed endpoint descriptor for sdp.
> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
> > address while SDP_WRITE and SDP_JUMP command addr is zero.
> >
> > Sherry Sun (4):
> >   imx: spl: Change USB boot device type
> >   SDP: use CONFIG_SDP_LOADADDR as default load address
> >   SDP: fix wrong usb request size and add high speed endpoint
> > descriptor
> >   SDP: Call usb_gadget_initialize and usb_gadget_release to support
> > UDC
> 
> These changes look like like they target SDP on imx8. For imx8mq is this all
> that is required to get SDP working with uuu or are there additional changes
> required ?
> 

The changes in patch 1/4 are target on both imx8 and imx8m.
The rest three patches are target on all boards which used SDP.
So for imx8mq, if your usb gadget driver is ready ,these changes are enough to get SDP working with UUU. 

Best regards
Sherry sun

> Thanks
> Angus
> 
> >
> >  arch/arm/mach-imx/spl.c    |  2 +-
> >  common/spl/spl_sdp.c       |  4 ++++
> >  drivers/usb/gadget/Kconfig |  4 ++++
> >  drivers/usb/gadget/f_sdp.c | 39
> > +++++++++++++++++++++++++++++++++-----
> >  4 files changed, 43 insertions(+), 6 deletions(-)
Angus Ainslie Aug. 1, 2019, 1:07 p.m. UTC | #3
Hi Sherry,

On 2019-07-31 19:56, Sherry Sun wrote:
> Hi Angus
> 
>> 
>> Hi Sherry,
>> 
>> On 2019-07-17 18:40, sherry sun wrote:
>> > From: Sherry Sun <sherry.sun@nxp.com>
>> >
>> > This patchset adds:
>> > 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize
>> > and release UDC during sdp download.
>> > 2. Add high speed endpoint descriptor for sdp.
>> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
>> > address while SDP_WRITE and SDP_JUMP command addr is zero.
>> >
>> > Sherry Sun (4):
>> >   imx: spl: Change USB boot device type
>> >   SDP: use CONFIG_SDP_LOADADDR as default load address
>> >   SDP: fix wrong usb request size and add high speed endpoint
>> > descriptor
>> >   SDP: Call usb_gadget_initialize and usb_gadget_release to support
>> > UDC
>> 
>> These changes look like like they target SDP on imx8. For imx8mq is 
>> this all
>> that is required to get SDP working with uuu or are there additional 
>> changes
>> required ?
>> 
> 
> The changes in patch 1/4 are target on both imx8 and imx8m.
> The rest three patches are target on all boards which used SDP.
> So for imx8mq, if your usb gadget driver is ready ,these changes are
> enough to get SDP working with UUU.
> 

I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's 
enabled there. Do you have patches to enable SDP on the imx8mq-evk , 
even if they aren't ready to go upstream ?

Thanks
Angus

> Best regards
> Sherry sun
> 
>> Thanks
>> Angus
>> 
>> >
>> >  arch/arm/mach-imx/spl.c    |  2 +-
>> >  common/spl/spl_sdp.c       |  4 ++++
>> >  drivers/usb/gadget/Kconfig |  4 ++++
>> >  drivers/usb/gadget/f_sdp.c | 39
>> > +++++++++++++++++++++++++++++++++-----
>> >  4 files changed, 43 insertions(+), 6 deletions(-)
Peng Fan Aug. 2, 2019, 1:01 a.m. UTC | #4
Angus,

> Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
> 
> Hi Sherry,
> 
> On 2019-07-31 19:56, Sherry Sun wrote:
> > Hi Angus
> >
> >>
> >> Hi Sherry,
> >>
> >> On 2019-07-17 18:40, sherry sun wrote:
> >> > From: Sherry Sun <sherry.sun@nxp.com>
> >> >
> >> > This patchset adds:
> >> > 1. Add usb_gadget_initialize() and usb_gadget_release() to
> >> > initialize and release UDC during sdp download.
> >> > 2. Add high speed endpoint descriptor for sdp.
> >> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
> >> > address while SDP_WRITE and SDP_JUMP command addr is zero.
> >> >
> >> > Sherry Sun (4):
> >> >   imx: spl: Change USB boot device type
> >> >   SDP: use CONFIG_SDP_LOADADDR as default load address
> >> >   SDP: fix wrong usb request size and add high speed endpoint
> >> > descriptor
> >> >   SDP: Call usb_gadget_initialize and usb_gadget_release to support
> >> > UDC
> >>
> >> These changes look like like they target SDP on imx8. For imx8mq is
> >> this all that is required to get SDP working with uuu or are there
> >> additional changes required ?
> >>
> >
> > The changes in patch 1/4 are target on both imx8 and imx8m.
> > The rest three patches are target on all boards which used SDP.
> > So for imx8mq, if your usb gadget driver is ready ,these changes are
> > enough to get SDP working with UUU.
> >
> 
> I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's enabled
> there. Do you have patches to enable SDP on the imx8mq-evk , even if they
> aren't ready to go upstream ?

You could try downstream code,
https://source.codeaurora.org/external/imx/uboot-imx/ 
branch: imx_v2019.04_4.19.35_1.0.0

Regards,
Peng.

> 
> Thanks
> Angus
> 
> > Best regards
> > Sherry sun
> >
> >> Thanks
> >> Angus
> >>
> >> >
> >> >  arch/arm/mach-imx/spl.c    |  2 +-
> >> >  common/spl/spl_sdp.c       |  4 ++++
> >> >  drivers/usb/gadget/Kconfig |  4 ++++  drivers/usb/gadget/f_sdp.c |
> >> > 39
> >> > +++++++++++++++++++++++++++++++++-----
> >> >  4 files changed, 43 insertions(+), 6 deletions(-)
Angus Ainslie Aug. 2, 2019, 2:30 a.m. UTC | #5
Hi Peng,

On 2019-08-01 18:01, Peng Fan wrote:
> Angus,
> 
>> Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
>> 
>> Hi Sherry,
>> 
>> On 2019-07-31 19:56, Sherry Sun wrote:
>> > Hi Angus
>> >
>> >>
>> >> Hi Sherry,
>> >>
>> >> On 2019-07-17 18:40, sherry sun wrote:
>> >> > From: Sherry Sun <sherry.sun@nxp.com>
>> >> >
>> >> > This patchset adds:
>> >> > 1. Add usb_gadget_initialize() and usb_gadget_release() to
>> >> > initialize and release UDC during sdp download.
>> >> > 2. Add high speed endpoint descriptor for sdp.
>> >> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load
>> >> > address while SDP_WRITE and SDP_JUMP command addr is zero.
>> >> >
>> >> > Sherry Sun (4):
>> >> >   imx: spl: Change USB boot device type
>> >> >   SDP: use CONFIG_SDP_LOADADDR as default load address
>> >> >   SDP: fix wrong usb request size and add high speed endpoint
>> >> > descriptor
>> >> >   SDP: Call usb_gadget_initialize and usb_gadget_release to support
>> >> > UDC
>> >>
>> >> These changes look like like they target SDP on imx8. For imx8mq is
>> >> this all that is required to get SDP working with uuu or are there
>> >> additional changes required ?
>> >>
>> >
>> > The changes in patch 1/4 are target on both imx8 and imx8m.
>> > The rest three patches are target on all boards which used SDP.
>> > So for imx8mq, if your usb gadget driver is ready ,these changes are
>> > enough to get SDP working with UUU.
>> >
>> 
>> I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's 
>> enabled
>> there. Do you have patches to enable SDP on the imx8mq-evk , even if 
>> they
>> aren't ready to go upstream ?
> 
> You could try downstream code,
> https://source.codeaurora.org/external/imx/uboot-imx/
> branch: imx_v2019.04_4.19.35_1.0.0
> 

I already have SDP  working with the vendor u-boot. I'm trying to switch 
to mainline u-boot so I'm looking for mainline patches.

Thanks
Angus

> Regards,
> Peng.
> 
>> 
>> Thanks
>> Angus
>> 
>> > Best regards
>> > Sherry sun
>> >
>> >> Thanks
>> >> Angus
>> >>
>> >> >
>> >> >  arch/arm/mach-imx/spl.c    |  2 +-
>> >> >  common/spl/spl_sdp.c       |  4 ++++
>> >> >  drivers/usb/gadget/Kconfig |  4 ++++  drivers/usb/gadget/f_sdp.c |
>> >> > 39
>> >> > +++++++++++++++++++++++++++++++++-----
>> >> >  4 files changed, 43 insertions(+), 6 deletions(-)
Sherry Sun Aug. 8, 2019, 9:38 a.m. UTC | #6
Hi Angus,

Sorry for the late reply.

> -----邮件原件-----
> 发件人: Angus Ainslie <angus@akkea.ca>
> 发送时间: 2019年8月2日 10:30
> 收件人: Peng Fan <peng.fan@nxp.com>
> 抄送: Sherry Sun <sherry.sun@nxp.com>; sbabic@denx.de;
> festevam@gmail.com; lukma@denx.de; marex@denx.de;
> u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com>
> 主题: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
> 
> Hi Peng,
> 
> On 2019-08-01 18:01, Peng Fan wrote:
> > Angus,
> >
> >> Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
> >>
> >> Hi Sherry,
> >>
> >> On 2019-07-31 19:56, Sherry Sun wrote:
> >> > Hi Angus
> >> >
> >> >>
> >> >> Hi Sherry,
> >> >>
> >> >> On 2019-07-17 18:40, sherry sun wrote:
> >> >> > From: Sherry Sun <sherry.sun@nxp.com>
> >> >> >
> >> >> > This patchset adds:
> >> >> > 1. Add usb_gadget_initialize() and usb_gadget_release() to
> >> >> > initialize and release UDC during sdp download.
> >> >> > 2. Add high speed endpoint descriptor for sdp.
> >> >> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp
> >> >> > load address while SDP_WRITE and SDP_JUMP command addr is zero.
> >> >> >
> >> >> > Sherry Sun (4):
> >> >> >   imx: spl: Change USB boot device type
> >> >> >   SDP: use CONFIG_SDP_LOADADDR as default load address
> >> >> >   SDP: fix wrong usb request size and add high speed endpoint
> >> >> > descriptor
> >> >> >   SDP: Call usb_gadget_initialize and usb_gadget_release to
> >> >> > support UDC
> >> >>
> >> >> These changes look like like they target SDP on imx8. For imx8mq
> >> >> is this all that is required to get SDP working with uuu or are
> >> >> there additional changes required ?
> >> >>
> >> >
> >> > The changes in patch 1/4 are target on both imx8 and imx8m.
> >> > The rest three patches are target on all boards which used SDP.
> >> > So for imx8mq, if your usb gadget driver is ready ,these changes
> >> > are enough to get SDP working with UUU.
> >> >
> >>
> >> I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's
> >> enabled there. Do you have patches to enable SDP on the imx8mq-evk ,
> >> even if they aren't ready to go upstream ?
> >
> > You could try downstream code,
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> >
> ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2F&amp;data=02%7C01
> %7Cs
> >
> herry.sun%40nxp.com%7C6d63289fbb104168bce308d716f157c4%7C686ea1
> d3bc2b4
> >
> c6fa92cd99c5c301635%7C0%7C0%7C637003098143081621&amp;sdata=beh
> 08%2Fv3f
> > s8ZZPP29F1iVMfo3uNTWGf91SYYyak2GVU%3D&amp;reserved=0
> > branch: imx_v2019.04_4.19.35_1.0.0
> >
> 
> I already have SDP  working with the vendor u-boot. I'm trying to switch to
> mainline u-boot so I'm looking for mainline patches.
> 

May I ask, is your usb gadget driver is working? Such as you can use it for fastboot or ums.

Best regards
Sherry sun

> Thanks
> Angus
> 
> > Regards,
> > Peng.
> >
> >>
> >> Thanks
> >> Angus
> >>
> >> > Best regards
> >> > Sherry sun
> >> >
> >> >> Thanks
> >> >> Angus
> >> >>
> >> >> >
> >> >> >  arch/arm/mach-imx/spl.c    |  2 +-
> >> >> >  common/spl/spl_sdp.c       |  4 ++++
> >> >> >  drivers/usb/gadget/Kconfig |  4 ++++
> >> >> > drivers/usb/gadget/f_sdp.c |
> >> >> > 39
> >> >> > +++++++++++++++++++++++++++++++++-----
> >> >> >  4 files changed, 43 insertions(+), 6 deletions(-)
Sherry Sun Aug. 9, 2019, 6:21 a.m. UTC | #7
Hi Angus,


Hi Sherry,

On Aug. 8, 2019 2:38 a.m., Sherry Sun <sherry.sun@nxp.com<mailto:sherry.sun@nxp.com>> wrote:

Hi Angus,

Sorry for the late reply.

> -----邮件原件-----
> 发件人: Angus Ainslie <angus@akkea.ca<mailto:angus@akkea.ca>>
> 发送时间: 2019年8月2日 10:30
> 收件人: Peng Fan <peng.fan@nxp.com<mailto:peng.fan@nxp.com>>
> 抄送: Sherry Sun <sherry.sun@nxp.com<mailto:sherry.sun@nxp.com>>; sbabic@denx.de<mailto:sbabic@denx.de>;
> festevam@gmail.com<mailto:festevam@gmail.com>; lukma@denx.de<mailto:lukma@denx.de>; marex@denx.de<mailto:marex@denx.de>;
> u-boot@lists.denx.de<mailto:u-boot@lists.denx.de>; dl-uboot-imx <uboot-imx@nxp.com<mailto:uboot-imx@nxp.com>>
> 主题: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
>
> Hi Peng,
>
> On 2019-08-01 18:01, Peng Fan wrote:
> > Angus,
> >
> >> Subject: Re: 答复: [U-Boot] [PATCH 0/4] Make some changes to SDP
> >>
> >> Hi Sherry,
> >>
> >> On 2019-07-31 19:56, Sherry Sun wrote:
> >> > Hi Angus
> >> >
> >> >>
> >> >> Hi Sherry,
> >> >>
> >> >> On 2019-07-17 18:40, sherry sun wrote:
> >> >> > From: Sherry Sun <sherry.sun@nxp.com<mailto:sherry.sun@nxp.com>>
> >> >> >
> >> >> > This patchset adds:
> >> >> > 1. Add usb_gadget_initialize() and usb_gadget_release() to
> >> >> > initialize and release UDC during sdp download.
> >> >> > 2. Add high speed endpoint descriptor for sdp.
> >> >> > 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp
> >> >> > load address while SDP_WRITE and SDP_JUMP command addr is zero.
> >> >> >
> >> >> > Sherry Sun (4):
> >> >> >   imx: spl: Change USB boot device type
> >> >> >   SDP: use CONFIG_SDP_LOADADDR as default load address
> >> >> >   SDP: fix wrong usb request size and add high speed endpoint
> >> >> > descriptor
> >> >> >   SDP: Call usb_gadget_initialize and usb_gadget_release to
> >> >> > support UDC
> >> >>
> >> >> These changes look like like they target SDP on imx8. For imx8mq
> >> >> is this all that is required to get SDP working with uuu or are
> >> >> there additional changes required ?
> >> >>
> >> >
> >> > The changes in patch 1/4 are target on both imx8 and imx8m.
> >> > The rest three patches are target on all boards which used SDP.
> >> > So for imx8mq, if your usb gadget driver is ready ,these changes
> >> > are enough to get SDP working with UUU.
> >> >
> >>
> >> I'm trying to use SDP on the imx8mq-evk but it doesn't look like it's
> >> enabled there. Do you have patches to enable SDP on the imx8mq-evk ,
> >> even if they aren't ready to go upstream ?
> >
> > You could try downstream code,
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> >
> ce.codeaurora.org%2Fexternal%2Fimx%2Fuboot-imx%2F&amp;data=02%7C01
> %7Cs
> >
> herry.sun%40nxp.com%7C6d63289fbb104168bce308d716f157c4%7C686ea1
> d3bc2b4
> >
> c6fa92cd99c5c301635%7C0%7C0%7C637003098143081621&amp;sdata=beh
> 08%2Fv3f
> > s8ZZPP29F1iVMfo3uNTWGf91SYYyak2GVU%3D&amp;reserved=0
> > branch: imx_v2019.04_4.19.35_1.0.0
> >
>
> I already have SDP  working with the vendor u-boot. I'm trying to switch to
> mainline u-boot so I'm looking for mainline patches.
>

May I ask, is your usb gadget driver is working? Such as you can use it for fastboot or ums.
>If I enable dwc3 gadget and DM for the SPL then I must start removing other SPL features to get it to fit in the 124k allocation.
>
>It sounds like you haven't tested this on the imx8mq-evk then ?

Yes, I  have not used imx8mq-evk yet. I will try to test it later.

Best regards
Sherry sun

>Thanks
>Angus

Best regards
Sherry sun

> Thanks
> Angus
>
> > Regards,
> > Peng.
> >
> >>
> >> Thanks
> >> Angus
> >>
> >> > Best regards
> >> > Sherry sun
> >> >
> >> >> Thanks
> >> >> Angus
> >> >>
> >> >> >
> >> >> >  arch/arm/mach-imx/spl.c    |  2 +-
> >> >> >  common/spl/spl_sdp.c       |  4 ++++
> >> >> >  drivers/usb/gadget/Kconfig |  4 ++++
> >> >> > drivers/usb/gadget/f_sdp.c |
> >> >> > 39
> >> >> > +++++++++++++++++++++++++++++++++-----
> >> >> >  4 files changed, 43 insertions(+), 6 deletions(-)