[U-Boot,00/16] Raspberry Pi 32/64 support
mbox series

Message ID 20190716133803.1174-1-andrei@gherzan.ro
Headers show
Series
  • Raspberry Pi 32/64 support
Related show

Message

Andrei Gherzan July 16, 2019, 1:37 p.m. UTC
From: Andrei Gherzan <andrei@balena.io>

This PR consolidates the work we've done to support the new Raspberry Pi
4 board. It also includes commits from
https://github.com/mbgg/u-boot.git (credits to Matthias Brugger).

Andrei Gherzan (13):
  dts: Create a dtsi for BCM2835/6/7 specific configuration
  dts: Add initial support for bcm2838
  arm: mach-bcm283x: Define configs for RaspberryPi 4
  arm: mach-bcm283x: Define mbox address for BCM2838
  rpi: Add rpi_model entry for RaspberryPi 4
  dt-bindings: Define BCM2838_CLOCK_EMMC2 needed for RaspberryPi 4
  arm: bcm283x: Include definition for additional emmc clock
  arm: bcm283x: Define device base addresses for bcm2835
  config: rpi4: Add defconfig for rpi4-32
  dts: bcm2838-rpi-4-b: Use the emmc2 interface for sdhci
  rpi: Add memory map for bcm2838
  configs: rpi4: Remove DWC2 and USB_ETHER configs
  dts: bcm2838-rpi-4-b: Use the emmc2/2811 compatible string for SDHCI

Fabian Vogt (2):
  bcm2835 video: Bail out early if querying video information fails
  bcm283x mbox: Correctly wait for space to send

Matthias Brugger (1):
  mmc: bcm2835_sdhci: Add support for bcm2711 device

 arch/arm/dts/Makefile                      |   4 +-
 arch/arm/dts/bcm2835-common.dtsi           |  53 +++++
 arch/arm/dts/bcm2835.dtsi                  |   1 +
 arch/arm/dts/bcm2836.dtsi                  |   1 +
 arch/arm/dts/bcm2837.dtsi                  |   1 +
 arch/arm/dts/bcm2838-rpi-4-b.dts           |  52 +++++
 arch/arm/dts/bcm2838.dtsi                  | 237 +++++++++++++++++++++
 arch/arm/dts/bcm283x.dtsi                  |  45 +---
 arch/arm/mach-bcm283x/Kconfig              |  35 +++
 arch/arm/mach-bcm283x/include/mach/mbox.h  |  13 +-
 arch/arm/mach-bcm283x/include/mach/sdhci.h |   4 +
 arch/arm/mach-bcm283x/include/mach/timer.h |   4 +
 arch/arm/mach-bcm283x/include/mach/wdog.h  |   4 +
 arch/arm/mach-bcm283x/mbox.c               |   6 +-
 board/raspberrypi/rpi/rpi.c                |  32 ++-
 configs/rpi_4_32b_defconfig                |  40 ++++
 configs/rpi_4_defconfig                    |   3 -
 drivers/mmc/bcm2835_sdhci.c                |  12 +-
 drivers/video/bcm2835.c                    |   4 +-
 include/dt-bindings/clock/bcm2835.h        |   2 +
 20 files changed, 494 insertions(+), 59 deletions(-)
 create mode 100644 arch/arm/dts/bcm2835-common.dtsi
 create mode 100644 arch/arm/dts/bcm2838-rpi-4-b.dts
 create mode 100644 arch/arm/dts/bcm2838.dtsi
 create mode 100644 configs/rpi_4_32b_defconfig

Comments

Matthias Brugger July 16, 2019, 2:17 p.m. UTC | #1
On 16/07/2019 15:37, andrei@gherzan.ro wrote:
> From: Andrei Gherzan <andrei@balena.io>
> 
> This PR consolidates the work we've done to support the new Raspberry Pi

I don't understand why you posted these while you asked me if I'll submit them.
That's not a good way to collaborate on upstream.

Please use get_maintainers.pl to see whom you have to send the patches to.

> 4 board. It also includes commits from
> https://github.com/mbgg/u-boot.git (credits to Matthias Brugger).
> 
> Andrei Gherzan (13):
>   dts: Create a dtsi for BCM2835/6/7 specific configuration
>   dts: Add initial support for bcm2838
>   arm: mach-bcm283x: Define configs for RaspberryPi 4
>   arm: mach-bcm283x: Define mbox address for BCM2838
>   rpi: Add rpi_model entry for RaspberryPi 4
>   dt-bindings: Define BCM2838_CLOCK_EMMC2 needed for RaspberryPi 4
>   arm: bcm283x: Include definition for additional emmc clock
>   arm: bcm283x: Define device base addresses for bcm2835
>   config: rpi4: Add defconfig for rpi4-32
>   dts: bcm2838-rpi-4-b: Use the emmc2 interface for sdhci
>   rpi: Add memory map for bcm2838
>   configs: rpi4: Remove DWC2 and USB_ETHER configs
>   dts: bcm2838-rpi-4-b: Use the emmc2/2811 compatible string for SDHCI
> 
> Fabian Vogt (2):
>   bcm2835 video: Bail out early if querying video information fails
>   bcm283x mbox: Correctly wait for space to send

Both not needed with FW at
025759b86 ("firmware: Rename hdmi_enable_4k to hdmi_enable_4kp60")
Apart from that they have already been posted.

> 
> Matthias Brugger (1):
>   mmc: bcm2835_sdhci: Add support for bcm2711 device
> 
>  arch/arm/dts/Makefile                      |   4 +-
>  arch/arm/dts/bcm2835-common.dtsi           |  53 +++++
>  arch/arm/dts/bcm2835.dtsi                  |   1 +
>  arch/arm/dts/bcm2836.dtsi                  |   1 +
>  arch/arm/dts/bcm2837.dtsi                  |   1 +
>  arch/arm/dts/bcm2838-rpi-4-b.dts           |  52 +++++
>  arch/arm/dts/bcm2838.dtsi                  | 237 +++++++++++++++++++++
>  arch/arm/dts/bcm283x.dtsi                  |  45 +---
>  arch/arm/mach-bcm283x/Kconfig              |  35 +++
>  arch/arm/mach-bcm283x/include/mach/mbox.h  |  13 +-
>  arch/arm/mach-bcm283x/include/mach/sdhci.h |   4 +
>  arch/arm/mach-bcm283x/include/mach/timer.h |   4 +
>  arch/arm/mach-bcm283x/include/mach/wdog.h  |   4 +
>  arch/arm/mach-bcm283x/mbox.c               |   6 +-
>  board/raspberrypi/rpi/rpi.c                |  32 ++-
>  configs/rpi_4_32b_defconfig                |  40 ++++
>  configs/rpi_4_defconfig                    |   3 -
>  drivers/mmc/bcm2835_sdhci.c                |  12 +-
>  drivers/video/bcm2835.c                    |   4 +-
>  include/dt-bindings/clock/bcm2835.h        |   2 +
>  20 files changed, 494 insertions(+), 59 deletions(-)
>  create mode 100644 arch/arm/dts/bcm2835-common.dtsi
>  create mode 100644 arch/arm/dts/bcm2838-rpi-4-b.dts
>  create mode 100644 arch/arm/dts/bcm2838.dtsi
>  create mode 100644 configs/rpi_4_32b_defconfig
>
Andrei Gherzan July 16, 2019, 7 p.m. UTC | #2
Hi,

On 16 July 2019 15:17:46 BST, Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>On 16/07/2019 15:37, andrei@gherzan.ro wrote:
>> From: Andrei Gherzan <andrei@balena.io>
>> 
>> This PR consolidates the work we've done to support the new Raspberry
>Pi
>
>I don't understand why you posted these while you asked me if I'll
>submit them.
>That's not a good way to collaborate on upstream.

As I have mentioned privately, I've done that due to the fact that I haven't gotten any feedback from you. Nevertheless, I will sync up with you for the next iteration for this PR which will include the changes requested. 

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan