| Message ID | 20190711094317.3336-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Intel ethernet I219 may wrongly detect connection speed as 10Mbps | expand |
On 11.7.2019 12.43, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1836177 > > [Impact] > Intel I219 ethernet may wrongly detect 1Gbps network as 10Mbps after > ethernet cable hotplugging. > > [Fix] > Use delayed work before deciding the network speed. > This essentially workarounds unreliable reading on MII_BMSR register. > > [Test] > Before the patch the network operates at 10Mbps after cable gets > plugged. > With the fix, network always operates in 1Gbps. > > [Regression Potential] > Low. It changes the watchdog task from timer to delayed work, the logic > is essentially the same. > > Detlev Casanova (1): > e1000e: Make watchdog use delayed work > > drivers/net/ethernet/intel/e1000e/e1000.h | 5 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 54 ++++++++++++---------- > 2 files changed, 32 insertions(+), 27 deletions(-) > applied to osp1 oem-next, thanks
On Thu, Jul 11, 2019 at 05:43:15PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1836177 > > [Impact] > Intel I219 ethernet may wrongly detect 1Gbps network as 10Mbps after > ethernet cable hotplugging. > > [Fix] > Use delayed work before deciding the network speed. > This essentially workarounds unreliable reading on MII_BMSR register. > > [Test] > Before the patch the network operates at 10Mbps after cable gets > plugged. > With the fix, network always operates in 1Gbps. > > [Regression Potential] > Low. It changes the watchdog task from timer to delayed work, the logic > is essentially the same. Positive testing, making its way upstream. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to eoan/master-next, thanks!
On 11.07.19 11:43, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1836177 > > [Impact] > Intel I219 ethernet may wrongly detect 1Gbps network as 10Mbps after > ethernet cable hotplugging. > > [Fix] > Use delayed work before deciding the network speed. > This essentially workarounds unreliable reading on MII_BMSR register. > > [Test] > Before the patch the network operates at 10Mbps after cable gets > plugged. > With the fix, network always operates in 1Gbps. > > [Regression Potential] > Low. It changes the watchdog task from timer to delayed work, the logic > is essentially the same. > > Detlev Casanova (1): > e1000e: Make watchdog use delayed work > > drivers/net/ethernet/intel/e1000e/e1000.h | 5 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 54 ++++++++++++---------- > 2 files changed, 32 insertions(+), 27 deletions(-) > As this comes from a source which is not Linus tree, I would prefix this with "UBUNTU: SAUCE:". Acked-by: Stefan Bader <stefan.bader@canonical.com>
Prefixed "UBUNTU: SAUCE: " to the commit title. On 2019-07-11 17:43:15 , Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1836177 > > [Impact] > Intel I219 ethernet may wrongly detect 1Gbps network as 10Mbps after > ethernet cable hotplugging. > > [Fix] > Use delayed work before deciding the network speed. > This essentially workarounds unreliable reading on MII_BMSR register. > > [Test] > Before the patch the network operates at 10Mbps after cable gets > plugged. > With the fix, network always operates in 1Gbps. > > [Regression Potential] > Low. It changes the watchdog task from timer to delayed work, the logic > is essentially the same. > > Detlev Casanova (1): > e1000e: Make watchdog use delayed work > > drivers/net/ethernet/intel/e1000e/e1000.h | 5 +- > drivers/net/ethernet/intel/e1000e/netdev.c | 54 ++++++++++++---------- > 2 files changed, 32 insertions(+), 27 deletions(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team