| Message ID | 20190619165001.28410-1-ikegami.t@gmail.com |
|---|---|
| Headers | show |
| Series | mtd: cfi_cmdset_0002: Fix flash write issue for OpenWrt Project | expand |
On Thu, 2019-06-20 at 01:49 +0900, Tokunori Ikegami wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > The change is based on the fix for flash erase to use chip_good() done in > the past. And it is fixed as same way in the OpenWrt Project as below. > <https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openwrt.org%2F%3Fp%3Dopenwrt%2Fopenwrt.git%3Ba%3Dcommitdiff%3Bh%3Dddc11c3932&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7Cc576b3ddad2d4f3c09f008d6f4d635b2%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C636965598194534713&sdata=1XV5w3jD6tbfP%2B2Q2eBqfeHp07kHLDxpiJhW4ZA5Ea8%3D&reserved=0> > Also includes some refactoring changes. > Did this go anywhere? Jocke > Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> > Cc: Fabio Bettoni <fbettoni@gmail.com> > Co: Hauke Mehrtens <hauke@hauke-m.de> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> > Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> > Cc: linux-mtd@lists.infradead.org > > Tokunori Ikegami (9): > mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() > mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer() > mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size > mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement > mtd: cfi_cmdset_0002: Remove op_done goto statement from > do_write_oneword() > mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence > mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed > mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths > mtd: cfi_cmdset_0002: Disable write buffer functions if > FORCE_WORD_WRITE is 1 > > drivers/mtd/chips/cfi_cmdset_0002.c | 290 ++++++++++++++++++++++-------------- > 1 file changed, 182 insertions(+), 108 deletions(-) > > -- > 2.11.0 >
On 2019/08/21 17:03, Joakim Tjernlund wrote: > On Thu, 2019-06-20 at 01:49 +0900, Tokunori Ikegami wrote: >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. >> >> >> The change is based on the fix for flash erase to use chip_good() done in >> the past. And it is fixed as same way in the OpenWrt Project as below. >> <https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openwrt.org%2F%3Fp%3Dopenwrt%2Fopenwrt.git%3Ba%3Dcommitdiff%3Bh%3Dddc11c3932&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7Cc576b3ddad2d4f3c09f008d6f4d635b2%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C636965598194534713&sdata=1XV5w3jD6tbfP%2B2Q2eBqfeHp07kHLDxpiJhW4ZA5Ea8%3D&reserved=0> >> Also includes some refactoring changes. >> > Did this go anywhere? Sorry I missed to reply by the previous mail so let me reply again. The patch series are still waiting to be reviewed and applied into the linux mtd repository so did not go anywhere. Regards, Ikegami > > Jocke > >> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> >> Cc: Fabio Bettoni <fbettoni@gmail.com> >> Co: Hauke Mehrtens <hauke@hauke-m.de> >> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> >> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> >> Cc: linux-mtd@lists.infradead.org >> >> Tokunori Ikegami (9): >> mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() >> mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer() >> mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size >> mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement >> mtd: cfi_cmdset_0002: Remove op_done goto statement from >> do_write_oneword() >> mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence >> mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed >> mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths >> mtd: cfi_cmdset_0002: Disable write buffer functions if >> FORCE_WORD_WRITE is 1 >> >> drivers/mtd/chips/cfi_cmdset_0002.c | 290 ++++++++++++++++++++++-------------- >> 1 file changed, 182 insertions(+), 108 deletions(-) >> >> -- >> 2.11.0 >> > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
On 21/08/19 1:33 PM, Joakim Tjernlund wrote: > On Thu, 2019-06-20 at 01:49 +0900, Tokunori Ikegami wrote: >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. >> >> >> The change is based on the fix for flash erase to use chip_good() done in >> the past. And it is fixed as same way in the OpenWrt Project as below. >> <https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openwrt.org%2F%3Fp%3Dopenwrt%2Fopenwrt.git%3Ba%3Dcommitdiff%3Bh%3Dddc11c3932&data=02%7C01%7CJoakim.Tjernlund%40infinera.com%7Cc576b3ddad2d4f3c09f008d6f4d635b2%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C636965598194534713&sdata=1XV5w3jD6tbfP%2B2Q2eBqfeHp07kHLDxpiJhW4ZA5Ea8%3D&reserved=0> >> Also includes some refactoring changes. >> > > Did this go anywhere? > I have this series in my queue and will consider for 5.4-rc1. Regards Vignesh > Jocke > >> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> >> Cc: Fabio Bettoni <fbettoni@gmail.com> >> Co: Hauke Mehrtens <hauke@hauke-m.de> >> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> >> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> >> Cc: linux-mtd@lists.infradead.org >> >> Tokunori Ikegami (9): >> mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() >> mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer() >> mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size >> mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement >> mtd: cfi_cmdset_0002: Remove op_done goto statement from >> do_write_oneword() >> mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence >> mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed >> mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths >> mtd: cfi_cmdset_0002: Disable write buffer functions if >> FORCE_WORD_WRITE is 1 >> >> drivers/mtd/chips/cfi_cmdset_0002.c | 290 ++++++++++++++++++++++-------------- >> 1 file changed, 182 insertions(+), 108 deletions(-) >> >> -- >> 2.11.0 >> >
The change is based on the fix for flash erase to use chip_good() done in the past. And it is fixed as same way in the OpenWrt Project as below. <https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=ddc11c3932> Also includes some refactoring changes. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com> Cc: Fabio Bettoni <fbettoni@gmail.com> Co: Hauke Mehrtens <hauke@hauke-m.de> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> Cc: linux-mtd@lists.infradead.org Tokunori Ikegami (9): mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() mtd: cfi_cmdset_0002: Remove goto statement from do_write_buffer() mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce function size mtd: cfi_cmdset_0002: Split do_write_oneword() op_done goto statement mtd: cfi_cmdset_0002: Remove op_done goto statement from do_write_oneword() mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence mtd: cfi_cmdset_0002: Split to wait write buffer to check if completed mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths mtd: cfi_cmdset_0002: Disable write buffer functions if FORCE_WORD_WRITE is 1 drivers/mtd/chips/cfi_cmdset_0002.c | 290 ++++++++++++++++++++++-------------- 1 file changed, 182 insertions(+), 108 deletions(-)