mbox series

[SRU,B/OEM-B/C/D,0/2] There are 4 HDMI/Displayport audio output listed in sound setting without attach any HDMI/DP monitor

Message ID 20190507025736.7290-1-hui.wang@canonical.com
Headers show
Series There are 4 HDMI/Displayport audio output listed in sound setting without attach any HDMI/DP monitor | expand

Message

Hui Wang May 7, 2019, 2:57 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1827967

[Impact]
In our OEM projects, we often meet this issues, there is no any monitor plugged,
but in the gnome-sound-setting, there are 4 hdmi/dp audio devices.


[Fix]
We check the eld_valid when reporting the hdmi/dp jack event

[Test Case]
On the problematic machines, we do s3 test without plugging monitor, there
is no hdmi audio device in the sound-setting.
On the machines without this problem, we do s3 test, pluggin/unplugging
monitor test, the hdmi audio work well as before.

[Regression Risk]
Low. We have done many tests on machines with or without this problem,
there is no regression so far.



Hui Wang (2):
  ALSA: hda/hdmi - Read the pin sense from register when repolling
  ALSA: hda/hdmi - Consider eld_valid when reporting jack event

 sound/pci/hda/patch_hdmi.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Kleber Sacilotto de Souza May 7, 2019, 12:34 p.m. UTC | #1
On 5/7/19 4:57 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827967
> 
> [Impact]
> In our OEM projects, we often meet this issues, there is no any monitor plugged,
> but in the gnome-sound-setting, there are 4 hdmi/dp audio devices.
> 
> 
> [Fix]
> We check the eld_valid when reporting the hdmi/dp jack event
> 
> [Test Case]
> On the problematic machines, we do s3 test without plugging monitor, there
> is no hdmi audio device in the sound-setting.
> On the machines without this problem, we do s3 test, pluggin/unplugging
> monitor test, the hdmi audio work well as before.
> 
> [Regression Risk]
> Low. We have done many tests on machines with or without this problem,
> there is no regression so far.
> 
> 
> 
> Hui Wang (2):
>   ALSA: hda/hdmi - Read the pin sense from register when repolling
>   ALSA: hda/hdmi - Consider eld_valid when reporting jack event
> 
>  sound/pci/hda/patch_hdmi.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Seth Forshee May 8, 2019, 2:18 p.m. UTC | #2
On Tue, May 07, 2019 at 10:57:34AM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827967
> 
> [Impact]
> In our OEM projects, we often meet this issues, there is no any monitor plugged,
> but in the gnome-sound-setting, there are 4 hdmi/dp audio devices.
> 
> 
> [Fix]
> We check the eld_valid when reporting the hdmi/dp jack event
> 
> [Test Case]
> On the problematic machines, we do s3 test without plugging monitor, there
> is no hdmi audio device in the sound-setting.
> On the machines without this problem, we do s3 test, pluggin/unplugging
> monitor test, the hdmi audio work well as before.
> 
> [Regression Risk]
> Low. We have done many tests on machines with or without this problem,
> there is no regression so far.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to unstable/master, thanks!
Kleber Sacilotto de Souza May 8, 2019, 5:10 p.m. UTC | #3
On 5/7/19 4:57 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1827967
> 
> [Impact]
> In our OEM projects, we often meet this issues, there is no any monitor plugged,
> but in the gnome-sound-setting, there are 4 hdmi/dp audio devices.
> 
> 
> [Fix]
> We check the eld_valid when reporting the hdmi/dp jack event
> 
> [Test Case]
> On the problematic machines, we do s3 test without plugging monitor, there
> is no hdmi audio device in the sound-setting.
> On the machines without this problem, we do s3 test, pluggin/unplugging
> monitor test, the hdmi audio work well as before.
> 
> [Regression Risk]
> Low. We have done many tests on machines with or without this problem,
> there is no regression so far.
> 
> 
> 
> Hui Wang (2):
>   ALSA: hda/hdmi - Read the pin sense from register when repolling
>   ALSA: hda/hdmi - Consider eld_valid when reporting jack event
> 
>  sound/pci/hda/patch_hdmi.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Applied to bionic, cosmic and disco/master-next branches.

Thanks,
Kleber