mbox series

[U-Boot,0/4] Tidy up some dangling OP-TEE gotchas

Message ID 20190424004350.31028-1-bryan.odonoghue@linaro.org
Headers show
Series Tidy up some dangling OP-TEE gotchas | expand

Message

Bryan O'Donoghue April 24, 2019, 12:43 a.m. UTC
Rober P Day rightly pointed out that some odd OP-TEE specific defines were
appearing in his defconfig, despite not having CONFIG_OPTEE=y set in his
defconfig.

Looking into this with a small bit of restructure we can fix this corner
case.

- Make sure OP-TEE CONFIG options only appear when you are compiling for
  OPTEE
- Fix WaRP7 BL33 so that the low-level init skipping routines can tolerate
  the afore mentioned change.
- Update MAINTAINERS with my own details so that questions pertaining to
  lib/optee comes my way.

Bryan O'Donoghue (4):
  optee: Make TZDRAM config options contingent on CONFIG_OPTEE
  warp7: include: configs: Skip low-level init if BOOTM_OPTEE false
  warp7: configs: bl33: Tidy up OPTEE defines
  MAINTAINERS: Update lib/optee with my details

 MAINTAINERS                  | 5 +++++
 configs/warp7_bl33_defconfig | 4 +++-
 include/configs/warp7.h      | 4 +---
 lib/optee/Kconfig            | 2 ++
 4 files changed, 11 insertions(+), 4 deletions(-)

Comments

Bryan O'Donoghue April 30, 2019, 1:30 a.m. UTC | #1
On 24/04/2019 01:43, Bryan O'Donoghue wrote:
> Rober P Day rightly pointed out that some odd OP-TEE specific defines were
> appearing in his defconfig, despite not having CONFIG_OPTEE=y set in his
> defconfig.

Ping,

Robert, Rui, Fabio - do you guys want changes here ?

---
bod
Rui Miguel Silva April 30, 2019, 11:20 a.m. UTC | #2
Hi Bryan,
On Tue 30 Apr 2019 at 02:30, Bryan O'Donoghue wrote:
> On 24/04/2019 01:43, Bryan O'Donoghue wrote:
>> Rober P Day rightly pointed out that some odd OP-TEE specific defines were
>> appearing in his defconfig, despite not having CONFIG_OPTEE=y set in his
>> defconfig.
>
> Ping,
>
> Robert, Rui, Fabio - do you guys want changes here ?

Regarding OPTEE, patches 1/4 and 2/4:
Acked-by: Rui Miguel Silva <rui.silva@linaro.org>

---
Cheers,
	Rui
Fabio Estevam April 30, 2019, 12:59 p.m. UTC | #3
On Mon, Apr 29, 2019 at 10:31 PM Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
>
>
> On 24/04/2019 01:43, Bryan O'Donoghue wrote:
> > Rober P Day rightly pointed out that some odd OP-TEE specific defines were
> > appearing in his defconfig, despite not having CONFIG_OPTEE=y set in his
> > defconfig.
>
> Ping,
>
> Robert, Rui, Fabio - do you guys want changes here ?

Looks good to me.