[SRU,B/OEM-B/C/D,0/3] repeating crackling noise happens after 19.04 upgrade
mbox series

Message ID 20190418035548.7830-1-hui.wang@canonical.com
Headers show
Series
  • repeating crackling noise happens after 19.04 upgrade
Related show

Message

Hui Wang April 18, 2019, 3:55 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1821663

This is because the kernel config CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to
1 in the recent disco kernel.

I also backported the patch to cosmic and bionic since this patch is harmless to
cosmic and bionic.

For Disco kernel, we only need 1 patch. Because of patch conflicting, cosmic
kernel needs 2 patches and bionic kernel needs 3 patches.

[Impact]
After CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to 1, the codec runtime PM is
enabled, on some codecs or for some hw design, there is noise with the codec
runtime PM enabled.


[Fix]
put the machine in the power_save_black_list, this will set the power_save=0

[Test Case]
just boot up and do some audio operations, there is no noise anymore

[Regression Risk]
Low. this patch ony applies to the specific machines.



Hans de Goede (1):
  ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist

Hui Wang (1):
  ALSA: hda - Add two more machines to the power_save_blacklist

Jaroslav Kysela (1):
  ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist

 sound/pci/hda/hda_intel.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Comments

You-Sheng Yang April 18, 2019, 5:25 a.m. UTC | #1
Acked-By: You-Sheng Yang <vicamo.yang@canonical.com>
Stefan Bader April 18, 2019, 9:41 a.m. UTC | #2
On 18.04.19 05:55, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1821663
> 
> This is because the kernel config CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to
> 1 in the recent disco kernel.
> 
> I also backported the patch to cosmic and bionic since this patch is harmless to
> cosmic and bionic.
> 
> For Disco kernel, we only need 1 patch. Because of patch conflicting, cosmic
> kernel needs 2 patches and bionic kernel needs 3 patches.
> 
> [Impact]
> After CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to 1, the codec runtime PM is
> enabled, on some codecs or for some hw design, there is noise with the codec
> runtime PM enabled.
> 
> 
> [Fix]
> put the machine in the power_save_black_list, this will set the power_save=0
> 
> [Test Case]
> just boot up and do some audio operations, there is no noise anymore
> 
> [Regression Risk]
> Low. this patch ony applies to the specific machines.
> 
> 
> 
> Hans de Goede (1):
>   ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist
> 
> Hui Wang (1):
>   ALSA: hda - Add two more machines to the power_save_blacklist
> 
> Jaroslav Kysela (1):
>   ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist
> 
>  sound/pci/hda/hda_intel.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khaled Elmously April 23, 2019, 4:11 a.m. UTC | #3
Applied to bionic/master-next, cosmic/master-next and oem/oem-next. Also updated the bug to nominate it for bionic/oem.

Though I'm not really sure if these patches _should_ have been applied to oem or not, since the bug wasn't nominated for linux-oem and bionic/oem will get the patches anyway when it gets rebased on bionic.






On 2019-04-18 11:55:42 , Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1821663
> 
> This is because the kernel config CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to
> 1 in the recent disco kernel.
> 
> I also backported the patch to cosmic and bionic since this patch is harmless to
> cosmic and bionic.
> 
> For Disco kernel, we only need 1 patch. Because of patch conflicting, cosmic
> kernel needs 2 patches and bionic kernel needs 3 patches.
> 
> [Impact]
> After CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to 1, the codec runtime PM is
> enabled, on some codecs or for some hw design, there is noise with the codec
> runtime PM enabled.
> 
> 
> [Fix]
> put the machine in the power_save_black_list, this will set the power_save=0
> 
> [Test Case]
> just boot up and do some audio operations, there is no noise anymore
> 
> [Regression Risk]
> Low. this patch ony applies to the specific machines.
> 
> 
> 
> Hans de Goede (1):
>   ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist
> 
> Hui Wang (1):
>   ALSA: hda - Add two more machines to the power_save_blacklist
> 
> Jaroslav Kysela (1):
>   ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist
> 
>  sound/pci/hda/hda_intel.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Sacilotto de Souza April 23, 2019, 3:28 p.m. UTC | #4
On 4/18/19 5:55 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1821663
> 
> This is because the kernel config CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to
> 1 in the recent disco kernel.
> 
> I also backported the patch to cosmic and bionic since this patch is harmless to
> cosmic and bionic.
> 
> For Disco kernel, we only need 1 patch. Because of patch conflicting, cosmic
> kernel needs 2 patches and bionic kernel needs 3 patches.
> 
> [Impact]
> After CONFIG_SND_HDA_POWER_SAVE_DEFAULT is changed to 1, the codec runtime PM is
> enabled, on some codecs or for some hw design, there is noise with the codec
> runtime PM enabled.
> 
> 
> [Fix]
> put the machine in the power_save_black_list, this will set the power_save=0
> 
> [Test Case]
> just boot up and do some audio operations, there is no noise anymore
> 
> [Regression Risk]
> Low. this patch ony applies to the specific machines.
> 
> 
> 
> Hans de Goede (1):
>   ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist
> 
> Hui Wang (1):
>   ALSA: hda - Add two more machines to the power_save_blacklist
> 
> Jaroslav Kysela (1):
>   ALSA: hda - add Lenovo IdeaCentre B550 to the power_save_blacklist
> 
>  sound/pci/hda/hda_intel.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 

Applied to disco/master-next branch.

Thanks,
Kleber