Message ID | 20190417025944.16154-1-ehabkost@redhat.com |
---|---|
Headers | show |
Series | Remove qdev_get_machine() call from ppc_cpu_parse_featurestr() | expand |
Eduardo Habkost <ehabkost@redhat.com> writes: > My initial goal was simple: removing the qdev_get_machine() call > from ppc_cpu_parse_featurestr() because I want to make > qdev_get_machine() available only to softmmu code. > > Before doing this, I had to make *-user not call > CPUClass::parse_features() anymore (it was pointless to call it, > anyway). > > While doing this, I decided to rename parse_cpu_model() to > something clearer (parse_cpu_option()). > > As a nice side effect, now the dependency between machine object > creation and parse_cpu_option() is not hidden anymore. Series Reviewed-by: Markus Armbruster <armbru@redhat.com>
On Wed, Apr 17, 2019 at 07:45:24AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabkost@redhat.com> writes: > > > My initial goal was simple: removing the qdev_get_machine() call > > from ppc_cpu_parse_featurestr() because I want to make > > qdev_get_machine() available only to softmmu code. > > > > Before doing this, I had to make *-user not call > > CPUClass::parse_features() anymore (it was pointless to call it, > > anyway). > > > > While doing this, I decided to rename parse_cpu_model() to > > something clearer (parse_cpu_option()). > > > > As a nice side effect, now the dependency between machine object > > creation and parse_cpu_option() is not hidden anymore. > > Series > Reviewed-by: Markus Armbruster <armbru@redhat.com> Thanks. I'm queueing this even though I agree with the comments at patch 2/5, because I'm already planning to send a separate cleanup series for cpu_class_by_name() and other related code.