[0/6] net: stmmac: fix handling of oversized frames
mbox series

Message ID 20190327203540.1884-1-aaro.koskinen@iki.fi
Headers show
Series
  • net: stmmac: fix handling of oversized frames
Related show

Message

Aaro Koskinen March 27, 2019, 8:35 p.m. UTC
From: Aaro Koskinen <aaro.koskinen@nokia.com>

Hi,

I accidentally had MTU size mismatch (9000 vs. 1500) in my network,
and I noticed I could kill a system using stmmac & 1500 MTU simply
by pinging it with "ping -s 2000 ...".

While testing a fix I encountered also some other issues that need fixing.

I have tested these only with enhanced descriptors, so the normal
descriptor changes need a careful review.

A.

Aaro Koskinen (6):
  net: stmmac: use correct DMA buffer size in the RX descriptor
  net: stmmac: ratelimit RX error logs
  net: stmmac: don't stop NAPI processing when dropping a packet
  net: stmmac: don't overwrite discard_frame status
  net: stmmac: fix dropping of multi-descriptor RX frames
  net: stmmac: don't log oversized frames

 .../net/ethernet/stmicro/stmmac/descs_com.h   | 22 +++++++-----
 .../ethernet/stmicro/stmmac/dwmac4_descs.c    |  2 +-
 .../ethernet/stmicro/stmmac/dwxgmac2_descs.c  |  2 +-
 .../net/ethernet/stmicro/stmmac/enh_desc.c    | 22 ++++++++----
 drivers/net/ethernet/stmicro/stmmac/hwif.h    |  2 +-
 .../net/ethernet/stmicro/stmmac/norm_desc.c   | 12 ++++---
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 34 +++++++++++--------
 7 files changed, 59 insertions(+), 37 deletions(-)

Comments

David Miller March 29, 2019, 12:10 a.m. UTC | #1
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: Wed, 27 Mar 2019 22:35:34 +0200

> I accidentally had MTU size mismatch (9000 vs. 1500) in my network,
> and I noticed I could kill a system using stmmac & 1500 MTU simply
> by pinging it with "ping -s 2000 ...".
> 
> While testing a fix I encountered also some other issues that need fixing.
> 
> I have tested these only with enhanced descriptors, so the normal
> descriptor changes need a careful review.

I really want to see some stmmac developers review and/or test these
changes.

Thanks.
David Miller March 31, 2019, 9:01 p.m. UTC | #2
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: Wed, 27 Mar 2019 22:35:34 +0200

> I accidentally had MTU size mismatch (9000 vs. 1500) in my network,
> and I noticed I could kill a system using stmmac & 1500 MTU simply
> by pinging it with "ping -s 2000 ...".
> 
> While testing a fix I encountered also some other issues that need fixing.
> 
> I have tested these only with enhanced descriptors, so the normal
> descriptor changes need a careful review.

Series applied, thanks Aaro.