| Message ID | 20190327023339.25975-1-megous@megous.com |
|---|---|
| Headers | show |
| Series | Add support for lradc on A83T | expand |
On Wed, Mar 27, 2019 at 03:33:36AM +0100, megous@megous.com wrote: > From: Ziping Chen <techping.chan@gmail.com> > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC, > however, the A10 SoC's vref of lradc internally is divided by 2/3 and > the A83T SoC's vref of lradc internally is divided by 3/4, thus add > a hardware variant for it to be compatible with various devices. > > Signed-off-by: Ziping Chen <techping.chan@gmail.com> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Applied, this and binding patch; the dts changes should go through other relevant trees I believe. Thanks.
Hello, On Thu, Apr 04, 2019 at 11:49:15AM -0700, Dmitry Torokhov wrote: > On Wed, Mar 27, 2019 at 03:33:36AM +0100, megous@megous.com wrote: > > From: Ziping Chen <techping.chan@gmail.com> > > > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC, > > however, the A10 SoC's vref of lradc internally is divided by 2/3 and > > the A83T SoC's vref of lradc internally is divided by 3/4, thus add > > a hardware variant for it to be compatible with various devices. > > > > Signed-off-by: Ziping Chen <techping.chan@gmail.com> > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Applied, this and binding patch; the dts changes should go through other > relevant trees I believe. Thank you very much. Yes, the rest should go through the sunxi tree. regards, Ondrej > Thanks. > > -- > Dmitry > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
On Wed, Mar 27, 2019 at 03:33:38AM +0100, megous@megous.com wrote: > From: Ziping Chen <techping.chan@gmail.com> > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC. > Now the driver has been modified to support it. > > Add support for it. > > Signed-off-by: Ziping Chen <techping.chan@gmail.com> It's missing your SoB. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Hello Maxime, On Mon, Apr 08, 2019 at 10:00:56AM +0200, Maxime Ripard wrote: > On Wed, Mar 27, 2019 at 03:33:38AM +0100, megous@megous.com wrote: > > From: Ziping Chen <techping.chan@gmail.com> > > > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC. > > Now the driver has been modified to support it. > > > > Add support for it. > > > > Signed-off-by: Ziping Chen <techping.chan@gmail.com> > > It's missing your SoB. Signed-off-by: Ondrej Jirman <megous@megous.com> Please add it when aplying he patch. regards, Ondrej > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Apr 08, 2019 at 02:09:01PM +0200, Ondřej Jirman wrote: > Hello Maxime, > > On Mon, Apr 08, 2019 at 10:00:56AM +0200, Maxime Ripard wrote: > > On Wed, Mar 27, 2019 at 03:33:38AM +0100, megous@megous.com wrote: > > > From: Ziping Chen <techping.chan@gmail.com> > > > > > > Allwinner A83T SoC has a low res adc like the one in Allwinner A10 SoC. > > > Now the driver has been modified to support it. > > > > > > Add support for it. > > > > > > Signed-off-by: Ziping Chen <techping.chan@gmail.com> > > > > It's missing your SoB. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > Please add it when aplying he patch. Done, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
From: Ondrej Jirman <megous@megous.com> (This is a re-send, with input subsystem maintainer added. Sorry, for the extra noise, I did only send the v4 to the previous recipients of v3, and didn't notice input subsystem was missing back then too. Thank you wens for pointing it out.) This series implements r_lradc (low res ADC) support for A83T. This is a continuation of v3 patch series from 2017 by Ziping Chen. I've rebased it on top of linux-next and changed the compatibe string as requested back then.[1] There was some talk of iio based lradc driver back then[2], but noone stepped forward to make it. Let's finish this series, so that it's at least possible to add support for tablet keys on various A83T tablets as that's the main use of lradc module. [1] https://lkml.org/lkml/2017/6/26/558 [2] https://lkml.org/lkml/2017/6/27/877 Please take a look, and apply the patches if you have no objections. regards, Ondrej Jirman Changes for v4: - changed comaptible string to allwinner,sun8i-a83t-r-lradc (drop -keys suffix) - dropped 0 prefix in the r_lradc DT node - added sample A83T lradc user (TBS A711 tablet) Changes for v3: - Fix some issuses raised by Maxime. - Added Rob's ACK. Changes for v2: - Add an A83T specific compatible. Ondrej Jirman (1): ARM: dts: sun8i: tbs-a711: Add support for volume keys input Ziping Chen (3): input: sun4i-a10-lradc-keys: Add support for A83T dt-bindings: input: Add R_LRADC support for A83T ARM: dts: sunxi: Add R_LRADC support for A83T .../bindings/input/sun4i-lradc-keys.txt | 6 ++- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 20 ++++++++++ arch/arm/boot/dts/sun8i-a83t.dtsi | 7 ++++ drivers/input/keyboard/sun4i-lradc-keys.c | 38 +++++++++++++++++-- 4 files changed, 65 insertions(+), 6 deletions(-)