| Message ID | 20190320014718.8974-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | codecs stop working after S3 | expand |
On Wed, Mar 20, 2019 at 09:47:15AM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1820930 > > To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced > a new patch which affect this issue, so the DISCO needs 2 patches. > > [Impact] > After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop > working, they can't detect jack plugging/unplugging or the audio device > can't show up in the gnome-sound-setting > > [Fix] > After S3, if it runs runtime_resume(), the codec works again. We change > the driver to let system_resume() trigger runtime_resume() > > [Test Case] > This issue is reported from OEM project, some codecs can't detect > jack pluggin/unplugging, some codecs can't show up in the UI, after > applying this patch, all related bugs are fixed. > > [Regression Potential] > Low. have tested on many machines (with this issue or without this issue), > all worked well. Accepted by the upstream mainainer, good test results. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to disco/master-next, thanks!
Backport looks good from maintainer's tree with positive test result.
Acked-by: Aaron Ma <aaron.ma@canonical.com>
On 2019-03-20 09:47:15 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1820930 > > To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced > a new patch which affect this issue, so the DISCO needs 2 patches. > > [Impact] > After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop > working, they can't detect jack plugging/unplugging or the audio device > can't show up in the gnome-sound-setting > > [Fix] > After S3, if it runs runtime_resume(), the codec works again. We change > the driver to let system_resume() trigger runtime_resume() > > [Test Case] > This issue is reported from OEM project, some codecs can't detect > jack pluggin/unplugging, some codecs can't show up in the UI, after > applying this patch, all related bugs are fixed. > > [Regression Potential] > Low. have tested on many machines (with this issue or without this issue), > all worked well. > > > > Hui Wang (2): > ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec > ALSA: hda - Don't trigger jackpoll_work in azx_resume > > sound/pci/hda/hda_codec.c | 18 +++++++++++++++++- > sound/pci/hda/hda_intel.c | 8 ++++---- > 2 files changed, 21 insertions(+), 5 deletions(-) > > Hui, doesn't look like the second patch applies cleanly to any of B, B-OEM or C, and it's not a straightforward modification for me to get them to apply. Could you please rebase your trees and make sure those patches can apply on top of the current HEADs? Thanks
On 2019/3/25 下午1:09, Khaled Elmously wrote: > On 2019-03-20 09:47:15 , Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1820930 >> >> To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced >> a new patch which affect this issue, so the DISCO needs 2 patches. >> >> [Impact] >> After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop >> working, they can't detect jack plugging/unplugging or the audio device >> can't show up in the gnome-sound-setting >> >> [Fix] >> After S3, if it runs runtime_resume(), the codec works again. We change >> the driver to let system_resume() trigger runtime_resume() >> >> [Test Case] >> This issue is reported from OEM project, some codecs can't detect >> jack pluggin/unplugging, some codecs can't show up in the UI, after >> applying this patch, all related bugs are fixed. >> >> [Regression Potential] >> Low. have tested on many machines (with this issue or without this issue), >> all worked well. >> >> >> >> Hui Wang (2): >> ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec >> ALSA: hda - Don't trigger jackpoll_work in azx_resume >> >> sound/pci/hda/hda_codec.c | 18 +++++++++++++++++- >> sound/pci/hda/hda_intel.c | 8 ++++---- >> 2 files changed, 21 insertions(+), 5 deletions(-) >> >> > Hui, doesn't look like the second patch applies cleanly to any of B, B-OEM or C, and it's not a straightforward modification for me to get them to apply. > > Could you please rebase your trees and make sure those patches can apply on top of the current HEADs? > > Thanks Hello Khaled, B, B-OEM and C don't need the 2nd patch, only D needs 2 patches; B, B-OEM and C only need the 1st patch. Regards, Hui.
On 2019-03-25 13:39:12 , hwang4 wrote: > > On 2019/3/25 下午1:09, Khaled Elmously wrote: > > On 2019-03-20 09:47:15 , Hui Wang wrote: > > > BugLink: https://bugs.launchpad.net/bugs/1820930 > > > > > > To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced > > > a new patch which affect this issue, so the DISCO needs 2 patches. > > > > > > [Impact] > > > After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop > > > working, they can't detect jack plugging/unplugging or the audio device > > > can't show up in the gnome-sound-setting > > > > > > [Fix] > > > After S3, if it runs runtime_resume(), the codec works again. We change > > > the driver to let system_resume() trigger runtime_resume() > > > > > > [Test Case] > > > This issue is reported from OEM project, some codecs can't detect > > > jack pluggin/unplugging, some codecs can't show up in the UI, after > > > applying this patch, all related bugs are fixed. > > > > > > [Regression Potential] > > > Low. have tested on many machines (with this issue or without this issue), > > > all worked well. > > > > > > > > > > > > Hui Wang (2): > > > ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec > > > ALSA: hda - Don't trigger jackpoll_work in azx_resume > > > > > > sound/pci/hda/hda_codec.c | 18 +++++++++++++++++- > > > sound/pci/hda/hda_intel.c | 8 ++++---- > > > 2 files changed, 21 insertions(+), 5 deletions(-) > > > > > > > > Hui, doesn't look like the second patch applies cleanly to any of B, B-OEM or C, and it's not a straightforward modification for me to get them to apply. > > > > Could you please rebase your trees and make sure those patches can apply on top of the current HEADs? > > > > Thanks > > Hello Khaled, > > B, B-OEM and C don't need the 2nd patch, only D needs 2 patches; B, B-OEM > and C only need the 1st patch. > Right, I see that now in the thread subjects. Thanks for clarifying > Regards, > > Hui. > >
Applied first patch to 3 trees On 2019-03-20 09:47:15 , Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1820930 > > To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced > a new patch which affect this issue, so the DISCO needs 2 patches. > > [Impact] > After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop > working, they can't detect jack plugging/unplugging or the audio device > can't show up in the gnome-sound-setting > > [Fix] > After S3, if it runs runtime_resume(), the codec works again. We change > the driver to let system_resume() trigger runtime_resume() > > [Test Case] > This issue is reported from OEM project, some codecs can't detect > jack pluggin/unplugging, some codecs can't show up in the UI, after > applying this patch, all related bugs are fixed. > > [Regression Potential] > Low. have tested on many machines (with this issue or without this issue), > all worked well. > > > > Hui Wang (2): > ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec > ALSA: hda - Don't trigger jackpoll_work in azx_resume > > sound/pci/hda/hda_codec.c | 18 +++++++++++++++++- > sound/pci/hda/hda_intel.c | 8 ++++---- > 2 files changed, 21 insertions(+), 5 deletions(-) > > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team