| Message ID | 20190227141517.12119-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Fix touchpad on Walmart Overpowered laptop | expand |
On 27.02.19 15:15, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1817200 > > [Impact] > Touchpad on Walmart Overpowered laptop doesn't work. Curious, is ^that its official title?? > > [Fix] > Quote the commit message: > "The gpio base for GPP-E was set incorrectly to 258 instead of 256" > > [Test] > User confirm the commit makes the touchpad work. > > [Regression Potential] > Low. This commit is in upstream stable for a while. Probably in this case acceptable. But from the change it modifies some magic number in some mysterious array of some random (ok, not that much) driver. Is that GPIO more consistent for the same HW than say in ALSA? Anyway: Acked-by: Stefan Bader <stefan.bader@canonical.com> > > Simon Detheridge (1): > pinctrl: cannonlake: Fix gpio base for GPP-E > > drivers/pinctrl/intel/pinctrl-cannonlake.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
> On Feb 27, 2019, at 23:12, Stefan Bader <stefan.bader@canonical.com> wrote: > > On 27.02.19 15:15, Kai-Heng Feng wrote: >> BugLink: https://bugs.launchpad.net/bugs/1817200 >> >> [Impact] >> Touchpad on Walmart Overpowered laptop doesn't work. > Curious, is ^that its official title?? Yea… it is. >> >> [Fix] >> Quote the commit message: >> "The gpio base for GPP-E was set incorrectly to 258 instead of 256" >> >> [Test] >> User confirm the commit makes the touchpad work. >> >> [Regression Potential] >> Low. This commit is in upstream stable for a while. > > Probably in this case acceptable. But from the change it modifies some magic > number in some mysterious array of some random (ok, not that much) driver. Is > that GPIO more consistent for the same HW than say in ALSA? Yes, the numbers are the same for the same generations chip. The same rule applies to Intel LPSS. ALSA is a whole different story, probably because most changes happen in Realtek’s codec. Kai-Heng > > Anyway: Acked-by: Stefan Bader <stefan.bader@canonical.com> >> >> Simon Detheridge (1): >> pinctrl: cannonlake: Fix gpio base for GPP-E >> >> drivers/pinctrl/intel/pinctrl-cannonlake.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
On 2019-02-27 22:15:16 , Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1817200 > > [Impact] > Touchpad on Walmart Overpowered laptop doesn't work. > > [Fix] > Quote the commit message: > "The gpio base for GPP-E was set incorrectly to 258 instead of 256" > > [Test] > User confirm the commit makes the touchpad work. > > [Regression Potential] > Low. This commit is in upstream stable for a while. > > Simon Detheridge (1): > pinctrl: cannonlake: Fix gpio base for GPP-E > > drivers/pinctrl/intel/pinctrl-cannonlake.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team