[0/4,SRU,B/C] System76 darp5 and oryp5 fixups
mbox series

Message ID 20190221164426.17652-1-seth.forshee@canonical.com
Headers show
Series
  • System76 darp5 and oryp5 fixups
Related show

Message

Seth Forshee Feb. 21, 2019, 4:44 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1815831

SRU Justification

Impact: The System76 darp5 and oryp5 platforms need audio driver quirks
to fix up the pin configuration.

Fix: One backport from upstream, and one cherry pick from the upstream
sound tree.

Test Case: Backports have been tested on the affected hardware.

Regression Potential: These are quirks for specific PCI device ids and
thus are not expected to introduce regressions for any other hardware.

Separate patch series follow for B and C, which need different context
adjustments for the first patch.

Thanks,
Seth

---

Jeremy Soller (2):
  ALSA: hda/realtek - Headset microphone support for System76 darp5
  ALSA: hda/realtek - Headset microphone and internal speaker support
    for System76 oryp5

 sound/pci/hda/patch_realtek.c | 39 +++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

Comments

Colin Ian King Feb. 21, 2019, 4:48 p.m. UTC | #1
On 21/02/2019 16:44, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1815831
> 
> SRU Justification
> 
> Impact: The System76 darp5 and oryp5 platforms need audio driver quirks
> to fix up the pin configuration.
> 
> Fix: One backport from upstream, and one cherry pick from the upstream
> sound tree.
> 
> Test Case: Backports have been tested on the affected hardware.
> 
> Regression Potential: These are quirks for specific PCI device ids and
> thus are not expected to introduce regressions for any other hardware.
> 
> Separate patch series follow for B and C, which need different context
> adjustments for the first patch.
> 
> Thanks,
> Seth
> 
> ---
> 
> Jeremy Soller (2):
>   ALSA: hda/realtek - Headset microphone support for System76 darp5
>   ALSA: hda/realtek - Headset microphone and internal speaker support
>     for System76 oryp5
> 
>  sound/pci/hda/patch_realtek.c | 39 +++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> 
> 

Is this enablement or quirkage fixing? I'm going for the latter, in
which case as these changes are quirked for specific H/W and hence are
low-risk regression potential changes.. so for all:

Acked-by: Colin Ian King <colin.king@canonical.com>
AceLan Kao Feb. 22, 2019, 7:54 a.m. UTC | #2
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Khalid Elmously Feb. 22, 2019, 1:50 p.m. UTC | #3
On 2019-02-21 17:44:22 , Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1815831
> 
> SRU Justification
> 
> Impact: The System76 darp5 and oryp5 platforms need audio driver quirks
> to fix up the pin configuration.
> 
> Fix: One backport from upstream, and one cherry pick from the upstream
> sound tree.
> 
> Test Case: Backports have been tested on the affected hardware.
> 
> Regression Potential: These are quirks for specific PCI device ids and
> thus are not expected to introduce regressions for any other hardware.
> 
> Separate patch series follow for B and C, which need different context
> adjustments for the first patch.
> 
> Thanks,
> Seth
> 
> ---
> 
> Jeremy Soller (2):
>   ALSA: hda/realtek - Headset microphone support for System76 darp5
>   ALSA: hda/realtek - Headset microphone and internal speaker support
>     for System76 oryp5
> 
>  sound/pci/hda/patch_realtek.c | 39 +++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team