[SRU,B/C/D/Unstable,0/1] Fix I219 doesn't get woken up after plugging ethernet cable
mbox series

Message ID 20190221124938.9547-1-kai.heng.feng@canonical.com
Headers show
Series
  • Fix I219 doesn't get woken up after plugging ethernet cable
Related show

Message

Kai-Heng Feng Feb. 21, 2019, 12:49 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1817058

[Impact]
Plugging ethernet cable doesn't work on new I219 after it runtime
suspends to D3.

[Fix]
Intel confirms that it only supports D0, so disable runtime power
management to prevent it from entering D3.

[Test]
Once the patch applied, the device always stays at D0, which doesn't
have this problem.

[Regression Potential]
Low. This doesn't introduce any functional change.

Kai-Heng Feng (1):
  e1000e: Disable runtime PM on CNP+

 drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Seth Forshee Feb. 22, 2019, 10:19 a.m. UTC | #1
On Thu, Feb 21, 2019 at 08:49:37PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817058
> 
> [Impact]
> Plugging ethernet cable doesn't work on new I219 after it runtime
> suspends to D3.
> 
> [Fix]
> Intel confirms that it only supports D0, so disable runtime power
> management to prevent it from entering D3.
> 
> [Test]
> Once the patch applied, the device always stays at D0, which doesn't
> have this problem.
> 
> [Regression Potential]
> Low. This doesn't introduce any functional change.

I don't agree that there's no functional change, but it is limited in
scope and has positive testing for the affected hardware.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to disco and unstable, thanks!
Timo Aaltonen March 15, 2019, 6:33 a.m. UTC | #2
On 21.2.2019 14.49, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1817058
> 
> [Impact]
> Plugging ethernet cable doesn't work on new I219 after it runtime
> suspends to D3.
> 
> [Fix]
> Intel confirms that it only supports D0, so disable runtime power
> management to prevent it from entering D3.
> 
> [Test]
> Once the patch applied, the device always stays at D0, which doesn't
> have this problem.
> 
> [Regression Potential]
> Low. This doesn't introduce any functional change.
> 
> Kai-Heng Feng (1):
>   e1000e: Disable runtime PM on CNP+
> 
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied to oem-next, thanks