[V1,net,0/2] net: ena: race condition bug fix and version update
mbox series

Message ID 1549905464-13758-1-git-send-email-akiyano@amazon.com
Headers show
Series
  • net: ena: race condition bug fix and version update
Related show

Message

Kiyanovski, Arthur Feb. 11, 2019, 5:17 p.m. UTC
From: Arthur Kiyanovski <akiyano@amazon.com>

This patchset includes a fix to a race condition that can cause
kernel panic, as well as a driver version update because of this
fix.

Arthur Kiyanovski (2):
  net: ena: fix race between link up and device initalization
  net: ena: update driver version from 2.0.2 to 2.0.3

 drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 +++++-----
 drivers/net/ethernet/amazon/ena/ena_netdev.h |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

David Miller Feb. 12, 2019, 7:06 p.m. UTC | #1
From: <akiyano@amazon.com>
Date: Mon, 11 Feb 2019 19:17:42 +0200

> From: Arthur Kiyanovski <akiyano@amazon.com>
> 
> This patchset includes a fix to a race condition that can cause
> kernel panic, as well as a driver version update because of this
> fix.

Series applied and patch #1 queued up for -stable.

But I want to reiterate what Andrew said, the version is so increibly
useless and stupid.

I'm going to submit the fix to -stable, and then people will then
doubly and triply have no relationship between driver version number
and what fixes exist.
Bshara, Saeed March 13, 2019, 12:59 p.m. UTC | #2
David, 
sorry for the late response. I agree that with stable versions the driver version is not good indication for which exact code is running.
however, we have many users that port the latest ena driver as-is from kernel sources into their older kernels, mainly to pull new ENA features (e.g. low latency queues). for those cases, the driver version helps us to identify the driver's code, so in practice this just works fine.

saeed


From: David Miller <davem@davemloft.net>
Sent: Tuesday, February 12, 2019 9:06 PM
To: Kiyanovski, Arthur
Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; Bshara, Saeed; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Tzalik, Guy; Belgazal, Netanel; Saidi, Ali
Subject: Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update 
    
From: <akiyano@amazon.com>
Date: Mon, 11 Feb 2019 19:17:42 +0200

> From: Arthur Kiyanovski <akiyano@amazon.com>
> 
> This patchset includes a fix to a race condition that can cause
> kernel panic, as well as a driver version update because of this
> fix.

Series applied and patch #1 queued up for -stable.

But I want to reiterate what Andrew said, the version is so increibly
useless and stupid.

I'm going to submit the fix to -stable, and then people will then
doubly and triply have no relationship between driver version number
and what fixes exist.
David Miller March 13, 2019, 5:52 p.m. UTC | #3
From: "Bshara, Saeed" <saeedb@amazon.com>
Date: Wed, 13 Mar 2019 12:59:34 +0000

> sorry for the late response. I agree that with stable versions the
> driver version is not good indication for which exact code is
> running.  however, we have many users that port the latest ena
> driver as-is from kernel sources into their older kernels, mainly to
> pull new ENA features (e.g. low latency queues). for those cases,
> the driver version helps us to identify the driver's code, so in
> practice this just works fine.

I will try one more time.

If I push fix X for the ENA driver to -stable and that bumps the version
number, all of the features associated with that version number are not
present in the -stable backport.

It does NOT work.