[v6,0/5] i2c: ocores: improvements
mbox series

Message ID 20190211164913.5988-1-federico.vaga@cern.ch
Headers show
Series
  • i2c: ocores: improvements
Related show

Message

Federico Vaga Feb. 11, 2019, 4:49 p.m. UTC
This patch set provides improvements to the i2c-ocore driver.

[V5 -> V6]
- remove redundant code introduced in V5 (double read control register)

[V4 -> V5]
- deterministic status of IEN bit in register "CONTROL" at the end of
  ocores_init()
- more style fixes

[V3 -> V4]
- add reviews-by/tested-by
- add comment to justify the formula in
    udelay((8 * 1000) / i2c->bus_clock_khz);

[V2 -> V3]
- fix particular error condition on platform_get_irq(). Copied from
  https://patchwork.ozlabs.org/patch/1038409/

[V1 -> V2]
- replaced usleep_range() with udelay() so that the polling version can be
  used in atomic context.
- added dedicated patch for minor style issues
- fixed delay computation
- use spin_lock_irqsave(), instead of spin_trylock_irqsave(). IACK is always
  necessary and a trylock would generate an extra interrupt for nothing
- make the driver ready for an eventual master_xfer_irqless()

Comments

Andrew Lunn Feb. 14, 2019, 3:07 a.m. UTC | #1
On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote:
> This patch set provides improvements to the i2c-ocore driver.
> 
> [V5 -> V6]
> - remove redundant code introduced in V5 (double read control register)
> 
> [V4 -> V5]
> - deterministic status of IEN bit in register "CONTROL" at the end of
>   ocores_init()
> - more style fixes
> 
> [V3 -> V4]
> - add reviews-by/tested-by
> - add comment to justify the formula in
>     udelay((8 * 1000) / i2c->bus_clock_khz);

Hi Federico

It looks like all the reviewed-by: tags disappeared from v5.

Can you add them back again, and then we can probably merge this
patchset.

	Thanks
		Andrew
Federico Vaga Feb. 14, 2019, 8:39 a.m. UTC | #2
On Thursday, February 14, 2019 4:07:33 AM CET Andrew Lunn wrote:
> On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote:
> > This patch set provides improvements to the i2c-ocore driver.
> > 
> > [V5 -> V6]
> > - remove redundant code introduced in V5 (double read control register)
> > 
> > [V4 -> V5]
> > - deterministic status of IEN bit in register "CONTROL" at the end of
> > 
> >   ocores_init()
> > 
> > - more style fixes
> > 
> > [V3 -> V4]
> > - add reviews-by/tested-by
> > - add comment to justify the formula in
> > 
> >     udelay((8 * 1000) / i2c->bus_clock_khz);
> 
> Hi Federico
> 
> It looks like all the reviewed-by: tags disappeared from v5.
> 
> Can you add them back again, and then we can probably merge this
> patchset.

v7 is coming (@wolfram) with SPDX tag in the header file

> 	Thanks
> 		Andrew