| Message ID | 20190211133107.11253-1-dan.streetman@canonical.com |
|---|---|
| Headers | show |
| Series | amdgpu with mst WARNING on blanking | expand |
On 11.02.19 14:31, Dan Streetman wrote: > From: Dan Streetman <ddstreet@canonical.com> > > This series fixes amdgpu screen blanking when using displayport monitors > in MST configuration (i.e. displayport "daisy chaining"). > > Note that the amdgpu driver, and DP MST, appears to be quite problematic, > even upstream, and this patchset doesn't appear to fix all paths that > lead to this WARNING being issued (and/or other amdgpu problems/failures). > However it does appear to correct the simple case of this warning being > issued (sometimes along with more serious failures) for each screen > blanking/unblanking. > > This is changed from the v1 series by adding 3 more patches so all > are complete cherry-picks, with no backporting (other than minor > context differences) required. > > Andrew Jiang (1): > drm/amd/display: Don't use dc_link in link_encoder > > Charlene Liu (1): > drm/amd/display: eDP sequence BL off first then DP blank. > > Harry Wentland (1): > drm/amd/display: Fix warning about misaligned code > > Jerry (Fangzhi) Zuo (1): > drm/amd/display: Fix MST dp_blank REG_WAIT timeout > > Leo (Sunpeng) Li (1): > drm/amd/display: Fix unused variable compilation error > > Yongqiang Sun (1): > drm/amd/display: Move wait for hpd ready out from edp power control. > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 30 ++++++-- > .../drm/amd/display/dc/core/dc_link_hwss.c | 20 ++--- > .../drm/amd/display/dc/dce/dce_link_encoder.c | 24 +----- > .../drm/amd/display/dc/dce/dce_link_encoder.h | 5 +- > .../display/dc/dce110/dce110_hw_sequencer.c | 73 ++++++++++++------- > .../display/dc/dce110/dce110_hw_sequencer.h | 9 ++- > .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 +- > .../drm/amd/display/dc/inc/hw/link_encoder.h | 2 +- > .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 5 +- > .../display/dc/virtual/virtual_link_encoder.c | 3 +- > 10 files changed, 100 insertions(+), 78 deletions(-) > I don't dare to push back on this again as it seems to become bigger every time it comes back. We need to be carefully watching for regressions there next cycle (I added some reminder). Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 2/11/19 2:31 PM, Dan Streetman wrote: > From: Dan Streetman <ddstreet@canonical.com> > > This series fixes amdgpu screen blanking when using displayport monitors > in MST configuration (i.e. displayport "daisy chaining"). > > Note that the amdgpu driver, and DP MST, appears to be quite problematic, > even upstream, and this patchset doesn't appear to fix all paths that > lead to this WARNING being issued (and/or other amdgpu problems/failures). > However it does appear to correct the simple case of this warning being > issued (sometimes along with more serious failures) for each screen > blanking/unblanking. > > This is changed from the v1 series by adding 3 more patches so all > are complete cherry-picks, with no backporting (other than minor > context differences) required. > > Andrew Jiang (1): > drm/amd/display: Don't use dc_link in link_encoder > > Charlene Liu (1): > drm/amd/display: eDP sequence BL off first then DP blank. > > Harry Wentland (1): > drm/amd/display: Fix warning about misaligned code > > Jerry (Fangzhi) Zuo (1): > drm/amd/display: Fix MST dp_blank REG_WAIT timeout > > Leo (Sunpeng) Li (1): > drm/amd/display: Fix unused variable compilation error > > Yongqiang Sun (1): > drm/amd/display: Move wait for hpd ready out from edp power control. > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 30 ++++++-- > .../drm/amd/display/dc/core/dc_link_hwss.c | 20 ++--- > .../drm/amd/display/dc/dce/dce_link_encoder.c | 24 +----- > .../drm/amd/display/dc/dce/dce_link_encoder.h | 5 +- > .../display/dc/dce110/dce110_hw_sequencer.c | 73 ++++++++++++------- > .../display/dc/dce110/dce110_hw_sequencer.h | 9 ++- > .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 +- > .../drm/amd/display/dc/inc/hw/link_encoder.h | 2 +- > .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 5 +- > .../display/dc/virtual/virtual_link_encoder.c | 3 +- > 10 files changed, 100 insertions(+), 78 deletions(-) > Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 2/11/19 2:31 PM, Dan Streetman wrote: > From: Dan Streetman <ddstreet@canonical.com> > > This series fixes amdgpu screen blanking when using displayport monitors > in MST configuration (i.e. displayport "daisy chaining"). > > Note that the amdgpu driver, and DP MST, appears to be quite problematic, > even upstream, and this patchset doesn't appear to fix all paths that > lead to this WARNING being issued (and/or other amdgpu problems/failures). > However it does appear to correct the simple case of this warning being > issued (sometimes along with more serious failures) for each screen > blanking/unblanking. > > This is changed from the v1 series by adding 3 more patches so all > are complete cherry-picks, with no backporting (other than minor > context differences) required. > > Andrew Jiang (1): > drm/amd/display: Don't use dc_link in link_encoder > > Charlene Liu (1): > drm/amd/display: eDP sequence BL off first then DP blank. > > Harry Wentland (1): > drm/amd/display: Fix warning about misaligned code > > Jerry (Fangzhi) Zuo (1): > drm/amd/display: Fix MST dp_blank REG_WAIT timeout > > Leo (Sunpeng) Li (1): > drm/amd/display: Fix unused variable compilation error > > Yongqiang Sun (1): > drm/amd/display: Move wait for hpd ready out from edp power control. > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 30 ++++++-- > .../drm/amd/display/dc/core/dc_link_hwss.c | 20 ++--- > .../drm/amd/display/dc/dce/dce_link_encoder.c | 24 +----- > .../drm/amd/display/dc/dce/dce_link_encoder.h | 5 +- > .../display/dc/dce110/dce110_hw_sequencer.c | 73 ++++++++++++------- > .../display/dc/dce110/dce110_hw_sequencer.h | 9 ++- > .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 +- > .../drm/amd/display/dc/inc/hw/link_encoder.h | 2 +- > .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 5 +- > .../display/dc/virtual/virtual_link_encoder.c | 3 +- > 10 files changed, 100 insertions(+), 78 deletions(-) > Applied to bionic/master-next branch. Thanks, Kleber
From: Dan Streetman <ddstreet@canonical.com> This series fixes amdgpu screen blanking when using displayport monitors in MST configuration (i.e. displayport "daisy chaining"). Note that the amdgpu driver, and DP MST, appears to be quite problematic, even upstream, and this patchset doesn't appear to fix all paths that lead to this WARNING being issued (and/or other amdgpu problems/failures). However it does appear to correct the simple case of this warning being issued (sometimes along with more serious failures) for each screen blanking/unblanking. This is changed from the v1 series by adding 3 more patches so all are complete cherry-picks, with no backporting (other than minor context differences) required. Andrew Jiang (1): drm/amd/display: Don't use dc_link in link_encoder Charlene Liu (1): drm/amd/display: eDP sequence BL off first then DP blank. Harry Wentland (1): drm/amd/display: Fix warning about misaligned code Jerry (Fangzhi) Zuo (1): drm/amd/display: Fix MST dp_blank REG_WAIT timeout Leo (Sunpeng) Li (1): drm/amd/display: Fix unused variable compilation error Yongqiang Sun (1): drm/amd/display: Move wait for hpd ready out from edp power control. drivers/gpu/drm/amd/display/dc/core/dc_link.c | 30 ++++++-- .../drm/amd/display/dc/core/dc_link_hwss.c | 20 ++--- .../drm/amd/display/dc/dce/dce_link_encoder.c | 24 +----- .../drm/amd/display/dc/dce/dce_link_encoder.h | 5 +- .../display/dc/dce110/dce110_hw_sequencer.c | 73 ++++++++++++------- .../display/dc/dce110/dce110_hw_sequencer.h | 9 ++- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 7 +- .../drm/amd/display/dc/inc/hw/link_encoder.h | 2 +- .../gpu/drm/amd/display/dc/inc/hw_sequencer.h | 5 +- .../display/dc/virtual/virtual_link_encoder.c | 3 +- 10 files changed, 100 insertions(+), 78 deletions(-)