[v3,0/3,net-next] net: phy: disregard "Clause 22 registers present" bit in get_phy_c45_devs_in_pkg
mbox series

Message ID 75c9d8ee-582f-f247-7595-d8732ac26c20@gmail.com
Headers show
Series
  • net: phy: disregard "Clause 22 registers present" bit in get_phy_c45_devs_in_pkg
Related show

Message

Heiner Kallweit Feb. 8, 2019, 7:19 p.m. UTC
Bit 0 in register 1.5 doesn't represent a device but is a flag that
Clause 22 registers are present. Therefore disregard this bit when
populating the device list. If code needs this information it
should read register 1.5 directly instead of accessing the device
list.
Because this bit doesn't represent a device don't define a
MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for
the flag in the device list bitmap.

v2:
- make masking of bit 0 more explicit
- improve commit message

v3:
- replace single patch with a series
- add functionality of patch 1

Heiner Kallweit (3):
  net: phy: remove unneeded masking of PHY register read results
  net: phy: disregard "Clause 22 registers present" bit in
    get_phy_c45_devs_in_pkg
  net: phy: add constant for "Clause 22 registers present" flags in
    device list bitmap

 drivers/net/phy/phy_device.c | 15 +++++++++------
 include/uapi/linux/mdio.h    |  1 +
 2 files changed, 10 insertions(+), 6 deletions(-)

Comments

David Miller Feb. 11, 2019, 9:19 p.m. UTC | #1
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 8 Feb 2019 20:19:17 +0100

> Bit 0 in register 1.5 doesn't represent a device but is a flag that
> Clause 22 registers are present. Therefore disregard this bit when
> populating the device list. If code needs this information it
> should read register 1.5 directly instead of accessing the device
> list.
> Because this bit doesn't represent a device don't define a
> MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for
> the flag in the device list bitmap.
 ...

This doesn't apply cleanly to net-next, please respin.

Thanks.
Heiner Kallweit Feb. 11, 2019, 9:34 p.m. UTC | #2
On 11.02.2019 22:19, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail.com>
> Date: Fri, 8 Feb 2019 20:19:17 +0100
> 
>> Bit 0 in register 1.5 doesn't represent a device but is a flag that
>> Clause 22 registers are present. Therefore disregard this bit when
>> populating the device list. If code needs this information it
>> should read register 1.5 directly instead of accessing the device
>> list.
>> Because this bit doesn't represent a device don't define a
>> MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for
>> the flag in the device list bitmap.
>  ...
> 
> This doesn't apply cleanly to net-next, please respin.
> 
You applied v2 already, and with a follow-up patch I "upgraded"
it to v3. So you can disregard this series.

> Thanks.
>
David Miller Feb. 11, 2019, 9:43 p.m. UTC | #3
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 11 Feb 2019 22:34:34 +0100

> On 11.02.2019 22:19, David Miller wrote:
>> From: Heiner Kallweit <hkallweit1@gmail.com>
>> Date: Fri, 8 Feb 2019 20:19:17 +0100
>> 
>>> Bit 0 in register 1.5 doesn't represent a device but is a flag that
>>> Clause 22 registers are present. Therefore disregard this bit when
>>> populating the device list. If code needs this information it
>>> should read register 1.5 directly instead of accessing the device
>>> list.
>>> Because this bit doesn't represent a device don't define a
>>> MDIO_MMD_XYZ constant, just define a MDIO_DEVS_XYZ constant for
>>> the flag in the device list bitmap.
>>  ...
>> 
>> This doesn't apply cleanly to net-next, please respin.
>> 
> You applied v2 already, and with a follow-up patch I "upgraded"
> it to v3. So you can disregard this series.

Oh that's right, thanks.