Message ID | 1549617190-387130-1-git-send-email-vasundhara-v.volam@broadcom.com |
---|---|
Headers | show |
Series | Revert wake_on_lan devlink parameter | expand |
From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> Date: Fri, 8 Feb 2019 14:43:08 +0530 > As per discussion with Jakub Kicinski and Michal Kubecek, > this will be better addressed by soon-too-come ethtool netlink > API with additional indication that given WoL configuration request > is supposed to be persisted. > > Retain bnxt_en code for devlink port param table registration. > There will be follow up patches to add some devlink port params > for bnxt_en driver. Please fix the kbuild robot reported build failure and repost.
On Sat, Feb 9, 2019 at 12:37 PM David Miller <davem@davemloft.net> wrote: > > From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> > Date: Fri, 8 Feb 2019 14:43:08 +0530 > > > As per discussion with Jakub Kicinski and Michal Kubecek, > > this will be better addressed by soon-too-come ethtool netlink > > API with additional indication that given WoL configuration request > > is supposed to be persisted. > > > > Retain bnxt_en code for devlink port param table registration. > > There will be follow up patches to add some devlink port params > > for bnxt_en driver. > > Please fix the kbuild robot reported build failure and repost. David, second patch in this patchset has already taken care of all this failures. Could you please apply both patches together?
From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> Date: Mon, 11 Feb 2019 10:09:23 +0530 > On Sat, Feb 9, 2019 at 12:37 PM David Miller <davem@davemloft.net> wrote: >> >> From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> >> Date: Fri, 8 Feb 2019 14:43:08 +0530 >> >> > As per discussion with Jakub Kicinski and Michal Kubecek, >> > this will be better addressed by soon-too-come ethtool netlink >> > API with additional indication that given WoL configuration request >> > is supposed to be persisted. >> > >> > Retain bnxt_en code for devlink port param table registration. >> > There will be follow up patches to add some devlink port params >> > for bnxt_en driver. >> >> Please fix the kbuild robot reported build failure and repost. > David, second patch in this patchset has already taken care of all > this failures. > Could you please apply both patches together? You cannot break bisection like this. If they cannot be separated, resubmit the change as one patch.
On Mon, Feb 11, 2019 at 1:05 PM David Miller <davem@davemloft.net> wrote: > > From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> > Date: Mon, 11 Feb 2019 10:09:23 +0530 > > > On Sat, Feb 9, 2019 at 12:37 PM David Miller <davem@davemloft.net> wrote: > >> > >> From: Vasundhara Volam <vasundhara-v.volam@broadcom.com> > >> Date: Fri, 8 Feb 2019 14:43:08 +0530 > >> > >> > As per discussion with Jakub Kicinski and Michal Kubecek, > >> > this will be better addressed by soon-too-come ethtool netlink > >> > API with additional indication that given WoL configuration request > >> > is supposed to be persisted. > >> > > >> > Retain bnxt_en code for devlink port param table registration. > >> > There will be follow up patches to add some devlink port params > >> > for bnxt_en driver. > >> > >> Please fix the kbuild robot reported build failure and repost. > > David, second patch in this patchset has already taken care of all > > this failures. > > Could you please apply both patches together? > > You cannot break bisection like this. > > If they cannot be separated, resubmit the change as one patch. Okay. I will resubmit as one patch. Thank you David.