| Message ID | 20190129084433.5368-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Ignore "incomplete report" from Elan touchpanels | expand |
On 29.01.19 09:44, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1813733 > > [Impact] > When using Elan touchpanels, this message keeps getting spurted out: > [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) > This is an error message, so systemd-journald flushes to disk as soon as > the message shows. This prevents the storage enters power saving state, > hurting battery time. > > Other than the annoying message, the touchpad itself works fine. > > [Fix] > Just warn once to avoid the annoying message. > > [Test] > The annoying message stops once the fix applied. > > [Regression Potential] > None. The user still gets the warning from dmesg without all the > flooding. > > Kai-Heng Feng (1): > HID: i2c-hid: Ignore input report if there's no data present on Elan > touchpanels > > drivers/hid/i2c-hid/i2c-hid-core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > Is this just bad memory of mine or has this incomplete report thing seen multiple fixes and fixes on top of those fixes? And if so, are we done now? -Stefan
> On Jan 30, 2019, at 10:26 PM, Stefan Bader <stefan.bader@canonical.com> wrote: > > On 29.01.19 09:44, Kai-Heng Feng wrote: >> BugLink: https://bugs.launchpad.net/bugs/1813733 >> >> [Impact] >> When using Elan touchpanels, this message keeps getting spurted out: >> [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) >> This is an error message, so systemd-journald flushes to disk as soon as >> the message shows. This prevents the storage enters power saving state, >> hurting battery time. >> >> Other than the annoying message, the touchpad itself works fine. >> >> [Fix] >> Just warn once to avoid the annoying message. >> >> [Test] >> The annoying message stops once the fix applied. >> >> [Regression Potential] >> None. The user still gets the warning from dmesg without all the >> flooding. >> >> Kai-Heng Feng (1): >> HID: i2c-hid: Ignore input report if there's no data present on Elan >> touchpanels >> >> drivers/hid/i2c-hid/i2c-hid-core.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> > Is this just bad memory of mine or has this incomplete report thing seen > multiple fixes and fixes on top of those fixes? And if so, are we done now? Different touchpanel has its own quirky behavior. For now, the fixes piled up are separate, they do not depend on each other. For this particular issue - "incomplete report (14/65535)” when _using_ Elan touchpad, yes, this is done. Kai-Heng > > -Stefan
On Tue, Jan 29, 2019 at 04:44:29PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1813733 > > [Impact] > When using Elan touchpanels, this message keeps getting spurted out: > [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) > This is an error message, so systemd-journald flushes to disk as soon as > the message shows. This prevents the storage enters power saving state, > hurting battery time. > > Other than the annoying message, the touchpad itself works fine. > > [Fix] > Just warn once to avoid the annoying message. > > [Test] > The annoying message stops once the fix applied. > > [Regression Potential] > None. The user still gets the warning from dmesg without all the > flooding. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to disco/master-next and unstable/master, thanks!
On 29.01.19 09:44, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1813733 > > [Impact] > When using Elan touchpanels, this message keeps getting spurted out: > [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) > This is an error message, so systemd-journald flushes to disk as soon as > the message shows. This prevents the storage enters power saving state, > hurting battery time. > > Other than the annoying message, the touchpad itself works fine. > > [Fix] > Just warn once to avoid the annoying message. > > [Test] > The annoying message stops once the fix applied. > > [Regression Potential] > None. The user still gets the warning from dmesg without all the > flooding. > > Kai-Heng Feng (1): > HID: i2c-hid: Ignore input report if there's no data present on Elan > touchpanels > > drivers/hid/i2c-hid/i2c-hid-core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 2019-01-29 16:44:29 , Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1813733 > > [Impact] > When using Elan touchpanels, this message keeps getting spurted out: > [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) > This is an error message, so systemd-journald flushes to disk as soon as > the message shows. This prevents the storage enters power saving state, > hurting battery time. > > Other than the annoying message, the touchpad itself works fine. > > [Fix] > Just warn once to avoid the annoying message. > > [Test] > The annoying message stops once the fix applied. > > [Regression Potential] > None. The user still gets the warning from dmesg without all the > flooding. > > Kai-Heng Feng (1): > HID: i2c-hid: Ignore input report if there's no data present on Elan > touchpanels > > drivers/hid/i2c-hid/i2c-hid-core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > -- > 2.17.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
BugLink: https://bugs.launchpad.net/bugs/1813733 [Impact] When using Elan touchpanels, this message keeps getting spurted out: [ 136.138487] i2c_hid i2c-DELL08D6:00: i2c_hid_get_input: incomplete report (14/65535) This is an error message, so systemd-journald flushes to disk as soon as the message shows. This prevents the storage enters power saving state, hurting battery time. Other than the annoying message, the touchpad itself works fine. [Fix] Just warn once to avoid the annoying message. [Test] The annoying message stops once the fix applied. [Regression Potential] None. The user still gets the warning from dmesg without all the flooding. Kai-Heng Feng (1): HID: i2c-hid: Ignore input report if there's no data present on Elan touchpanels drivers/hid/i2c-hid/i2c-hid-core.c | 9 +++++++++ 1 file changed, 9 insertions(+)