mbox series

[0/2] pinctrl: sh-pfc: r8a77990: Rework GP6_9 no pull down handling

Message ID 20190111115744.29685-1-geert+renesas@glider.be
Headers show
Series pinctrl: sh-pfc: r8a77990: Rework GP6_9 no pull down handling | expand

Message

Geert Uytterhoeven Jan. 11, 2019, 11:57 a.m. UTC 
Hi,

Commit f4caa6ee736fa8a4 ("pinctrl: sh-pfc: r8a77990: Add support for pull-up
only pins") added an explicit check for the GP6_9 pin on R-Car E3, which
supports pull-up, but not pull-down.

However, I had forgotten this limitation can be expressed better by
dropping the SH_PFC_PIN_CFG_PULL_DOWN flag from the GPIO description, as
it includes returning an error to the caller when trying to configure
the pin for pull-down.

Hence this patch series drops the SH_PFC_PIN_CFG_PULL_DOWN flag, and
reverts the previous solution.

This has been tested on by adding the following to the pfc node in
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts:

	pinctrl-0 = <&test6_9>;
	pinctrl-names = "default";

	test6_9: test6_9 {
		pins = "GP_6_9";
		bias-pull-down;
	};

I plan to queue this up in sh-pfc-for-v5.1.

Thanks!

Geert Uytterhoeven (2):
  pinctrl: sh-pfc: r8a77990: GP6_9 does not have pull-down capability
  Revert "pinctrl: sh-pfc: r8a77990: Add support for pull-up only pins"

 drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 34 ++++++++++++---------------
 1 file changed, 15 insertions(+), 19 deletions(-)