| Message ID | 1547045089-19128-1-git-send-email-krzk@kernel.org |
|---|---|
| Headers | show |
| Series | leds: trigger: Add pattern initialization from Device Tree | expand |
On Wed 2019-01-09 15:44:46, Krzysztof Kozlowski wrote: > Multiple LED triggers might need to access default pattern so add a > helper for that. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Pavel Machek <pavel@ucw.cz>
On Wed 2019-01-09 15:44:47, Krzysztof Kozlowski wrote: > Allow initialization of pattern used in pattern trigger from Device Tree > property. > > This is especially useful for embedded systems where the pattern trigger > would be used to indicate the process of boot status in a nice, > user-friendly blinking way. This initialization pattern will be used > till user-space is brought up and sets its own pattern, indicating the > boot status is for example finished. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Pavel Machek <pavel@ucw.cz>
Hi Krzysztof. On 1/9/19 3:44 PM, Krzysztof Kozlowski wrote: > Hi, > > Changes since v6: > 1. Drop goto from led_get_default_pattern() and rename "DeviceTree" > into "device tree". > 2. Add Pavel's ack to patch 1/5. > > Changes since v5: > 1. Drop the "classdev" prefix from helper for getting default pattern > and move the kerneldoc to header file (this was not fixed in v5 by > mistake). > > Changes since v4: > 1. Move helper to get default pattern from led-class.c to led-core.c and > rename it (build issue pointed by kbuild robot). > > Changes since v3: > 1. Add missing EXPORT_SYMBOL_GPL. > 2. Put pattern trigger format into common file - shared between > dt-bindings and sysfs. > 3. Use array of integers as led-pattern property (since it is bigger change > I did not add Pavel's ack to patch 2/5). > 4. Mention ms units for led-pattern bindings. > > Changes since v2: > 1. Drop Jacek's patches and my "led: triggers: Initialize > LED_INIT_DEFAULT_TRIGGER if trigger is brought after class". > 2. Follow Rob's advices about bindings - use "led-pattern" property > and generalize usage of it into to three triggers. > 3. New patches (2/5, 4/5 and 5/5). > > Changes since v1: > 1. Rebase on Jacek's patches. > 2. Add patch 3/5 for fixup of Jacek's solution. > 3. Drop first two patches from the series (applied). > 4. Patch 5/5: Use LED_INIT_DEFAULT_TRIGGER (suggested by Jacek Anaszewski). > 5. Patch 5/5: Return-on-error and log warning (suggested by Pavel Machek). > > > Best regards, > Krzysztof > > Krzysztof Kozlowski (5): > dt-bindings: leds: Add pattern initialization from Device Tree > leds: Add helper for getting default pattern from Device Tree > leds: trigger: pattern: Add pattern initialization from Device Tree > leds: trigger: oneshot: Add initialization from Device Tree > leds: trigger: timer: Add initialization from Device Tree > > .../ABI/testing/sysfs-class-led-trigger-pattern | 51 +---------- > Documentation/devicetree/bindings/leds/common.txt | 12 +++ > .../bindings/leds/leds-trigger-pattern.txt | 49 +++++++++++ > drivers/leds/led-core.c | 30 +++++++ > drivers/leds/trigger/ledtrig-oneshot.c | 38 ++++++++- > drivers/leds/trigger/ledtrig-pattern.c | 99 +++++++++++++++++----- > drivers/leds/trigger/ledtrig-timer.c | 34 ++++++++ > include/linux/leds.h | 13 +++ > 8 files changed, 257 insertions(+), 69 deletions(-) > create mode 100644 Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt > Patch set applied to the for-next branch of linux-leds.git. Thank you for your effort.