Message ID | 20190109091206.25759-1-vigneshr@ti.com |
---|---|
Headers | show |
Series | 8250_omap: use clk APIs to get fclk freqeuncy | expand |
* Vignesh R <vigneshr@ti.com> [190109 09:11]: > 8250_omap is DT only driver so dev->of_node always exists. Drop check > for existence of valid dev->of_node to simplify omap8250_probe(). That part seems safe to me now. > --- a/drivers/tty/serial/8250/8250_omap.c > +++ b/drivers/tty/serial/8250/8250_omap.c ... > - const struct of_device_id *id; > - > - ret = of_alias_get_id(pdev->dev.of_node, "serial"); > - > - of_property_read_u32(pdev->dev.of_node, "clock-frequency", > - &up.port.uartclk); > - priv->wakeirq = irq_of_parse_and_map(pdev->dev.of_node, 1); > - > - id = of_match_device(of_match_ptr(omap8250_dt_ids), &pdev->dev); > - if (id && id->data) > - priv->habit |= *(u8 *)id->data; But this part it seems we still need to keep around as we still have lots of clock-frequency references in the *.dtsi files. Or am I missing something? Regards Tony
Hi, On Wed, Jan 09, 2019 at 01:44:03PM -0800, Tony Lindgren wrote: > * Vignesh R <vigneshr@ti.com> [190109 09:11]: > > 8250_omap is DT only driver so dev->of_node always exists. Drop check > > for existence of valid dev->of_node to simplify omap8250_probe(). > > That part seems safe to me now. > > > --- a/drivers/tty/serial/8250/8250_omap.c > > +++ b/drivers/tty/serial/8250/8250_omap.c > ... > > - const struct of_device_id *id; > > - > > - ret = of_alias_get_id(pdev->dev.of_node, "serial"); > > - > > - of_property_read_u32(pdev->dev.of_node, "clock-frequency", > > - &up.port.uartclk); > > - priv->wakeirq = irq_of_parse_and_map(pdev->dev.of_node, 1); > > - > > - id = of_match_device(of_match_ptr(omap8250_dt_ids), &pdev->dev); > > - if (id && id->data) > > - priv->habit |= *(u8 *)id->data; > > But this part it seems we still need to keep around > as we still have lots of clock-frequency references > in the *.dtsi files. Or am I missing something? It's re-added a couple of lines later. Only the indent was removed. -- Sebastian
On 10-Jan-19 5:37 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Jan 09, 2019 at 01:44:03PM -0800, Tony Lindgren wrote: >> * Vignesh R <vigneshr@ti.com> [190109 09:11]: >>> 8250_omap is DT only driver so dev->of_node always exists. Drop check >>> for existence of valid dev->of_node to simplify omap8250_probe(). >> >> That part seems safe to me now. >> >>> --- a/drivers/tty/serial/8250/8250_omap.c >>> +++ b/drivers/tty/serial/8250/8250_omap.c >> ... >>> - const struct of_device_id *id; >>> - >>> - ret = of_alias_get_id(pdev->dev.of_node, "serial"); >>> - >>> - of_property_read_u32(pdev->dev.of_node, "clock-frequency", >>> - &up.port.uartclk); >>> - priv->wakeirq = irq_of_parse_and_map(pdev->dev.of_node, 1); >>> - >>> - id = of_match_device(of_match_ptr(omap8250_dt_ids), &pdev->dev); >>> - if (id && id->data) >>> - priv->habit |= *(u8 *)id->data; >> >> But this part it seems we still need to keep around >> as we still have lots of clock-frequency references >> in the *.dtsi files. Or am I missing something? > > It's re-added a couple of lines later. Only the indent was removed. > That's right. You beat me to it. Thanks :) Regards Vignesh
* Vignesh R <vigneshr@ti.com> [190110 13:24]: > > On 10-Jan-19 5:37 PM, Sebastian Reichel wrote: > > Hi, > > > > On Wed, Jan 09, 2019 at 01:44:03PM -0800, Tony Lindgren wrote: > >> * Vignesh R <vigneshr@ti.com> [190109 09:11]: > >>> 8250_omap is DT only driver so dev->of_node always exists. Drop check > >>> for existence of valid dev->of_node to simplify omap8250_probe(). > >> > >> That part seems safe to me now. > >> > >>> --- a/drivers/tty/serial/8250/8250_omap.c > >>> +++ b/drivers/tty/serial/8250/8250_omap.c > >> ... > >>> - const struct of_device_id *id; > >>> - > >>> - ret = of_alias_get_id(pdev->dev.of_node, "serial"); > >>> - > >>> - of_property_read_u32(pdev->dev.of_node, "clock-frequency", > >>> - &up.port.uartclk); > >>> - priv->wakeirq = irq_of_parse_and_map(pdev->dev.of_node, 1); > >>> - > >>> - id = of_match_device(of_match_ptr(omap8250_dt_ids), &pdev->dev); > >>> - if (id && id->data) > >>> - priv->habit |= *(u8 *)id->data; > >> > >> But this part it seems we still need to keep around > >> as we still have lots of clock-frequency references > >> in the *.dtsi files. Or am I missing something? > > > > It's re-added a couple of lines later. Only the indent was removed. > > > > That's right. You beat me to it. Thanks :) Oh right, sorry I missed that :) Regards, Tony