mbox series

[v3,0/4] pwm: rcar: Add support "atomic" API and improve calculation

Message ID 1547021948-7664-1-git-send-email-yoshihiro.shimoda.uh@renesas.com
Headers show
Series pwm: rcar: Add support "atomic" API and improve calculation | expand

Message

Yoshihiro Shimoda Jan. 9, 2019, 8:19 a.m. UTC
This patch series adds support for PWM "atomic" API and improve
the clock calculation.

Changes from v2 [1]:
 - Add Acked-by of Uwe in patch [234]/4.
 - Modify a condition to support normal polarity only.
 - Fix possible to output wrong a duty cycle when disabling in patch 1/4.
 - Fix overflow value on 32-bit arch in patch 4/4.

Changes from v1 [2]:
 - Remove workaround code of output pseudo low level for now because it is
   rejected on the ML.
 - Add a condition for polarity because the HW doesn't support polarity change
   in patch 1/4.
 - Improve the clock calculation in patch 4/4.

[1]
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=63219

Remarks:
On the email thread of patch 2/4, we discuss about suspend/resume
handling and I suposed to improve it. However, I need more time
how to improve it. So, for now, I don't improve it on this patch series.

[2]
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=53193


Yoshihiro Shimoda (4):
  pwm: rcar: Add support "atomic" API
  pwm: rcar: Use "atomic" API on rcar_pwm_resume()
  pwm: rcar: remove legacy APIs
  pwm: rcar: improve calculation of divider

 drivers/pwm/pwm-rcar.c | 99 ++++++++++++++++++++++++--------------------------
 1 file changed, 48 insertions(+), 51 deletions(-)

Comments

Thierry Reding March 4, 2019, 11:14 a.m. UTC | #1
On Wed, Jan 09, 2019 at 05:19:04PM +0900, Yoshihiro Shimoda wrote:
> This patch series adds support for PWM "atomic" API and improve
> the clock calculation.
> 
> Changes from v2 [1]:
>  - Add Acked-by of Uwe in patch [234]/4.
>  - Modify a condition to support normal polarity only.
>  - Fix possible to output wrong a duty cycle when disabling in patch 1/4.
>  - Fix overflow value on 32-bit arch in patch 4/4.
> 
> Changes from v1 [2]:
>  - Remove workaround code of output pseudo low level for now because it is
>    rejected on the ML.
>  - Add a condition for polarity because the HW doesn't support polarity change
>    in patch 1/4.
>  - Improve the clock calculation in patch 4/4.
> 
> [1]
> https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=63219
> 
> Remarks:
> On the email thread of patch 2/4, we discuss about suspend/resume
> handling and I suposed to improve it. However, I need more time
> how to improve it. So, for now, I don't improve it on this patch series.
> 
> [2]
> https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=53193
> 
> 
> Yoshihiro Shimoda (4):
>   pwm: rcar: Add support "atomic" API
>   pwm: rcar: Use "atomic" API on rcar_pwm_resume()
>   pwm: rcar: remove legacy APIs
>   pwm: rcar: improve calculation of divider
> 
>  drivers/pwm/pwm-rcar.c | 99 ++++++++++++++++++++++++--------------------------
>  1 file changed, 48 insertions(+), 51 deletions(-)

Applied, thanks.

Thierry