[SRU,Bionic/OEM-B/Cosmic/Disco,0/3] Add support for ALC3277 codec on new Dell edge gateways
mbox series

Message ID 20181214091141.16399-1-hui.wang@canonical.com
Headers show
Series
  • Add support for ALC3277 codec on new Dell edge gateways
Related show

Message

Hui Wang Dec. 14, 2018, 9:11 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1807334

This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
for Gen1 is already merged to b/c/d kernel, and this patchset is partly
based on Gen1's patches. Originally Shrirang is the developer of this driver,
but later he had a new OEM project, then I took over the left work about this
driver.

The machine driver of the Gen2 is accepted by upstream, so it is time to
backport it to b/c/d and oem-b kernel.

there are 3 patches for each kernel:
0001-xxx.patch is to move the gpio from codec driver to machine driver
0002-xxx.patch is to add the machine driver
0003-xxx.patch is to enable the Kconfig for this machine driver

[Impact]
The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
for this board, so the audio (line-out and line-in) can't work.


[Fix]
write a ASoC machine driver for this board, and this driver is based on
the existing driver kbl_rt5663_max98927.c


[Test Case]
play sound via line-out jack, record sound via line-in jack, all work well.


[Regression Potential]
Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
the machine with the HID:10EC3277 in the BIOS can use this driver.


Hui Wang (1):
  ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl with rt5660

Shrirang Bagul (2):
  UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
  UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m

 debian.master/config/config.common.ubuntu |   1 +
 sound/soc/codecs/rt5660.c                 |  25 -
 sound/soc/intel/boards/Kconfig            |  12 +-
 sound/soc/intel/boards/Makefile           |   2 +
 sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
 sound/soc/intel/boards/kbl_rt5660.c       | 543 ++++++++++++++++++++++
 sound/soc/intel/skylake/skl.c             |  10 +
 7 files changed, 581 insertions(+), 31 deletions(-)
 create mode 100644 sound/soc/intel/boards/kbl_rt5660.c

Comments

Seth Forshee Jan. 8, 2019, 2:09 p.m. UTC | #1
On Fri, Dec 14, 2018 at 05:11:34PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1807334
> 
> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
> based on Gen1's patches. Originally Shrirang is the developer of this driver,
> but later he had a new OEM project, then I took over the left work about this
> driver.
> 
> The machine driver of the Gen2 is accepted by upstream, so it is time to
> backport it to b/c/d and oem-b kernel.
> 
> there are 3 patches for each kernel:
> 0001-xxx.patch is to move the gpio from codec driver to machine driver
> 0002-xxx.patch is to add the machine driver
> 0003-xxx.patch is to enable the Kconfig for this machine driver
> 
> [Impact]
> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
> for this board, so the audio (line-out and line-in) can't work.
> 
> 
> [Fix]
> write a ASoC machine driver for this board, and this driver is based on
> the existing driver kbl_rt5663_max98927.c
> 
> 
> [Test Case]
> play sound via line-out jack, record sound via line-in jack, all work well.
> 
> 
> [Regression Potential]
> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
> the machine with the HID:10EC3277 in the BIOS can use this driver.

Overall I think these look reasonable. Partly updates to sauce patches,
which look reasonable to me, and a new driver which should not cause
regressions for already supported hardware. For bionic and cosmic:

Acked-by: Seth Forshee <seth.forshee@canonical.com>

However, your patches don't apply to disco/master-next or
unstable/master. Can you please supply patches for these trees? Thanks!
Hui Wang Jan. 9, 2019, 1:28 a.m. UTC | #2
On 2019/1/8 下午10:09, Seth Forshee wrote:
> On Fri, Dec 14, 2018 at 05:11:34PM +0800, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1807334
>>
>> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
>> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
>> based on Gen1's patches. Originally Shrirang is the developer of this driver,
>> but later he had a new OEM project, then I took over the left work about this
>> driver.
>>
>> The machine driver of the Gen2 is accepted by upstream, so it is time to
>> backport it to b/c/d and oem-b kernel.
>>
>> there are 3 patches for each kernel:
>> 0001-xxx.patch is to move the gpio from codec driver to machine driver
>> 0002-xxx.patch is to add the machine driver
>> 0003-xxx.patch is to enable the Kconfig for this machine driver
>>
>> [Impact]
>> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
>> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
>> for this board, so the audio (line-out and line-in) can't work.
>>
>>
>> [Fix]
>> write a ASoC machine driver for this board, and this driver is based on
>> the existing driver kbl_rt5663_max98927.c
>>
>>
>> [Test Case]
>> play sound via line-out jack, record sound via line-in jack, all work well.
>>
>>
>> [Regression Potential]
>> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
>> the machine with the HID:10EC3277 in the BIOS can use this driver.
> Overall I think these look reasonable. Partly updates to sauce patches,
> which look reasonable to me, and a new driver which should not cause
> regressions for already supported hardware. For bionic and cosmic:
>
> Acked-by: Seth Forshee <seth.forshee@canonical.com>
>
> However, your patches don't apply to disco/master-next or
> unstable/master. Can you please supply patches for these trees? Thanks!

OK, will generate the patches for those branches.

Thanks.

>
Kleber Souza Jan. 9, 2019, 11:28 a.m. UTC | #3
On 12/14/18 10:11 AM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1807334
>
> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
> based on Gen1's patches. Originally Shrirang is the developer of this driver,
> but later he had a new OEM project, then I took over the left work about this
> driver.
>
> The machine driver of the Gen2 is accepted by upstream, so it is time to
> backport it to b/c/d and oem-b kernel.
>
> there are 3 patches for each kernel:
> 0001-xxx.patch is to move the gpio from codec driver to machine driver
> 0002-xxx.patch is to add the machine driver
> 0003-xxx.patch is to enable the Kconfig for this machine driver
>
> [Impact]
> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
> for this board, so the audio (line-out and line-in) can't work.
>
>
> [Fix]
> write a ASoC machine driver for this board, and this driver is based on
> the existing driver kbl_rt5663_max98927.c
>
>
> [Test Case]
> play sound via line-out jack, record sound via line-in jack, all work well.
>
>
> [Regression Potential]
> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
> the machine with the HID:10EC3277 in the BIOS can use this driver.
>
>
> Hui Wang (1):
>   ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl with rt5660
>
> Shrirang Bagul (2):
>   UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
>   UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m
>
>  debian.master/config/config.common.ubuntu |   1 +
>  sound/soc/codecs/rt5660.c                 |  25 -
>  sound/soc/intel/boards/Kconfig            |  12 +-
>  sound/soc/intel/boards/Makefile           |   2 +
>  sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
>  sound/soc/intel/boards/kbl_rt5660.c       | 543 ++++++++++++++++++++++
>  sound/soc/intel/skylake/skl.c             |  10 +
>  7 files changed, 581 insertions(+), 31 deletions(-)
>  create mode 100644 sound/soc/intel/boards/kbl_rt5660.c
>
The changes look reasonable.

Please note that the following commit has been merged to mainline on
v5.0-rc1 with the same sha1, so the reference to the sound.git repo can
be removed.

8625db941692 ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl
with rt5660

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Stefan Bader Jan. 9, 2019, 2:40 p.m. UTC | #4
On 14.12.18 10:11, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1807334
> 
> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
> based on Gen1's patches. Originally Shrirang is the developer of this driver,
> but later he had a new OEM project, then I took over the left work about this
> driver.
> 
> The machine driver of the Gen2 is accepted by upstream, so it is time to
> backport it to b/c/d and oem-b kernel.
> 
> there are 3 patches for each kernel:
> 0001-xxx.patch is to move the gpio from codec driver to machine driver
> 0002-xxx.patch is to add the machine driver
> 0003-xxx.patch is to enable the Kconfig for this machine driver
> 
> [Impact]
> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
> for this board, so the audio (line-out and line-in) can't work.
> 
> 
> [Fix]
> write a ASoC machine driver for this board, and this driver is based on
> the existing driver kbl_rt5663_max98927.c
> 
> 
> [Test Case]
> play sound via line-out jack, record sound via line-in jack, all work well.
> 
> 
> [Regression Potential]
> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
> the machine with the HID:10EC3277 in the BIOS can use this driver.
> 
> 
> Hui Wang (1):
>   ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl with rt5660
> 
> Shrirang Bagul (2):
>   UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
>   UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m
> 
>  debian.master/config/config.common.ubuntu |   1 +
>  sound/soc/codecs/rt5660.c                 |  25 -
>  sound/soc/intel/boards/Kconfig            |  12 +-
>  sound/soc/intel/boards/Makefile           |   2 +
>  sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
>  sound/soc/intel/boards/kbl_rt5660.c       | 543 ++++++++++++++++++++++
>  sound/soc/intel/skylake/skl.c             |  10 +
>  7 files changed, 581 insertions(+), 31 deletions(-)
>  create mode 100644 sound/soc/intel/boards/kbl_rt5660.c
> 
With the modification of source that Kleber mentioned:

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khaled Elmously Jan. 10, 2019, 5 a.m. UTC | #5
Removed the reference to sound.git

On 2018-12-14 17:11:34 , Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1807334
> 
> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
> for Gen1 is already merged to b/c/d kernel, and this patchset is partly
> based on Gen1's patches. Originally Shrirang is the developer of this driver,
> but later he had a new OEM project, then I took over the left work about this
> driver.
> 
> The machine driver of the Gen2 is accepted by upstream, so it is time to
> backport it to b/c/d and oem-b kernel.
> 
> there are 3 patches for each kernel:
> 0001-xxx.patch is to move the gpio from codec driver to machine driver
> 0002-xxx.patch is to add the machine driver
> 0003-xxx.patch is to enable the Kconfig for this machine driver
> 
> [Impact]
> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
> for this board, so the audio (line-out and line-in) can't work.
> 
> 
> [Fix]
> write a ASoC machine driver for this board, and this driver is based on
> the existing driver kbl_rt5663_max98927.c
> 
> 
> [Test Case]
> play sound via line-out jack, record sound via line-in jack, all work well.
> 
> 
> [Regression Potential]
> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
> the machine with the HID:10EC3277 in the BIOS can use this driver.
> 
> 
> Hui Wang (1):
>   ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl with rt5660
> 
> Shrirang Bagul (2):
>   UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
>   UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m
> 
>  debian.master/config/config.common.ubuntu |   1 +
>  sound/soc/codecs/rt5660.c                 |  25 -
>  sound/soc/intel/boards/Kconfig            |  12 +-
>  sound/soc/intel/boards/Makefile           |   2 +
>  sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
>  sound/soc/intel/boards/kbl_rt5660.c       | 543 ++++++++++++++++++++++
>  sound/soc/intel/skylake/skl.c             |  10 +
>  7 files changed, 581 insertions(+), 31 deletions(-)
>  create mode 100644 sound/soc/intel/boards/kbl_rt5660.c
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team