[SRU,Bionic/OEM-B,0/6] Add support for ALC3277 codec on new Dell edge gateways
mbox series

Message ID 20181212092600.4505-1-hui.wang@canonical.com
Headers show
Series
  • Add support for ALC3277 codec on new Dell edge gateways
Related show

Message

Hui Wang Dec. 12, 2018, 9:25 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1807334

This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
for Gen1 is already merged to bionic kernel, and this patchset is partly
based on Gen1's patches. Originally Shrirang is the developer of this driver,
but later he had a new OEM project, then I took over the left work about this
driver.

The machine driver of the Gen2 is under the process of upstreaming
now (http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/142936.html),
but there are 2 reasons that we can't wait for it:
1) due to the schedule of project, the driver need to be merged to OEM kernel
asap.
2) because the driver of Gen1 is in the bionic kernel and ASoC API changed significantly
since kernel-4.15, the upstreamed driver can't be backported to bionic kernel easily. So
the plan is to send this patchset to bionic and oem-b kernel, and backport the
upstreamed driver to cosmic and disco kernel later.

We have 2 0006-xxx.patch, one is for bionic kernel, the other is for oem-b kernel.

[Impact]
The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
for this board, so the audio (line-out and line-in) can't work.


[Fix]
write a ASoC machine driver for this board, and this driver is based on
the existing driver kbl_rt5663_max98927.c


[Test Case]
play sound via line-out jack, record sound via line-in jack, all work well.


[Regression Potential]
Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
the machine with the HID:10EC3277 in the BIOS can use this driver.


Hui Wang (1):
  UBUNTU: SAUCE: ASoC: Intel: (no-up) Update Skylake/Kabylake alc3277
    i2s machine driver

Shrirang Bagul (5):
  UBUNTU: SAUCE: ASoC: Intel: kbl: (no-up) Add Kabylake machine driver
    for RT5660
  UBUNTU: SAUCE: ASoC: Intel: Kbl: (no-up) Add ACPI GPIO mapping for
    lineout-mute
  UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
  UBUNTU: SAUCE: ASoC: Intel: (no-up) Add Skylake/Kabylake alc3277 i2s
    machine driver entry
  UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m

 debian.master/config/config.common.ubuntu |   1 +
 sound/soc/codecs/rt5660.c                 |  25 -
 sound/soc/intel/boards/Kconfig            |  13 +
 sound/soc/intel/boards/Makefile           |   2 +
 sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
 sound/soc/intel/boards/kbl_rt5660.c       | 542 ++++++++++++++++++++++
 sound/soc/intel/skylake/skl.c             |  11 +-
 7 files changed, 582 insertions(+), 31 deletions(-)
 create mode 100644 sound/soc/intel/boards/kbl_rt5660.c

Comments

Hui Wang Dec. 14, 2018, 8:55 a.m. UTC | #1
Please ignore this thread, since the machine driver is accepted by 
upstream, I will send a new patcheset to review.

thanks.


On 2018/12/12 下午5:25, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1807334
>
> This patchset is for the Dell Edge IoT Gateway Gen2 project. The pachset
> for Gen1 is already merged to bionic kernel, and this patchset is partly
> based on Gen1's patches. Originally Shrirang is the developer of this driver,
> but later he had a new OEM project, then I took over the left work about this
> driver.
>
> The machine driver of the Gen2 is under the process of upstreaming
> now (http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/142936.html),
> but there are 2 reasons that we can't wait for it:
> 1) due to the schedule of project, the driver need to be merged to OEM kernel
> asap.
> 2) because the driver of Gen1 is in the bionic kernel and ASoC API changed significantly
> since kernel-4.15, the upstreamed driver can't be backported to bionic kernel easily. So
> the plan is to send this patchset to bionic and oem-b kernel, and backport the
> upstreamed driver to cosmic and disco kernel later.
>
> We have 2 0006-xxx.patch, one is for bionic kernel, the other is for oem-b kernel.
>
> [Impact]
> The Dell Edge IoT Gateway is based on kabylake, and the audio codec is alc3277
> which is connected to kabylake PCH via SSP0, there is no ASoC machine driver
> for this board, so the audio (line-out and line-in) can't work.
>
>
> [Fix]
> write a ASoC machine driver for this board, and this driver is based on
> the existing driver kbl_rt5663_max98927.c
>
>
> [Test Case]
> play sound via line-out jack, record sound via line-in jack, all work well.
>
>
> [Regression Potential]
> Very low, this machine driver is specific to Dell Edge IoT Gateway. Only
> the machine with the HID:10EC3277 in the BIOS can use this driver.
>
>
> Hui Wang (1):
>    UBUNTU: SAUCE: ASoC: Intel: (no-up) Update Skylake/Kabylake alc3277
>      i2s machine driver
>
> Shrirang Bagul (5):
>    UBUNTU: SAUCE: ASoC: Intel: kbl: (no-up) Add Kabylake machine driver
>      for RT5660
>    UBUNTU: SAUCE: ASoC: Intel: Kbl: (no-up) Add ACPI GPIO mapping for
>      lineout-mute
>    UBUNTU: SAUCE: ASoC: rt5660: (no-up) Move platform code to board file
>    UBUNTU: SAUCE: ASoC: Intel: (no-up) Add Skylake/Kabylake alc3277 i2s
>      machine driver entry
>    UBUNTU: [Config] CONFIG_SND_SOC_INTEL_KBL_RT5660_MACH=m
>
>   debian.master/config/config.common.ubuntu |   1 +
>   sound/soc/codecs/rt5660.c                 |  25 -
>   sound/soc/intel/boards/Kconfig            |  13 +
>   sound/soc/intel/boards/Makefile           |   2 +
>   sound/soc/intel/boards/bytcr_rt5660.c     |  19 +-
>   sound/soc/intel/boards/kbl_rt5660.c       | 542 ++++++++++++++++++++++
>   sound/soc/intel/skylake/skl.c             |  11 +-
>   7 files changed, 582 insertions(+), 31 deletions(-)
>   create mode 100644 sound/soc/intel/boards/kbl_rt5660.c
>