[0/3] benchtests: keep comparing in case of missing fields
mbox series

Message ID 20181210230504.13571-1-leonardo.sandoval.gonzalez@linux.intel.com
Headers show
Series
  • benchtests: keep comparing in case of missing fields
Related show

Message

Leonardo Sandoval Dec. 10, 2018, 11:05 p.m. UTC
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

Without this patch series, the script immediately quits the first time
a routine to compare has neither 'timings' nor 'min/mean' stats field,
so making it useless at least for bench-math benchset. Also, it includes
a new argument that allows user to define the desired statistic(s),
defaulting to min and mean.

Leonardo Sandoval (3):
  benchtests: keep comparing even if function timings do not match
  benchtests: keep comparing even if value does not exist
  benchtests: send non-consumable data to stderr

 benchtests/scripts/compare_bench.py | 34 +++++++++++++++++++----------
 1 file changed, 22 insertions(+), 12 deletions(-)

Comments

Siddhesh Poyarekar Dec. 11, 2018, 6:36 a.m. UTC | #1
On 11/12/18 4:35 AM, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> 
> Without this patch series, the script immediately quits the first time
> a routine to compare has neither 'timings' nor 'min/mean' stats field,
> so making it useless at least for bench-math benchset. Also, it includes
> a new argument that allows user to define the desired statistic(s),
> defaulting to min and mean.
> 
> Leonardo Sandoval (3):
>    benchtests: keep comparing even if function timings do not match
>    benchtests: keep comparing even if value does not exist
>    benchtests: send non-consumable data to stderr
> 
>   benchtests/scripts/compare_bench.py | 34 +++++++++++++++++++----------
>   1 file changed, 22 insertions(+), 12 deletions(-)
> 

Thank you for your patches.  The changes look OK in principle but need a 
few changes to follow the glibc Contribution guidelines.  Specifically, 
the patches need to be accompanied with a ChangeLog and also a 
descriptive text explaining the rationale of each patch.  Please review 
the contribution checklist to know more:

https://sourceware.org/glibc/wiki/Contribution%20checklist

I'll add comments to the individual patches separately.

Thanks,
Siddhesh