Message ID | 4B2BC8E6.9090007@am.sony.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote: > From: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > The option to support the old style PSK interface in the PS3 > GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> > --- > v2: Added 'depends on WLAN'. Won't you want 'depends on WLAN' for GELIC_WIRELESS instead of here? johannes
On 12/18/2009 10:30 AM, Johannes Berg wrote: > On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote: >> From: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> >> The option to support the old style PSK interface in the PS3 >> GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set >> >> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> >> --- >> v2: Added 'depends on WLAN'. > > Won't you want 'depends on WLAN' for GELIC_WIRELESS instead of here? Yes, that seems correct. I'll post an update v3. -Geoff
On Fri, 2009-12-18 at 10:24 -0800, Geoff Levand wrote: > From: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > The option to support the old style PSK interface in the PS3 > GELIC wireless drivers requires CONFIG_WEXT_PRIV to be set > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com> > --- > v2: Added 'depends on WLAN'. > > Please send to Linus asap (or I can put it in powerpc.git) as it's > breaking one of my test build configs :-) > > Just as a note, I asked Hamish to work to remove this option. > No distros use it anymore, so we don't need it. Geoff, the depends on WLAN should be on config GELIC_WIRELESS Cheers, Ben. > -Geoff > --- > drivers/net/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2357,7 +2357,9 @@ config GELIC_WIRELESS > > config GELIC_WIRELESS_OLD_PSK_INTERFACE > bool "PS3 Wireless private PSK interface (OBSOLETE)" > + depends on WLAN > depends on GELIC_WIRELESS > + select WEXT_PRIV > help > This option retains the obsolete private interface to pass > the PSK from user space programs to the driver. The PSK
--- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2357,7 +2357,9 @@ config GELIC_WIRELESS config GELIC_WIRELESS_OLD_PSK_INTERFACE bool "PS3 Wireless private PSK interface (OBSOLETE)" + depends on WLAN depends on GELIC_WIRELESS + select WEXT_PRIV help This option retains the obsolete private interface to pass the PSK from user space programs to the driver. The PSK