Message ID | 15697166.UNaCUJRTg5@vostro.rjw.lan |
---|---|
State | New |
Headers | show |
On Tue, Mar 10, 2015 at 11:10:01PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > In acpi_gpiochip_request_interrupts() the handle local > variable already contains the value that we want to pass > to acpi_walk_resources(), so it is better to use that > variable instead of evaluating ACPI_HANDLE() once more > for the same device. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 10, 2015 at 11:10 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > In acpi_gpiochip_request_interrupts() the handle local > variable already contains the value that we want to pass > to acpi_walk_resources(), so it is better to use that > variable instead of evaluating ACPI_HANDLE() once more > for the same device. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Patch applied with Mika's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux-pm/drivers/gpio/gpiolib-acpi.c =================================================================== --- linux-pm.orig/drivers/gpio/gpiolib-acpi.c +++ linux-pm/drivers/gpio/gpiolib-acpi.c @@ -300,7 +300,7 @@ void acpi_gpiochip_request_interrupts(st return; INIT_LIST_HEAD(&acpi_gpio->events); - acpi_walk_resources(ACPI_HANDLE(chip->dev), "_AEI", + acpi_walk_resources(handle, "_AEI", acpi_gpiochip_request_interrupt, acpi_gpio); }