| Message ID | f63bfa668832a8a095c5000a53abc2333fcecedd.1426339862.git.mschiffer@universe-factory.net |
|---|---|
| State | Accepted |
| Headers | show |
On 14/03/15 15:31, Matthias Schiffer wrote: > While the switch positions aren't explicitly labeled as on and off, we've heard > complaints about them being wrong. Hello, if this is about the wireless off/on switch i can confirm that with trunk on my tp-link wdr3600 v1.1 when it's on the "On" position the wifi is disabled and enabled when in the "Off" position. This patch changes the handling to match the > stock firmware. > > Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> > --- > target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c > index 99ae80d..3afc714 100644 > --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c > +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c > @@ -103,6 +103,7 @@ static struct gpio_keys_button wdr4300_gpio_keys[] __initdata = { > .code = KEY_RFKILL, > .debounce_interval = WDR4300_KEYS_DEBOUNCE_INTERVAL, > .gpio = WDR4300_GPIO_BTN_RFKILL, > + .active_low = 1, > }, > }; > >
Please Back port to Barrier Breaker I can confirm it occurs on WDR4300 on Barrier Breaker as well. On and Off states are swapped On Mar 14, 2015 9:39 PM, "Daniel Petre" <daniel.petre@gmail.com> wrote: > On 14/03/15 15:31, Matthias Schiffer wrote: > >> While the switch positions aren't explicitly labeled as on and off, we've >> heard >> complaints about them being wrong. >> > > Hello, if this is about the wireless off/on switch i can confirm that with > trunk on my tp-link wdr3600 v1.1 when it's on the "On" position the wifi is > disabled and enabled when in the "Off" position. > > This patch changes the handling to match the > >> stock firmware. >> >> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> >> --- >> target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >> b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >> index 99ae80d..3afc714 100644 >> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >> @@ -103,6 +103,7 @@ static struct gpio_keys_button wdr4300_gpio_keys[] >> __initdata = { >> .code = KEY_RFKILL, >> .debounce_interval = WDR4300_KEYS_DEBOUNCE_INTERVAL, >> .gpio = WDR4300_GPIO_BTN_RFKILL, >> + .active_low = 1, >> }, >> }; >> >> >> _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >
Hi I have seen that this has been committed to trunk but please do it for barrier breaker as well. On Mar 15, 2015 6:31 AM, "Alpha Sparc" <alphasparc@gmail.com> wrote: > Please Back port to Barrier Breaker I can confirm it occurs on WDR4300 on > Barrier Breaker as well. > On and Off states are swapped > On Mar 14, 2015 9:39 PM, "Daniel Petre" <daniel.petre@gmail.com> wrote: > >> On 14/03/15 15:31, Matthias Schiffer wrote: >> >>> While the switch positions aren't explicitly labeled as on and off, >>> we've heard >>> complaints about them being wrong. >>> >> >> Hello, if this is about the wireless off/on switch i can confirm that >> with trunk on my tp-link wdr3600 v1.1 when it's on the "On" position the >> wifi is disabled and enabled when in the "Off" position. >> >> This patch changes the handling to match the >> >>> stock firmware. >>> >>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> >>> --- >>> target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >>> b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >>> index 99ae80d..3afc714 100644 >>> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >>> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c >>> @@ -103,6 +103,7 @@ static struct gpio_keys_button wdr4300_gpio_keys[] >>> __initdata = { >>> .code = KEY_RFKILL, >>> .debounce_interval = WDR4300_KEYS_DEBOUNCE_INTERVAL, >>> .gpio = WDR4300_GPIO_BTN_RFKILL, >>> + .active_low = 1, >>> }, >>> }; >>> >>> >>> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >> >
diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c index 99ae80d..3afc714 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c @@ -103,6 +103,7 @@ static struct gpio_keys_button wdr4300_gpio_keys[] __initdata = { .code = KEY_RFKILL, .debounce_interval = WDR4300_KEYS_DEBOUNCE_INTERVAL, .gpio = WDR4300_GPIO_BTN_RFKILL, + .active_low = 1, }, };
While the switch positions aren't explicitly labeled as on and off, we've heard complaints about them being wrong. This patch changes the handling to match the stock firmware. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> --- target/linux/ar71xx/files/arch/mips/ath79/mach-tl-wdr4300.c | 1 + 1 file changed, 1 insertion(+)