diff mbox

[OpenWrt-Devel] rules.mk: add newline definition

Message ID 1426187677-10226-1-git-send-email-ardeleanalex@gmail.com
State Accepted
Headers show

Commit Message

Alexandru Ardelean March 12, 2015, 7:14 p.m. UTC
To be used for stuff like $(subst $(space),$(newline),$(SOME_VAR))

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
---
 rules.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

John Crispin March 13, 2015, 3:53 p.m. UTC | #1
Hi Alexandru,

what do you need this for ?

	John

On 12/03/2015 20:14, Alexandru Ardelean wrote:
> To be used for stuff like $(subst $(space),$(newline),$(SOME_VAR))
> 
> Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> --- 
> rules.mk | 5 +++++ 1 file changed, 5 insertions(+)
> 
> diff --git a/rules.mk b/rules.mk index 078ebe3..e61cc3f 100644 ---
> a/rules.mk +++ b/rules.mk @@ -30,6 +30,11 @@ define sep
> 
> endef
> 
> +define newline + + +endef + _SINGLE=export MAKEFLAGS=$(space); 
> CFLAGS:= ARCH:=$(subst i486,i386,$(subst i586,i386,$(subst
> i686,i386,$(call qstrip,$(CONFIG_ARCH)))))
>
Alexandru Ardelean March 13, 2015, 4:22 p.m. UTC | #2
On Fri, Mar 13, 2015 at 5:53 PM, John Crispin <blogic@openwrt.org> wrote:

> Hi Alexandru,
>
> what do you need this for ?
>
>         John
>
> On 12/03/2015 20:14, Alexandru Ardelean wrote:
> > To be used for stuff like $(subst $(space),$(newline),$(SOME_VAR))
> >
> > Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> ---
> > rules.mk | 5 +++++ 1 file changed, 5 insertions(+)
> >
> > diff --git a/rules.mk b/rules.mk index 078ebe3..e61cc3f 100644 ---
> > a/rules.mk +++ b/rules.mk @@ -30,6 +30,11 @@ define sep
> >
> > endef
> >
> > +define newline + + +endef + _SINGLE=export MAKEFLAGS=$(space);
> > CFLAGS:= ARCH:=$(subst i486,i386,$(subst i586,i386,$(subst
> > i686,i386,$(call qstrip,$(CONFIG_ARCH)))))
> >
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>

Hello,
I'd need it for the Python package:
https://github.com/openwrt/packages/blob/master/lang/python/Makefile
I am generating filespecs from iterable variables.

I can live with just leaving it in the Python Makefile, but I was thinking
that since I'm going to replicate this in Python3, I could probably ask to
put it in a more common place.
Not sure if it will be useful to anyone else ever.

Semi-offtopic: I do not like the filespec approach in the Python package
either, but it was there since before I picked up that package.
I'll probably remove/rework that later when I feel like dealing with
fallout from users of the Python package.
diff mbox

Patch

diff --git a/rules.mk b/rules.mk
index 078ebe3..e61cc3f 100644
--- a/rules.mk
+++ b/rules.mk
@@ -30,6 +30,11 @@  define sep
 
 endef
 
+define newline
+
+
+endef
+
 _SINGLE=export MAKEFLAGS=$(space);
 CFLAGS:=
 ARCH:=$(subst i486,i386,$(subst i586,i386,$(subst i686,i386,$(call qstrip,$(CONFIG_ARCH)))))