diff mbox

[3/3] Added support for PHP/SQLite3 (non PDO).

Message ID 1425850629-14725-3-git-send-email-mc5686@mclink.it
State Accepted
Headers show

Commit Message

Mauro Condarelli March 8, 2015, 9:37 p.m. UTC
Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
---
 package/php/Config.ext |    6 ++++++
 package/php/php.mk     |    4 ++++
 2 files changed, 10 insertions(+)

Comments

Gustavo Zacarias March 9, 2015, 12:26 p.m. UTC | #1
On 03/08/2015 06:37 PM, Mauro Condarelli wrote:

> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
> ---
>  package/php/Config.ext |    6 ++++++
>  package/php/php.mk     |    4 ++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/package/php/Config.ext b/package/php/Config.ext
> index daf16c7..57685b2 100644
> --- a/package/php/Config.ext
> +++ b/package/php/Config.ext
> @@ -120,6 +120,12 @@ config BR2_PACKAGE_PHP_EXT_MYSQLI
>  	help
>  	  MySQL Improved extension support
>  
> +config BR2_PACKAGE_PHP_EXT_SQLITE
> +	bool "SQLite3"
> +	select BR2_PACKAGE_SQLITE
> +	help
> +	  SQLite3 support
> +

We normally sort entries in menu entries (inside categories of course).
But given that PDO is a distinct class of database support within PHP:

Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Thomas Petazzoni March 9, 2015, 1:08 p.m. UTC | #2
Dear Mauro Condarelli,

On Sun,  8 Mar 2015 22:37:09 +0100, Mauro Condarelli wrote:
> 
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
> ---
>  package/php/Config.ext |    6 ++++++
>  package/php/php.mk     |    4 ++++
>  2 files changed, 10 insertions(+)

Thanks, applied! And thanks Gustavo for the review/ack.

Thomas
diff mbox

Patch

diff --git a/package/php/Config.ext b/package/php/Config.ext
index daf16c7..57685b2 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -120,6 +120,12 @@  config BR2_PACKAGE_PHP_EXT_MYSQLI
 	help
 	  MySQL Improved extension support
 
+config BR2_PACKAGE_PHP_EXT_SQLITE
+	bool "SQLite3"
+	select BR2_PACKAGE_SQLITE
+	help
+	  SQLite3 support
+
 config BR2_PACKAGE_PHP_EXT_PDO
 	bool "PDO"
 	help
diff --git a/package/php/php.mk b/package/php/php.mk
index dd52508..b5daeb6 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -154,6 +154,10 @@  ifeq ($(BR2_PACKAGE_PHP_EXT_MYSQLI),y)
 	PHP_CONF_OPTS += --with-mysqli=$(STAGING_DIR)/usr/bin/mysql_config
 	PHP_DEPENDENCIES += mysql
 endif
+ifeq ($(BR2_PACKAGE_PHP_EXT_SQLITE),y)
+	PHP_CONF_OPTS += --with-sqlite3=$(STAGING_DIR)/usr
+	PHP_DEPENDENCIES += sqlite
+endif
 
 ### PDO
 ifeq ($(BR2_PACKAGE_PHP_EXT_PDO),y)