| Message ID | a91e34bf2595157830d599cb66becd52247b1819.1257383766.git.wuzhangjin@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Nov 05, 2009 at 09:21:54AM +0800, Wu Zhangjin wrote: > This patch fixes the following warning with RTC_LIB on MIPS: > > drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of > RTC+NVRAM address space, not 64 bytes. > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. -~----------~----~----~----~------~----~------~--~---
On Thu, 2009-11-05 at 08:41 +0100, Ralf Baechle wrote: > On Thu, Nov 05, 2009 at 09:21:54AM +0800, Wu Zhangjin wrote: > > > This patch fixes the following warning with RTC_LIB on MIPS: > > > > drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of > > RTC+NVRAM address space, not 64 bytes. > > > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> > > Acked-by: Ralf Baechle <ralf@linux-mips.org> > > > Ralf Hi, Paul or Alessandro Could you please apply this pathset? thanks! Regards, Wu Zhangjin --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. -~----------~----~----~----~------~----~------~--~---
On Thu, Nov 05, 2009 at 09:21:54AM +0800, Wu Zhangjin wrote: > This patch fixes the following warning with RTC_LIB on MIPS: > > drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of > RTC+NVRAM address space, not 64 bytes. > > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> > --- > drivers/rtc/rtc-cmos.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c > index f7a4701..21e48f7 100644 > --- a/drivers/rtc/rtc-cmos.c > +++ b/drivers/rtc/rtc-cmos.c > @@ -691,7 +691,8 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) > */ > #if defined(CONFIG_ATARI) > address_space = 64; > -#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) || defined(__sparc__) > +#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \ > + || defined(__sparc__) || defined(__mips__) > address_space = 128; > #else > #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes. Ping. This patch is now nearly a month old and I haven't yet heared anything. This was actually meant to be 2.6.32 material. Ralf
On Thu, 3 Dec 2009 15:56:04 +0000 Ralf Baechle <ralf@linux-mips.org> wrote: > Ping. > > This patch is now nearly a month old and I haven't yet heared anything. > This was actually meant to be 2.6.32 material. I supposed MIPS things were handled by the MIPS tree. If there's urgency a submitter should specify the intended delivery path (trivial, mips, rtc, directly to Andrew) and kernel release. Acked-by: Alessandro Zummo <a.zummo@towertech.it>
On Thu, 2009-12-03 at 17:14 +0100, Alessandro Zummo wrote: > On Thu, 3 Dec 2009 15:56:04 +0000 > Ralf Baechle <ralf@linux-mips.org> wrote: > > > Ping. > > > > This patch is now nearly a month old and I haven't yet heared anything. > > This was actually meant to be 2.6.32 material. > > I supposed MIPS things were handled by the MIPS tree. If there's > urgency a submitter should specify the intended delivery path > (trivial, mips, rtc, directly to Andrew) and kernel release. > > Acked-by: Alessandro Zummo <a.zummo@towertech.it> Hi, Alessandro Zummo Could you please review the left two(only patch 2/3 for rtc tree) for 2.6.33 in http://patchwork.linux-mips.org/bundle/ralf/rtc/ ? [v1,2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f [v1,3/3,loongson] RTC: Registration of Loongson RTC platform device (Sorry, I can not find them in my Email client currently, so can not reply the old Email thread directly, If necessary, I will resend them, thanks!) Best Regards, Wu Zhangjin
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index f7a4701..21e48f7 100644 --- a/drivers/rtc/rtc-cmos.c +++ b/drivers/rtc/rtc-cmos.c @@ -691,7 +691,8 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq) */ #if defined(CONFIG_ATARI) address_space = 64; -#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) || defined(__sparc__) +#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \ + || defined(__sparc__) || defined(__mips__) address_space = 128; #else #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes.
This patch fixes the following warning with RTC_LIB on MIPS: drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes. Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com> --- drivers/rtc/rtc-cmos.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)