| Message ID | 1421846317-7088-1-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
Ping? Markus Armbruster <armbru@redhat.com> writes: > The "fall through" added by the commit is clearly intentional. Mark > it so. Hushes up Coverity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > hw/net/xilinx_ethlite.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 9536f64..ad6b553 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr, > if (!(value & CTRL_S)) { > qemu_flush_queued_packets(qemu_get_queue(s->nic)); > } > + /* fall through */ > case R_TX_LEN0: > case R_TX_LEN1: > case R_TX_GIE0:
On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote: > The "fall through" added by the commit is clearly intentional. Mark > it so. Hushes up Coverity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > hw/net/xilinx_ethlite.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 9536f64..ad6b553 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr, > if (!(value & CTRL_S)) { > qemu_flush_queued_packets(qemu_get_queue(s->nic)); > } > + /* fall through */ > case R_TX_LEN0: > case R_TX_LEN1: > case R_TX_GIE0: > -- > 1.9.3 > >
Since maintainers haven't picked it up: could this go in via -trivial? Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes: > On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote: >> The "fall through" added by the commit is clearly intentional. Mark >> it so. Hushes up Coverity. >> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> > > Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > >> --- >> hw/net/xilinx_ethlite.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c >> index 9536f64..ad6b553 100644 >> --- a/hw/net/xilinx_ethlite.c >> +++ b/hw/net/xilinx_ethlite.c >> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr, >> if (!(value & CTRL_S)) { >> qemu_flush_queued_packets(qemu_get_queue(s->nic)); >> } >> + /* fall through */ >> case R_TX_LEN0: >> case R_TX_LEN1: >> case R_TX_GIE0: >> -- >> 1.9.3 >> >>
10.02.2015 15:03, Markus Armbruster wrote: > Since maintainers haven't picked it up: could this go in via -trivial? > > Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes: > >> On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote: >>> The "fall through" added by the commit is clearly intentional. Mark >>> it so. Hushes up Coverity. Applied to -trivial, thank you! /mjt
diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index 9536f64..ad6b553 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr, if (!(value & CTRL_S)) { qemu_flush_queued_packets(qemu_get_queue(s->nic)); } + /* fall through */ case R_TX_LEN0: case R_TX_LEN1: case R_TX_GIE0:
The "fall through" added by the commit is clearly intentional. Mark it so. Hushes up Coverity. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- hw/net/xilinx_ethlite.c | 1 + 1 file changed, 1 insertion(+)