| Message ID | 1421666844-14599-1-git-send-email-ricardo.ribalda@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 19, 2015 at 12:27 PM, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > Instead of parsing manually the shadow content, use the much simpler > helper of_property_read_u32. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: John Crispin <blogic@openwrt.org> > Cc: devicetree@vger.kernel.org > Cc: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > > v2: Reported by Mark Rutland <mark.rutland@arm.com> > -use of_property_read_u32 instead of u16 This v2 version applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c index 7d55161..95ff180 100644 --- a/drivers/gpio/gpio-mm-lantiq.c +++ b/drivers/gpio/gpio-mm-lantiq.c @@ -105,7 +105,7 @@ static void ltq_mm_save_regs(struct of_mm_gpio_chip *mm_gc) static int ltq_mm_probe(struct platform_device *pdev) { struct ltq_mm *chip; - const __be32 *shadow; + u32 shadow; chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL); if (!chip) @@ -117,9 +117,8 @@ static int ltq_mm_probe(struct platform_device *pdev) chip->mmchip.save_regs = ltq_mm_save_regs; /* store the shadow value if one was passed by the devicetree */ - shadow = of_get_property(pdev->dev.of_node, "lantiq,shadow", NULL); - if (shadow) - chip->shadow = be32_to_cpu(*shadow); + if (!of_property_read_u32(pdev->dev.of_node, "lantiq,shadow", &shadow)) + chip->shadow = shadow; return of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); }
Instead of parsing manually the shadow content, use the much simpler helper of_property_read_u32. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Grant Likely <grant.likely@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: John Crispin <blogic@openwrt.org> Cc: devicetree@vger.kernel.org Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- v2: Reported by Mark Rutland <mark.rutland@arm.com> -use of_property_read_u32 instead of u16 drivers/gpio/gpio-mm-lantiq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)