| Message ID | 20091125171248.5446.22482.sendpatchset@localhost |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 25 Nov 2009 18:12:48 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] libata: add private driver field to struct ata_device > > This brings struct ata_device in-line with struct ata_{port,host}. Do we need it for anything yet - whoever first needs it can add it, otherwise its just waste. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 25 November 2009 06:56:50 pm Alan Cox wrote: > On Wed, 25 Nov 2009 18:12:48 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Subject: [PATCH] libata: add private driver field to struct ata_device > > > > This brings struct ata_device in-line with struct ata_{port,host}. > > Do we need it for anything yet - whoever first needs it can add it, > otherwise its just waste. There is a new driver using it (to be posted later) and it makes libata API more coherent for driver developers.. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 25 Nov 2009 19:02:44 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > On Wednesday 25 November 2009 06:56:50 pm Alan Cox wrote: > > On Wed, 25 Nov 2009 18:12:48 +0100 > > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > > Subject: [PATCH] libata: add private driver field to struct ata_device > > > > > > This brings struct ata_device in-line with struct ata_{port,host}. > > > > Do we need it for anything yet - whoever first needs it can add it, > > otherwise its just waste. > > There is a new driver using it (to be posted later) and it makes libata API > more coherent for driver developers.. Ok by me -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/25/2009 12:12 PM, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > Subject: [PATCH] libata: add private driver field to struct ata_device > > This brings struct ata_device in-line with struct ata_{port,host}. > > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > --- > include/linux/libata.h | 1 + > 1 file changed, 1 insertion(+) > > Index: b/include/linux/libata.h > =================================================================== > --- a/include/linux/libata.h > +++ b/include/linux/libata.h > @@ -585,6 +585,7 @@ struct ata_device { > unsigned int horkage; /* List of broken features */ > unsigned long flags; /* ATA_DFLAG_xxx */ > struct scsi_device *sdev; /* attached SCSI device */ > + void *private_data; > #ifdef CONFIG_ATA_ACPI > acpi_handle acpi_handle; > union acpi_object *gtf_cache; I'm fine with this, and would like to merge this sooner rather than later. However, BIG FAT WARNING: you must take special care to be sure you don't leak as devices appear and disappear, etc. IOW, watch your object lifetimes carefully. Object lifetime was the reason this was not added until now. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 03 December 2009 09:04:40 am Jeff Garzik wrote: > On 11/25/2009 12:12 PM, Bartlomiej Zolnierkiewicz wrote: > > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > > Subject: [PATCH] libata: add private driver field to struct ata_device > > > > This brings struct ata_device in-line with struct ata_{port,host}. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > > --- > > include/linux/libata.h | 1 + > > 1 file changed, 1 insertion(+) > > > > Index: b/include/linux/libata.h > > =================================================================== > > --- a/include/linux/libata.h > > +++ b/include/linux/libata.h > > @@ -585,6 +585,7 @@ struct ata_device { > > unsigned int horkage; /* List of broken features */ > > unsigned long flags; /* ATA_DFLAG_xxx */ > > struct scsi_device *sdev; /* attached SCSI device */ > > + void *private_data; > > #ifdef CONFIG_ATA_ACPI > > acpi_handle acpi_handle; > > union acpi_object *gtf_cache; > > I'm fine with this, and would like to merge this sooner rather than later. > > However, BIG FAT WARNING: you must take special care to be sure you > don't leak as devices appear and disappear, etc. IOW, watch your object > lifetimes carefully. Object lifetime was the reason this was not added > until now. It should be fine for now as the only user is pata_ep93xx and it gets it right. Though it would definitely be nice to see the underlying issue (which is the lack of dynamic allocation for struct ata_device objects) fixed one day in libata. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/25/2009 12:12 PM, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > Subject: [PATCH] libata: add private driver field to struct ata_device > > This brings struct ata_device in-line with struct ata_{port,host}. > > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com> > --- > include/linux/libata.h | 1 + > 1 file changed, 1 insertion(+) > > Index: b/include/linux/libata.h > =================================================================== > --- a/include/linux/libata.h > +++ b/include/linux/libata.h > @@ -585,6 +585,7 @@ struct ata_device { > unsigned int horkage; /* List of broken features */ > unsigned long flags; /* ATA_DFLAG_xxx */ > struct scsi_device *sdev; /* attached SCSI device */ > + void *private_data; > #ifdef CONFIG_ATA_ACPI > acpi_handle acpi_handle; > union acpi_object *gtf_cache; applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/include/linux/libata.h =================================================================== --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -585,6 +585,7 @@ struct ata_device { unsigned int horkage; /* List of broken features */ unsigned long flags; /* ATA_DFLAG_xxx */ struct scsi_device *sdev; /* attached SCSI device */ + void *private_data; #ifdef CONFIG_ATA_ACPI acpi_handle acpi_handle; union acpi_object *gtf_cache;