Message ID | 20091125171039.5446.68680.sendpatchset@localhost |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Wed, 25 Nov 2009 18:10:39 +0100 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_scc: add 32-bit PIO support > > There shouldn't be any problems with it as IDE scc_pata host driver > has been allowing 32-bit PIO operations for years. NAK; Read the code - it uses its own private data_xfer handler anyway -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 25 November 2009 06:48:44 pm Alan Cox wrote: > On Wed, 25 Nov 2009 18:10:39 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Subject: [PATCH] pata_scc: add 32-bit PIO support > > > > There shouldn't be any problems with it as IDE scc_pata host driver > > has been allowing 32-bit PIO operations for years. > > NAK; Read the code - it uses its own private data_xfer handler anyway Ah, this one can be indeed dropped. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_scc.c =================================================================== --- a/drivers/ata/pata_scc.c +++ b/drivers/ata/pata_scc.c @@ -966,7 +966,7 @@ static struct scsi_host_template scc_sht }; static struct ata_port_operations scc_pata_ops = { - .inherits = &ata_bmdma_port_ops, + .inherits = &ata_bmdma32_port_ops, .set_piomode = scc_set_piomode, .set_dmamode = scc_set_dmamode,